Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp8192411ybi; Thu, 6 Jun 2019 08:09:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPF4roTbBbmbUM6t+mYRwev/hxvCEllUpSSWSBLsMqR8GEO5qwxJ7FJJ1NCKvDn0navLps X-Received: by 2002:a63:3dcf:: with SMTP id k198mr3842132pga.60.1559833787959; Thu, 06 Jun 2019 08:09:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559833787; cv=none; d=google.com; s=arc-20160816; b=mxvsZAulWbuu0uFIQ7AepdIrYnW59+557wP1/lSo64YMEs1Bghi3EPUokrgjoP2F+e kpr/2hHWKmG2nl+AOnIGDSpp+mWJemexWj2+3ca/pBmC5y40Egin/bs+tnOPhQNHxwa7 12SRC6X1QeoMdLonqawmNTw5qqXLgJi+J+kCAJqSNYV4GddADErU32L6GlI1d2JzBgbb xxjgOGTSfP1IY25e1art+sMgzLFAwzwUehKNzIN33MgKdxUIzdvfFX5ekRAwC782QRkC HhyaGYoJfpJtof31ila4UJxwdw+Ecp4JTDhfWwCqeShlHqxGHGBB6NUeax5paa9+e+JF KlWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization; bh=fW/Y3LeDSW/jdSRtAlFgkzbWNdTQyBSYIocD7nvf6vw=; b=hL9THJ4JPKOZPulhArcoHVPRSUItDzFcTGRGbcoROEIj4PEujxjgNNRJ0hwKSQDXFV V8gEKECcFglPH96w5HWCKwRuKWrJzI/TZb6SLMlOzXMeRzCFDHg0+I+3Slw0tUR9rMCF eLZTngkzen/ZXwFH9RURJ/xhTc/XYDqY8kd8lLjb73kUNFczV4z6khBc/v9l22Hx9nT/ O4t5Nl2c/gzNuvXSTpApNNz1PXAMtFS0j8heVhWXXTavwayjIDnRTGiTUt1+yCGD4l4i 7Yqe+mbFz6UyBXPTChGKqaoYQkvcqTA6+d8w3mn7iqmEvPf275hsTZWtV8DgSGEPg3UJ +Mwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si1930076pln.207.2019.06.06.08.09.29; Thu, 06 Jun 2019 08:09:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729155AbfFFPGV convert rfc822-to-8bit (ORCPT + 99 others); Thu, 6 Jun 2019 11:06:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727309AbfFFPGU (ORCPT ); Thu, 6 Jun 2019 11:06:20 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0269B3086200; Thu, 6 Jun 2019 15:06:20 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-173.rdu2.redhat.com [10.10.120.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id C86F810ABD60; Thu, 6 Jun 2019 15:06:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <176F8189-3BE9-4B8C-A4D5-8915436338FB@amacapital.net> References: <176F8189-3BE9-4B8C-A4D5-8915436338FB@amacapital.net> <155981411940.17513.7137844619951358374.stgit@warthog.procyon.org.uk> <155981413016.17513.10540579988392555403.stgit@warthog.procyon.org.uk> To: Andy Lutomirski Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, Casey Schaufler , raven@themaw.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] security: Override creds in __fput() with last fputter's creds [ver #3] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11030.1559833574.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 06 Jun 2019 16:06:14 +0100 Message-ID: <11031.1559833574@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 06 Jun 2019 15:06:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski wrote: > > So that the LSM can see the credentials of the last process to do an fput() > > on a file object when the file object is being dismantled, do the following > > steps: > > > > I still maintain that this is a giant design error. Yes, I know. This was primarily a post so that Greg could play with the USB notifications stuff I added. The LSM support isn't resolved and is unchanged. > Can someone at least come up with a single valid use case that isn't > entirely full of bugs? "Entirely full of bugs"? How would you propose I deal with Casey's requirement? I'm getting the feeling you're going to nak it if I try to fulfil that and he's going to nak it if I don't. David