Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp8415435ybi; Thu, 6 Jun 2019 11:57:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2WAGUPpaq6nqtllbT6urV9GqhTMpd1Cxev9emr081Cn2ht3CsaDMvOWS37kFF11RnhMQg X-Received: by 2002:a63:c20c:: with SMTP id b12mr22859pgd.3.1559847454740; Thu, 06 Jun 2019 11:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559847454; cv=none; d=google.com; s=arc-20160816; b=XZG+K4lBS5DWW/PDHtpV0cTCnjUMpqy/33PjUmlHaynYRyEyI6qB8fWjOJY03A5NMM 9ZNOzNO2nUA9rIqaNLSmIHRUH4kZtxBLBtjrZ2wyYEoY3/Q7nYl9Ow7mkPd8Vt6I6biO mQyfD/i7dV5wmoqnGVkqtYVSXOyUUorr9YrjsuHAL3UMhgbdT3g63MlcMJC8vlgKVZxR dimj0Tbt929CFubSfX5BX2zEdcciQ2QV/TBs5G7r1DgO2F0Kummu+Bon/QsD12SSwmtP f80FJTRl7uRfhnOsyTBkm/QAqnCFTbxaFDYtECVrHkCGQd0P2K9fmZT5GfxGxQ6zzuBt 1m4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=3LKp2333dAsdHgcKPbSCpFKyWi/YPsxy5d/uBrW1vJw=; b=GH00+eq26/z6pwZqLLQYd/HVJXLIcDqjACEniN19xRKnrpSX9nJQdXRmoUF8G9VreO /TvH680Yr3j8N2/7OwtnaUu1oTkyo4nAk+ZUDz3p08fnFYLK3qkOpUDp163lQIzTCsiD oK18PZE/IPGrGwQq6l4VM2XsC+6zy7o1r6Luw3AmElaDwACxMJ2OtzT3wugWLNST+4PV 9aawG1Oi995UxdbfmeAejs82Ea2DFc8iCgvm2ukI0ykc9y3RbFIzwTXYJtVROmJEKm5h b2mq6NHWbzvNtMtkaFtOhMnciOiIAK1NVzhdh5ogcJ7+vnzB2k+zpcVkeeRZqFtyFRsQ Eotw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ufbn7N0j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si2431708pji.88.2019.06.06.11.57.17; Thu, 06 Jun 2019 11:57:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ufbn7N0j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730115AbfFFRZw (ORCPT + 99 others); Thu, 6 Jun 2019 13:25:52 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41232 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfFFRZv (ORCPT ); Thu, 6 Jun 2019 13:25:51 -0400 Received: by mail-pg1-f193.google.com with SMTP id 83so1723609pgg.8 for ; Thu, 06 Jun 2019 10:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=3LKp2333dAsdHgcKPbSCpFKyWi/YPsxy5d/uBrW1vJw=; b=ufbn7N0jryrG0HOBOgiTOLSXC+8CPoOdNvpRg5ioCQ2Qnq3/MrgCcULLU781HRzV/Q FyI1xMLATPNfnzoHevVmHhEXmu0Xb3yn/a/9SpyrVKYJmdbTqEyUtphCSQkrcuaaX+p2 adStH4+ROigx3lYaPqm8G8VWsXfWia6rq8hgPt3dBflYTEzen7o/cT/jlTXf/BHfde5S Rvg73ZoiiSSqjn6td0HTTOV6iHyNqYfY9lysMaLD7aAicDH2SlsSwX1J4n1H/vRwl6MB VGx72V80nauy5tZgAFakAmBVh8F0Ja4xXvg/+RxALTR++Q0atOThCsvkcv1gNEd/HkWz LwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3LKp2333dAsdHgcKPbSCpFKyWi/YPsxy5d/uBrW1vJw=; b=eqPPFyuZT2FhktMFbMRAmYMJZB58i7BFg6dEmaO1wQswJsxds6YUbU6gUKy82M57pD yO4tPDmBtoWaC+S9x0V2QYx4eIBP4gT0W7k1op+xpmqRVnkrt826CfP8rKL6CVoRJMhN SIZ1uVs3AaBBTP+dUGDPRxskccIlFK6nU7a+2B3EE5qkSWa/19EcktBZ+MH7xmD1sxTp PN0Q+cTQ/NzzeNWt24+c6BugmxcnLeOWhQRL+ygKkZ2AZOmK7dfqp+nP6g0xw1w26XO4 vhfkCaoVgSncSUB+gBfnYAXA0YRCpaYG/OBqezpnAYz+AnpbNmu3ZPyrEr6kcAKeFkkA z4Ow== X-Gm-Message-State: APjAAAULQbWPD2ZQb7c59estTFY2V8DG1daBO1P8Td8oaJrs0iv7RnGA AgcgUCAegNuL2MIRAP9v0W51Mg== X-Received: by 2002:a63:445b:: with SMTP id t27mr4314682pgk.56.1559841950934; Thu, 06 Jun 2019 10:25:50 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.googlemail.com with ESMTPSA id t4sm2201097pjq.19.2019.06.06.10.25.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Jun 2019 10:25:50 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong , dri-devel@lists.freedesktop.org Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong Subject: Re: [PATCH 1/2] drm/meson: fix primary plane disabling In-Reply-To: <20190605141253.24165-2-narmstrong@baylibre.com> References: <20190605141253.24165-1-narmstrong@baylibre.com> <20190605141253.24165-2-narmstrong@baylibre.com> Date: Thu, 06 Jun 2019 10:25:49 -0700 Message-ID: <7h8sueeici.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neil Armstrong writes: > The primary plane disable logic is flawed, when the primary plane is > disabled, it is re-enabled in the vsync irq when another plane is updated. > > Handle the plane disabling correctly by handling the primary plane > enable flag in the primary plane update & disable callbacks. > > Fixes: 490f50c109d1 ("drm/meson: Add G12A support for OSD1 Plane") > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman