Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp8420112ybi; Thu, 6 Jun 2019 12:01:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhQExGgcQow2qXeaH0W7cI39DS/ie0hikrw/l9Izp8EJqfoozFSfB0W6K+kTJY6IwFPMSl X-Received: by 2002:a17:902:b490:: with SMTP id y16mr46251111plr.117.1559847703852; Thu, 06 Jun 2019 12:01:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559847703; cv=none; d=google.com; s=arc-20160816; b=YuCkgQeT8whu95IPzes1xF+zyL5MhckMdWYNxOW9nS06TPhnsBJ9UHr6ja01XAC/l2 hf4CR0V+ky+/K6ABmEs5KDjnxAIqWNfX6qUeHQL/TbPiWJc0pKIp4S4bIE1Cps8z8spz O1e8+2tXtHp/BmQCYWu2WS/mzTJYyLO2m/U8GBgiUFqPy3BvWTe3tZyHPWq8DqgEGwdG iZHDV5WcU5vEkHRDrjHqps4wLQ8i7MIVgGqP50M9cLjjL+jQZ2Mlm9u1nYSeEq4OkRuu yPOO46n9Mh8etYq6xlvFmgETrQxLTzoCBcK4zpKocoApp8BYwAIsJVCaybU32CnzKFnd LPjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2yeuLVsMa1DmJI9tkrnZl8OaHUbyAuwu974cY3hr0LE=; b=1IICbfUBdSedTv97z4DzvlBQ7OnFxh1KWYiNzkSUalDAfZ9jl42S4lkTVQJLp0dU5F 4fi6GXHVvS/U8KwTkh7QeBbJB7n0F2e83xZS9SdaOQjND6gG922qA7Vxyv7zkLY9BfDM cAMV+t3iLxH4zT1DMRh1LGItVF0r4GgCk3QKf2TtJ+XODTDOsE6Hz3BpsH2tKegwJCeO cA6VNiVnHO11MZhK1HLnZ06NFUDluyJST/Ij/R1eIjsPgBjXSozf1xBhwPQbpd+kJTGz Ms3rSBVCjdQ2d7xVEhnx6RwJN6lDlYy0pfj0tlkZahYBRIkHsYVTTNIKyS0JURH/UV9s 1THg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cq23si2419920pjb.59.2019.06.06.12.01.27; Thu, 06 Jun 2019 12:01:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730238AbfFFRj0 (ORCPT + 99 others); Thu, 6 Jun 2019 13:39:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54682 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728646AbfFFRjZ (ORCPT ); Thu, 6 Jun 2019 13:39:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D6B7014DD4FB6; Thu, 6 Jun 2019 10:39:24 -0700 (PDT) Date: Thu, 06 Jun 2019 10:39:24 -0700 (PDT) Message-Id: <20190606.103924.1369913278652387015.davem@davemloft.net> To: maxime.chevallier@bootlin.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com Subject: Re: [PATCH net] net: mvpp2: Use strscpy to handle stat strings From: David Miller In-Reply-To: <20190606084256.3703-1-maxime.chevallier@bootlin.com> References: <20190606084256.3703-1-maxime.chevallier@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Jun 2019 10:39:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Chevallier Date: Thu, 6 Jun 2019 10:42:56 +0200 > Use a safe strscpy call to copy the ethtool stat strings into the > relevant buffers, instead of a memcpy that will be accessing > out-of-bound data. > > Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics") > Signed-off-by: Maxime Chevallier Applied and queued up for -stable.