Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Daniel Borkmann <daniel@iogearbox.net>
CC:     Alexei Starovoitov <ast@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use
 bpf_get_current_cgroup_id() helper
Thread-Topic: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use
 bpf_get_current_cgroup_id() helper
Thread-Index: AQHVHJn5xFnlIJGy00O8LdScbBruEqaOh76AgAB+MYCAAAPXgA==
Date:   Thu, 6 Jun 2019 19:53:25 +0000
Message-ID: <20190606195317.GA22965@tower.DHCP.thefacebook.com>
References: <20190606185911.4089151-1-guro@fb.com>
 <20190606190752.GA28743@tower.DHCP.thefacebook.com>
 <a604b9eb-4e39-c4ec-0868-bac360bc2fb4@iogearbox.net>
In-Reply-To: <a604b9eb-4e39-c4ec-0868-bac360bc2fb4@iogearbox.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::d13]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9d8d0dca-6e25-491e-8516-08d6eab8a2ed
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN8PR15MB3091;
x-ms-traffictypediagnostic: BN8PR15MB3091:
x-microsoft-antispam-prvs: <BN8PR15MB30912D0C32B8E5B6F0C5EF99BE170@BN8PR15MB3091.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 00603B7EEF
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(39860400002)(136003)(346002)(396003)(54094003)(199004)(189003)(102836004)(33656002)(9686003)(6506007)(386003)(53546011)(6512007)(478600001)(73956011)(53936002)(66946007)(66476007)(66556008)(64756008)(66446008)(6246003)(14454004)(4326008)(7736002)(305945005)(6486002)(6436002)(25786009)(81156014)(81166006)(8676002)(8936002)(76176011)(68736007)(52116002)(229853002)(54906003)(99286004)(86362001)(2906002)(446003)(256004)(11346002)(186003)(486006)(476003)(46003)(1076003)(6916009)(5660300002)(316002)(71200400001)(71190400001)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB3091;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 7aVdQhVrbLJWhidndTt7yvPiOqLspKeumR8b9TjJvP1r+qMlm2gLHj6/FY0L1vRK6wi/+CdVzTR1l089e5FeP/jL1z44bA8vQWPJ8Mh3ABqm39ePg/ROCATjjZg6fg0TrTtcYqVxOLvoGz1nvMxbtJ+IssZfKdrTLcqsXMRsh0tQ0xJ/OpeihR8qIH4uwS6Q/e4mSU8SCo85+9GK/yL3Gdlayl5/f7qKu5N8554N2aXZNY6GSRs6qSZ1CxoykELU+/R5eZEM3pppgzeaizZcAUCCWl5TVJKKm/lIh4kdv8LH1mKXJU9KHALWMNs/3AmMKzZmXe370YrjWjzpdbZJHhrA0fo7H39qS839NxJZEcTLjcVNKasYwb9qHKhG3oEwhG1ewZUq0nVpi/iIlDHaMaAghd24QCp3DhUEcwO8ahI=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ADAE58DE5AB08F4982D94507975F0950@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8d0dca-6e25-491e-8516-08d6eab8a2ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 19:53:25.1039
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: guro@fb.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB3091
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-06_14:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=722 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906060133
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 06, 2019 at 09:39:35PM +0200, Daniel Borkmann wrote:
> On 06/06/2019 09:08 PM, Roman Gushchin wrote:
> > On Thu, Jun 06, 2019 at 11:59:11AM -0700, Roman Gushchin wrote:
> >> Currently bpf_get_current_cgroup_id() is not supported for
> >> CGROUP_SKB programs. An attempt to load such a program generates an
> >> error like this:
> >>     libbpf:
> >>     0: (b7) r6 =3D 0
> >>     ...
> >>     8: (63) *(u32 *)(r10 -28) =3D r6
> >>     9: (85) call bpf_get_current_cgroup_id#80
> >>     unknown func bpf_get_current_cgroup_id#80
> >>
> >> There are no particular reasons for denying it,
> >> and we have some use cases where it might be useful.
> >=20
> > Ah, sorry, it's not so simple, as we probably need to take
> > the cgroup pointer from the socket, not from current.
> >=20
> > So the implementation of the helper should be different
> > for this type of programs.
> >=20
> > So I wonder if it's better to introduce a new helper
> > bpf_get_sock_cgroup_id()?
> >=20
> > What do you think?
>=20
> We do have bpf_skb_cgroup_id(), did you give that a try?

It also isn't supported for CGROUP_SKB, but other than that looks
exactly what I need.

Thank you for pointing at it!