Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp8604095ybi; Thu, 6 Jun 2019 15:41:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxI5AIw+Yc0nHT6MXjLUhUML+4W4UP0gkg1PHOXlHVFcgKSye79M0NedAVD2iBU0p3xf44N X-Received: by 2002:aa7:8d10:: with SMTP id j16mr41798744pfe.204.1559860880660; Thu, 06 Jun 2019 15:41:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559860880; cv=none; d=google.com; s=arc-20160816; b=Y/riZKrAOWreX5VEIFzypDNUHc6fopv/Og/EbzovydMzUVbQqkqmTmgGPPbCafTmWx IVMqkeUeW1iWPWnTvLAhEB2ayP8AxvqbMVMUHSscL2va6RDbwYO6brzOPUPopuWBVzPd Lfk4tKVdykVYGVZ2aAIZGp5Ws194oGqgfAiGqza+e1TTkTSkKResoz96EZJSjGCH9VQ0 +cWIGa3huulNWK8Ul9VHt4RWKu6XqNBP+9NIeaXvj7i+JoMidh7hizqN7mtFf7l8u4OI B/njcJgWeE9P+dJce+rZrUaoTyholPidZGLrEpW71xVn5jC3I9fJ6qUXkjz3wyKdxMym Dm1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=8VdDFbqHussZfRli7/Ekq+VSSWAZRQe4ch9vBJOAbCg=; b=XBxXLUO6khPAbS4WoV+71XL0Us673STLD4EHyvuH/jiL48NAOSC1/Ixr/SRJkZGHaN Bp7FoKLcp3DaH51jjgHLYxfsXRT8U5BTvXqcoNmN/ZtYpbsQ0Zhr0OkwlPZ8PUyY+BQr 1mXg8nS5LwaPJRmuYJLBF700UTuR0UXnp2/wi7wqMCZ6QrX1hVQZLZ9HzCgqnSwNUELr L5k3FwQq0+ZcH5ASea2tve4cosRjcVg+SkO8RFgIw5vr9YvaG7qpyX9Sp0bMuSirnpk0 uqrHmTpcr1QDh22i6MtbJpPBV0GZEv6WDghtFFP0w5IkxPT7ParR9ybpdXmnXRCiygTX DgqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TiuKhcgQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d185si169090pfa.182.2019.06.06.15.41.04; Thu, 06 Jun 2019 15:41:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TiuKhcgQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbfFFWCo (ORCPT + 99 others); Thu, 6 Jun 2019 18:02:44 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:55612 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfFFWCo (ORCPT ); Thu, 6 Jun 2019 18:02:44 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x56LsQKi098174; Thu, 6 Jun 2019 22:02:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=8VdDFbqHussZfRli7/Ekq+VSSWAZRQe4ch9vBJOAbCg=; b=TiuKhcgQGIeZ6Q8j04RBHFzib+klmcOpCPiw7y0TVbH6qww1avRuXAl16W4Ds4DxOrko MJz/AtGd79kSsHvl6MyefahqRb5tXi0snhJCdhJKMv2Xh9fVsEs+BWUPDuHFwsRdzT+y u9CYgaG3WheNyiARdFthJq4pijv4ia5oUVWqeUfVcy5Hr3nbBkwx1yFx+kjL8IFD8zyD XUDlP5O6UR3bWJr0g99EnrOCx0tNpqM/Exuxmx0YXk23cH4MLEuDRDwnnDEnBDtdoSi0 BUaNSdL4kyPMzxVeYZlAQbobdPgcXI2tAqdTEEW6xm2p3HDkWeBr5hFU0NywOSrIFvyw eQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2suevdudp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2019 22:02:26 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x56M2L6t166587; Thu, 6 Jun 2019 22:02:25 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2swngmrr15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2019 22:02:25 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x56M2H2A012404; Thu, 6 Jun 2019 22:02:18 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 Jun 2019 15:02:17 -0700 To: John Garry Cc: , , , , , , , , , Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Date: Thu, 06 Jun 2019 18:02:14 -0400 In-Reply-To: <1559751143-168560-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Thu, 6 Jun 2019 00:12:23 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9280 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=625 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906060149 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9280 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=685 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906060148 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John, > Many times in libsas, and in LLDDs which use libsas, the check for an > expander device is re-implemented or open coded. Applied to 5.3/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering