Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751144AbVKTCCE (ORCPT ); Sat, 19 Nov 2005 21:02:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751145AbVKTCCE (ORCPT ); Sat, 19 Nov 2005 21:02:04 -0500 Received: from allen.werkleitz.de ([80.190.251.108]:62592 "EHLO allen.werkleitz.de") by vger.kernel.org with ESMTP id S1751144AbVKTCCC (ORCPT ); Sat, 19 Nov 2005 21:02:02 -0500 Date: Sun, 20 Nov 2005 03:01:15 +0100 From: Johannes Stezenbach To: Denis Vlasenko Cc: "Cipriani, Lawrence V (Larry)" , Andrew Morton , kai.germaschewski@gmx.de, linux-dvb-maintainer@linuxtv.org, "David S. Miller" , linux-kernel@vger.kernel.org Message-ID: <20051120020115.GA8157@linuxtv.org> Mail-Followup-To: Johannes Stezenbach , Denis Vlasenko , "Cipriani, Lawrence V (Larry)" , Andrew Morton , kai.germaschewski@gmx.de, linux-dvb-maintainer@linuxtv.org, "David S. Miller" , linux-kernel@vger.kernel.org References: <0C6AA2145B810F499C69B0947DC5078107BCDE20@oh0012exch001p.cb.lucent.com> <200511171500.06910.vda@ilport.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200511171500.06910.vda@ilport.com.ua> User-Agent: Mutt/1.5.11 X-SA-Exim-Connect-IP: 84.189.225.148 Subject: Re: [linux-dvb-maintainer] [PATCH] Re: bugs in /usr/src/linux/net/ipv6/mcast.c X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on allen.werkleitz.de) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 57 On Thu, Nov 17, 2005 Denis Vlasenko wrote: > However, a few similar bugs do exist in 2.6! > > Patch attached. > > Patch intentionally places a comment instead of statement > in few false positives. > > Please review/apply. Thanks a lot. /me wonders how this could go unnoticed for so long... Can you add your Signed-off-by: ? Johannes > diff -urpN linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c > --- linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c Sat Nov 5 15:17:30 2005 > +++ linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c Thu Nov 17 14:41:05 2005 > @@ -140,25 +140,25 @@ static int ves1820_set_symbolrate(struct > /* yeuch! */ > fpxin = state->config->xin * 10; > fptmp = fpxin; do_div(fptmp, 123); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 1; > fptmp = fpxin; do_div(fptmp, 160); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 0; > fptmp = fpxin; do_div(fptmp, 246); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 1; > fptmp = fpxin; do_div(fptmp, 320); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 0; > fptmp = fpxin; do_div(fptmp, 492); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 1; > fptmp = fpxin; do_div(fptmp, 640); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 0; > fptmp = fpxin; do_div(fptmp, 984); > - if (symbolrate < fptmp); > + if (symbolrate < fptmp) > SFIL = 1; > > fin = state->config->xin >> 4; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/