Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1559916886.6132.52.camel@lca.pw>
Subject: Re: "locking/lockdep: Consolidate lock usage bit initialization" is
 buggy
From:   Qian Cai <cai@lca.pw>
To:     Yuyang Du <duyuyang@gmail.com>
Cc:     "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Fri, 07 Jun 2019 10:14:46 -0400
In-Reply-To: <CAHttsrYCD1xvL6hf6dXZ_6rB2pEra0HDZ+m5n8EMQr3+5AShnQ@mail.gmail.com>
References: <1559855690.6132.50.camel@lca.pw>
         <CAHttsrYCD1xvL6hf6dXZ_6rB2pEra0HDZ+m5n8EMQr3+5AShnQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-06-07 at 11:21 +0800, Yuyang Du wrote:
> Thanks for the report, but
> 
> On Fri, 7 Jun 2019 at 05:14, Qian Cai <cai@lca.pw> wrote:
> > 
> > The linux-next commit "locking/lockdep: Consolidate lock usage bit
> > initialization" [1] will always generate a warning below.
> 
> I never had such warning.
> 
> > Looking through the
> > commit that when mark_irqflags() returns 1 and check = 1, it will do one
> > less
> > mark_lock() call than it used to.
> 
> The four cases:
> 
> 1. When check == 1 and mark_irqflags() returns 1;
> 2. When check == 1 and mark_irqflags() returns 0;
> 3. When check == 0 and mark_irqflags() returns 1;
> 4. When check == 0 and mark_irqflags() returns 0;
> 
> Before and after have exactly the same code to do.

Reverted the commit on the top of linux-next fixed the issue.

With the commit (triggering the warning
DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != nr_unused)),

# cat /proc/lockdep_stats
lock-classes:                         1110 [max: 8192]
stack-trace entries:                     0 [max: 524288]
combined max dependencies:               1
uncategorized locks:                     0
unused locks:                         1110
max locking depth:                      14
debug_locks:                             0

Without the commit (no warning),

# cat /proc/lockdep_stats
lock-classes:                         1110 [max: 8192]
stack-trace entries:                  9932 [max: 524288]
combined max dependencies:               1
uncategorized locks:                  1113
unused locks:                            0
max locking depth:                      14
debug_locks:                             1