Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander()
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
References: <1559751143-168560-1-git-send-email-john.garry@huawei.com>
 <yq1k1dymkyh.fsf@oracle.com> <yq1v9xhjzl9.fsf@oracle.com>
CC:     <jejb@linux.ibm.com>, <intel-linux-scu@intel.com>,
        <artur.paszkiewicz@intel.com>, <jinpu.wang@profitbricks.com>,
        <lindar_liu@usish.com>, <yanaijie@huawei.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <hare@suse.de>
From:   John Garry <john.garry@huawei.com>
Message-ID: <fcc8598c-00c7-52be-3bb3-5296c825658a@huawei.com>
Date:   Fri, 7 Jun 2019 14:29:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <yq1v9xhjzl9.fsf@oracle.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/06/2019 14:26, Martin K. Petersen wrote:
>
> John,
>
>>> Many times in libsas, and in LLDDs which use libsas, the check for an
>>> expander device is re-implemented or open coded.
>>
>> Applied to 5.3/scsi-queue, thanks.
>
> Dropped again. Breaks isci. Please fix.
>

Hi Martin,

I assume that you mean that it breaks the isci build. I thought that I 
did build it. Anyway, I'll check.

Thanks,
john