Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp307731ybi; Fri, 7 Jun 2019 08:22:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqyPqMG3CRy2pR1e2IQr/uzVBJgR8kGeUCYEjLOphoRralR7uPK5qdRBOkU/GulmlLbHka/m X-Received: by 2002:a63:5009:: with SMTP id e9mr3194201pgb.396.1559920950311; Fri, 07 Jun 2019 08:22:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559920950; cv=none; d=google.com; s=arc-20160816; b=h9fv2mFK5KinviSkXNXPzxqYzlfXi3JE/1HOe+iAiNBWqX6KswUxVSi2DxD0tPijai Gcg5jpgc50SM3n6V73NYuXqoQLUA6KVw2M+cWKPD2y+BPVv32ApBs5sOZ+pofWprXQdn pxHr5ukRSkxSDIE1HbWQXUOn/1NxaX92UK9QzRa1XmJU+B+N8C9KG/VcC0b+5IhxlZx6 sqaR7hQPMhPxGSOpBKl1/Z1XfQSjlNtXh5V9A5XXgpg6twD45XtwmTsFTBaShQ+IPCsN 46Ydwa1Nx5bQbOmG1IOU2KxWQblwkdJx6l9guuxsxTd8cZPziLJCbZBnsOrC4jBCZKbo mH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=Kn1ssFbA72f9kM6B6tm8ADY7maOuNtpoUji1D+ceW28=; b=ox//E+baWYq4Z0Fn8VmU2dvfk2BojsE4CuewHpjaD9th16v9n3zzTjimThm/oNx9J+ nz2CmNGU27sMFbCbPOVCfZW0YStnpYnD9PE0PgpRCoeuMKrh5STl4d9ahRSTuf9Rl722 zFaSwphU/eEE95dH/qPserU36xIX3id4C2lTORQElIpgyFAbZ83OEEq5h4G/Vp6my51r pZzuGYYRPQaIm4MI7Y9pvIsj5U9nEXNXk0BfiljXlAqJjfMLpMh4A+AEe21tvgE8KWP9 Vg28JrNZROo9HwsyPdrbqcwFuQH0/dgA1uaVFfywbPLcgwMgXDSEo4iSCGlXvvqeQZEy eCjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=iCfMHinP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si1921265pgu.316.2019.06.07.08.22.13; Fri, 07 Jun 2019 08:22:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=iCfMHinP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbfFGN2F (ORCPT + 99 others); Fri, 7 Jun 2019 09:28:05 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:43118 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727840AbfFGN2F (ORCPT ); Fri, 7 Jun 2019 09:28:05 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x57DOAaO183017; Fri, 7 Jun 2019 13:26:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Kn1ssFbA72f9kM6B6tm8ADY7maOuNtpoUji1D+ceW28=; b=iCfMHinPpIkDuxBSM/9wk75OOAPVVO09cL/g4U6al1PnjZv5R837JlUG93ehH9nU9THd +cFS4Sqg5+1GJQZIoPlx7eCz2m59HUtz+s6cTKCHzVkg9DKWc2FdgzsOrAMuD8XOJVPP zWwsP9ZWNUKAvAOQlCjmImIRCgwEYtX5acIB8k3z9cUqTiw9iwe5JH0yvDdFJBn9r/Lt 3UqtYt7dvdHhuienzMBi/Z8GRtIR8+tjHU+NfvHM2iVx7s0Pnsh25K6UrRHbvISxn45i 4e8MeCxSBLZ8VCvg31ZaE5fq3x4YrtMnZieUANO/YCKHxEHqNhTl8kr8S8ujrubes65y Tg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2suevdxh7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2019 13:26:54 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x57DQ0cN056067; Fri, 7 Jun 2019 13:26:53 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2swngk0y9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2019 13:26:53 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x57DQj2V029712; Fri, 7 Jun 2019 13:26:46 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Jun 2019 06:26:44 -0700 To: John Garry Cc: , , , , , , , , Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Date: Fri, 07 Jun 2019 09:26:42 -0400 In-Reply-To: (Martin K. Petersen's message of "Thu, 06 Jun 2019 18:02:14 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9280 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=607 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906070095 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9280 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=668 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906070095 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John, >> Many times in libsas, and in LLDDs which use libsas, the check for an >> expander device is re-implemented or open coded. > > Applied to 5.3/scsi-queue, thanks. Dropped again. Breaks isci. Please fix. -- Martin K. Petersen Oracle Linux Engineering