Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp331761ybi; Fri, 7 Jun 2019 08:45:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3meEbwDp+WN3gmtIq6S88iB0uts6P+1w4T8hfBIcaoNFY8egt1B7gGck8EszJDJ9NrcPr X-Received: by 2002:a17:90a:17cb:: with SMTP id q69mr6282152pja.8.1559922354887; Fri, 07 Jun 2019 08:45:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559922354; cv=none; d=google.com; s=arc-20160816; b=1JaGEQeo9Y2JWMuvsVnhMyvyntVBiTJBlugSOlX1SOQOdSt/XJIDfx3AcT7RalGLRF T39MvKTU0Ej6GEQNRy6d6oGQMp6xW/GZPgLK8NsG06qK8PTLxdlMAyr+c/M/1gKWkpMz Wgim0D/9e1H9QQAhbyw03nxUUNZVuMgZ+BTTIgvfenyWhMIXVHfb2vrmT7EMML5tVoCg Rd4P5RzSGynJ8LyL0TBtpHEdGOqD+D71yvABW71uj7Kgs7o2MwXc3uJpErbG5SpRPKfD 6O96GB0zMqSiV7mY9Vy9NlxrfQ/iS5IiPxnz5xGTzDcx1zAqeLOwwp8mDv+RPxNUJrrp BVeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w7c0uN89M1txJb4p63sZ5NNeE5b4c28B+NR33o4WlFE=; b=N1YkPWp+ZyKogdLF5NSs4Lp8hiP6Vi2EuJ/651cZW/NBwWQlULH7c38sZn4ZiJbNrT irZEdai9ZfScb0Uex73tZ2+6HqNlJ+TthV7X4ChMB2sNjmeUtgm7zEEhhlGaaUExUE0F GAlBZoTk9LnWu6kCyGHx6N6eEQPZ3tH/AhrAyx75OjXjKp5FNF2Xk2b2X18PlNC89Plw gE9P70FWI62S2ZbyjVYByFnJRZ94kUgnkwZhrFeUoRgtjjN9Dg6jxWVySMwIr/YzgQbh nMeB2SczH5tkP60QmjpIVTje8Zz+J83qVD1DlbFVLePkerYjdL9bo8+UpeBX6DDkCUVq 2ypw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TRoFRKu6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q33si2102662pgm.287.2019.06.07.08.45.37; Fri, 07 Jun 2019 08:45:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TRoFRKu6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730874AbfFGPna (ORCPT + 99 others); Fri, 7 Jun 2019 11:43:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:54606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729770AbfFGPn1 (ORCPT ); Fri, 7 Jun 2019 11:43:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3DC12146E; Fri, 7 Jun 2019 15:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922206; bh=op1gChslQGxNPa936LUqZEqpWuej5GsHZdQxDraDVkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TRoFRKu6TYSDfOQUQCdW4yLfvlFufaKA4B8If+o8u8mrX1VOlGDM+XCyAFv0AEuSt FimCE7BR78l/vJDdIUmFwywaEIOobWC/0hQInQLoHMGoVKuvgrk08T7l69DGwAsQf9 eBXIsfMBaHI6Q5rbn1HXfcy7Yno7huh54nvgbSQI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jorge Ramirez-Ortiz , Bjorn Andersson , Stephen Boyd Subject: [PATCH 4.14 48/69] tty: serial: msm_serial: Fix XON/XOFF Date: Fri, 7 Jun 2019 17:39:29 +0200 Message-Id: <20190607153854.275715769@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.271562617@linuxfoundation.org> References: <20190607153848.271562617@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jorge Ramirez-Ortiz commit 61c0e37950b88bad590056286c1d766b1f167f4e upstream. When the tty layer requests the uart to throttle, the current code executing in msm_serial will trigger "Bad mode in Error Handler" and generate an invalid stack frame in pstore before rebooting (that is if pstore is indeed configured: otherwise the user shall just notice a reboot with no further information dumped to the console). This patch replaces the PIO byte accessor with the word accessor already used in PIO mode. Fixes: 68252424a7c7 ("tty: serial: msm: Support big-endian CPUs") Cc: stable@vger.kernel.org Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/msm_serial.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -868,6 +868,7 @@ static void msm_handle_tx(struct uart_po struct circ_buf *xmit = &msm_port->uart.state->xmit; struct msm_dma *dma = &msm_port->tx_dma; unsigned int pio_count, dma_count, dma_min; + char buf[4] = { 0 }; void __iomem *tf; int err = 0; @@ -877,10 +878,12 @@ static void msm_handle_tx(struct uart_po else tf = port->membase + UART_TF; + buf[0] = port->x_char; + if (msm_port->is_uartdm) msm_reset_dm_count(port, 1); - iowrite8_rep(tf, &port->x_char, 1); + iowrite32_rep(tf, buf, 1); port->icount.tx++; port->x_char = 0; return;