Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp331832ybi; Fri, 7 Jun 2019 08:45:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8oax9BfnyRt5OKKQCiCzxH+Mzzq5nuwhdLDdIiq8XmOYNalGTplQHCTgAhWmtx6kbVRq0 X-Received: by 2002:a17:902:a70a:: with SMTP id w10mr53901459plq.250.1559922358216; Fri, 07 Jun 2019 08:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559922358; cv=none; d=google.com; s=arc-20160816; b=imhXhisJIw3coniVELL1Pr44hXvBpK4OebEJ3V/8Toq9QwXwji+eDh4tiT1irVvHWt K9DLQrmKcoHzNz5PHrWmYNEDNpGMiG2Odfwcg8YvNEj4/raZuKgV0YyijdFzoprbAhvG 9B5O+9fCodYhhu2mTD9Jk3k8/ikt6IkuUZlYuJjriP4egOJUURBRpcVCtSuAwf2m+w/f iPJSX1Ur9+EkTHAMAv23pO/rVmAl1yzyMTDX9FYeWtxKv4AZzqhVvylAG125A4HXibtP Fl/gyr7zFpaT+IXCsxfGt1mv6t8ECodfu555FwdTVX9In21Y86wV+aEVNdO2SnKJHXJ5 aZyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LQNPqpaKk69c9rC3HuBi6Jp7py2g58vemMOCmyrsOLc=; b=NfFKng2WKfaP1Dcu88ilcPYvlbqFq0Xa7q/ukzNa/G17n+RT0Ij4sWoZa46KLM4bxk OVtv2OrRnTYh2Nty/tBXhWX81Oj+rc0CWDlBI1gSpiKG1XA07m8YJayzmWP9gN+lQe09 T9mafiD9w0+4SXo4F+L2sxQygNKuEyVboX1GVLoTqH0I38J2vxODcXwDCDilLyhggYlK ZGkHzQgwX/UfNStFXKwTvEiiqdmYnkHrfM1kOhQ2zPbTx2ZvXdltM+nc1FkpohhKVQTZ haHmr5ZVt7lbepmTrFA0ocTbNYpAB9NLOuX0SSRwniqDvz+7SF9Fv7mBdu9hb49rZDSk OqtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=myacOi7e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2si714619pfr.5.2019.06.07.08.45.40; Fri, 07 Jun 2019 08:45:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=myacOi7e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729919AbfFGPm5 (ORCPT + 99 others); Fri, 7 Jun 2019 11:42:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730676AbfFGPmx (ORCPT ); Fri, 7 Jun 2019 11:42:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1FE9212F5; Fri, 7 Jun 2019 15:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922172; bh=4dRqwOCNbDrUOH84RUkkjW9jPHaTGW3Y2CIITnQ3V0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=myacOi7eH4Bq9UdNuQXoKv3Q9uv+NjCThzSS2Z6XDbKkgD0vURYp6sF6WPvBaRx+V 3GCWVeX3mA4cuLVuWLqd4G1p5dPI79SCNjwFMbo0YpuOhRFQPzBI0Dr8fj1gVN6prD u8Pj7jg1P6bv5q6pFTJvLAt97S38I1djPIouBX5w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Hellstrom , Deepak Rawat Subject: [PATCH 4.14 62/69] drm/vmwgfx: Dont send drm sysfs hotplug events on initial master set Date: Fri, 7 Jun 2019 17:39:43 +0200 Message-Id: <20190607153855.651941146@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.271562617@linuxfoundation.org> References: <20190607153848.271562617@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Hellstrom commit 63cb44441826e842b7285575b96db631cc9f2505 upstream. This may confuse user-space clients like plymouth that opens a drm file descriptor as a result of a hotplug event and then generates a new event... Cc: Fixes: 5ea1734827bb ("drm/vmwgfx: Send a hotplug event at master_set") Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -1245,7 +1245,13 @@ static int vmw_master_set(struct drm_dev } dev_priv->active_master = vmaster; - drm_sysfs_hotplug_event(dev); + + /* + * Inform a new master that the layout may have changed while + * it was gone. + */ + if (!from_open) + drm_sysfs_hotplug_event(dev); return 0; }