Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp331929ybi; Fri, 7 Jun 2019 08:46:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvxNCgZCIT7IfASyYz7xo8jFKMGCc/8LlUiPnWF+mAA4Sovina4FK9JXGGduHSXLXEVrpV X-Received: by 2002:a63:471d:: with SMTP id u29mr3329478pga.39.1559922363823; Fri, 07 Jun 2019 08:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559922363; cv=none; d=google.com; s=arc-20160816; b=EOleq4P4HJ1t9hle7sB1HaTh3y2u6qhOjBsB2RrdBckV0BKvpxJqM+IZe8brlUYM8m 7J0rwQSTyPEZmBWQdWYmlymCpeE1O1yWo4+QqhjQRvtJLvGfwateIw0bporTMDGtW1en K9A9LHp54xYZghVrL/ULIVxDnBh17SuuZt5ya2vrcpIFMncmMhYAyCw0USjxrMUYCGXH DeHm9z1Zsz6hq9NdAciJQiIqWC05sp/SGl/AttoenflZqkD9sTVAbmu8AGS5rZ1cGljw 8mICEU/j7QtJJrFbVPUp9KwM2sWW1AvbXnNIjJlrvzmH/Gv6GbgpdbhY2pNSKeNpRw/T LMkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ch3V6ZNlb2mEnbm+cZQhX3Nqz5fRJ+ZVFesf8mSvPF8=; b=kSonN4TU9EjvZVjgxnFxF7Q+Jf4uNtAAB2BW9lK6DFSf6v2Rh0oxqjOlBZxEGqd0yj +mMsU0Z9rTTnrhBeBkvsqARF/F+sWQUM8SUust2zSrWMAviYEu8h6XXn5alsG2nk7lM7 qiYRkVLxZgw4HkuIuwj8lYZeT7CZ/ahUwwSL/zTqvDvrZNddrSbBA+c7Dz2tSO1zybcT gGk89veten8+qm2fEJiZsLR/tY+RBnybH5d6PSH6YaKqgnvgp6iVeTEA4BniJBbaVhB+ Sa0K/qHH4TtUCRjL9xaQ2WuGHqXlUOMe8JFl150YWkA/AHnEykdtFm5IJCV7mT9TGxEC CLJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TIh385MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p91si2227541plb.61.2019.06.07.08.45.47; Fri, 07 Jun 2019 08:46:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TIh385MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730601AbfFGPmc (ORCPT + 99 others); Fri, 7 Jun 2019 11:42:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:53180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730589AbfFGPma (ORCPT ); Fri, 7 Jun 2019 11:42:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A82482147A; Fri, 7 Jun 2019 15:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922150; bh=cYTjEnrGVJZwA7HlPblYMwwrw9L/XU5fNTXJgOmLX+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TIh385MMhXyxBSJAZ+egsryg1nyeXlNWIZZ9AvB3eF4bZT5l6z1njSNFJkkmBKCpp WC5nPLr8lKZbV3VFtcc579UJRjKVxAdsOeUdgPUIu8scVNRfJXcZN9syO4keYFXse3 677Fd/B8HRlf1iD3O9i+VhgmSq6Xbcv6RunVWhy8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roberto Sassu , Mimi Zohar Subject: [PATCH 4.14 55/69] ima: show rules with IMA_INMASK correctly Date: Fri, 7 Jun 2019 17:39:36 +0200 Message-Id: <20190607153854.952094064@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.271562617@linuxfoundation.org> References: <20190607153848.271562617@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roberto Sassu commit 8cdc23a3d9ec0944000ad43bad588e36afdc38cd upstream. Show the '^' character when a policy rule has flag IMA_INMASK. Fixes: 80eae209d63ac ("IMA: allow reading back the current IMA policy") Signed-off-by: Roberto Sassu Cc: stable@vger.kernel.org Signed-off-by: Mimi Zohar Signed-off-by: Greg Kroah-Hartman --- security/integrity/ima/ima_policy.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) --- a/security/integrity/ima/ima_policy.c +++ b/security/integrity/ima/ima_policy.c @@ -964,10 +964,10 @@ enum { }; static const char *const mask_tokens[] = { - "MAY_EXEC", - "MAY_WRITE", - "MAY_READ", - "MAY_APPEND" + "^MAY_EXEC", + "^MAY_WRITE", + "^MAY_READ", + "^MAY_APPEND" }; #define __ima_hook_stringify(str) (#str), @@ -1027,6 +1027,7 @@ int ima_policy_show(struct seq_file *m, struct ima_rule_entry *entry = v; int i; char tbuf[64] = {0,}; + int offset = 0; rcu_read_lock(); @@ -1046,15 +1047,17 @@ int ima_policy_show(struct seq_file *m, if (entry->flags & IMA_FUNC) policy_func_show(m, entry->func); - if (entry->flags & IMA_MASK) { + if ((entry->flags & IMA_MASK) || (entry->flags & IMA_INMASK)) { + if (entry->flags & IMA_MASK) + offset = 1; if (entry->mask & MAY_EXEC) - seq_printf(m, pt(Opt_mask), mt(mask_exec)); + seq_printf(m, pt(Opt_mask), mt(mask_exec) + offset); if (entry->mask & MAY_WRITE) - seq_printf(m, pt(Opt_mask), mt(mask_write)); + seq_printf(m, pt(Opt_mask), mt(mask_write) + offset); if (entry->mask & MAY_READ) - seq_printf(m, pt(Opt_mask), mt(mask_read)); + seq_printf(m, pt(Opt_mask), mt(mask_read) + offset); if (entry->mask & MAY_APPEND) - seq_printf(m, pt(Opt_mask), mt(mask_append)); + seq_printf(m, pt(Opt_mask), mt(mask_append) + offset); seq_puts(m, " "); }