Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1559925309.21054.9.camel@codethink.co.uk>
Subject: Re: [PATCH 4.14 00/69] 4.14.124-stable review
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Guenter Roeck <linux@roeck-us.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, stable@vger.kernel.org
Date:   Fri, 07 Jun 2019 17:35:09 +0100
In-Reply-To: <20190607162722.GA21998@roeck-us.net>
References: <20190607153848.271562617@linuxfoundation.org>
         <20190607161102.GA19615@roeck-us.net> <20190607161627.GA9920@kroah.com>
         <20190607162722.GA21998@roeck-us.net>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-06-07 at 09:27 -0700, Guenter Roeck wrote:
> On Fri, Jun 07, 2019 at 06:16:27PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Jun 07, 2019 at 09:11:02AM -0700, Guenter Roeck wrote:
> > > On Fri, Jun 07, 2019 at 05:38:41PM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 4.14.124 release.
> > > > There are 69 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun 09 Jun 2019 03:37:08 PM UTC.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > fs/btrfs/inode.c: In function 'btrfs_add_link':
> > > fs/btrfs/inode.c:6590:27: error: invalid initializer
> > >    struct timespec64 now = current_time(&parent_inode->vfs_inode);
> > >                            ^~~~~~~~~~~~

For 4.14 the type of "now" should be struct timespec.

> > > fs/btrfs/inode.c:6592:35: error: incompatible types when assigning to type 'struct timespec' from type 'struct timespec64'
> > >    parent_inode->vfs_inode.i_mtime = now;
> > >                                    ^
> > > fs/btrfs/inode.c:6593:35: error: incompatible types when assigning to type 'struct timespec' from type 'struct timespec64'
> > >    parent_inode->vfs_inode.i_ctime = now;
> > >                                    ^
> > 
> > What arch?  This builds for me here.  odd...
> > 
> 
> arm, i386, m68k, mips, parisc, xtensa, ppc, sh4
> 
> It was originally seen with v4.14.123-69-gcc46c1204f89 last night,
> but I confirmed that v4.14.123-70-g94c5316fb246 is still affected.

All 32-bit architectures are affected; on 64-bit architectures
timespec64 is a macro expanding to timespec.

Ben. 

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom