Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp451511ybi; Fri, 7 Jun 2019 10:42:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxT2hgPTyhgoTRn+EaydAXU2kXnPiJobLXrVdjBfP4o4oueQPEg7qq7XsuVhK+B/6LDkTqR X-Received: by 2002:a63:1622:: with SMTP id w34mr4072167pgl.45.1559929376748; Fri, 07 Jun 2019 10:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559929376; cv=none; d=google.com; s=arc-20160816; b=prsKOao4NSmsg/8l62WWQwECbwY6J58gE9hDQG+0xlblWt4nRjjPYmr2P7g8S/x/Ye CjxMufY8sE10T/HlNEfPZhsQ9KwOBK97tCd65YSaMhPGXh0lYhPNt/9oJIwPfGsCjNS3 Sc4WM9iLbXa1OFjQsrFhwnxO+ZloR7hri98vk31VHOegUn5z17Tw1B91XotJA1ADdUWw DpnDom2cDL2IYzljATkDkfwwdn+O5nhsNqkjxJjOS8NVUkp6z4kvTKiwZqdh/gXJURCq pdqyDr0w5AQqX4ZpZyGKw+KMcykxW/pQexPYKJt9Ok0OnOUBG48iT52R8hcOL/RVj2ND 6BIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=95UnSnbFEXVL4zwHJxJGiY/MIW8Oyn8nQASCvA5GYWM=; b=nCeczvcbkxJa/6i/5CCXy8heemPe0vNUh3ipVOcCwuDGTx2DB9h+tfoa72ytnOsUWW c2rvan8EN9bKgTgQry3qzOAE0Ztm/d1T5rCI7I/2sz6vMb6ocTvHPu5TSY9XABUYZk61 X4wtn9v69O6smb3fMQZ1V7DLYKlB3R2ZGPs9VA54yKHekmHYjMXFOlMVIRgPrigOHmYh HZCvbemo8yRLApAQ6qCHyNT6cogvBjIoAEz9H+Z8PAjIxN46zzsftcZHiD6v3saCRvvD 23rRpiC4LtZczPCNs0LpxMqB3SLwTecgg3XBLl00t+EwbT3JLdgUx5FaUyqcFYz0tb+g Yu0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IFj44j64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d21si2542721pgl.591.2019.06.07.10.42.40; Fri, 07 Jun 2019 10:42:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IFj44j64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730841AbfFGPnV (ORCPT + 99 others); Fri, 7 Jun 2019 11:43:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:54414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730828AbfFGPnS (ORCPT ); Fri, 7 Jun 2019 11:43:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C5502133D; Fri, 7 Jun 2019 15:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922198; bh=/OXER1Ejj6On/IPyGWXD/d4+RU7b36OA0PhjKQsOZ3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IFj44j642rKHBCy1aqWbvJG7FcIglOMJ01B1ANSVXTBlPxfIxf/wREZBkFc3zZ2uc gxhLmKbgEp/QfK1hk7DjlzwtWV1uasjRXQU08R/4FrWpg1j0eQm2dz7cSmVbTOkT74 eBoDM4XFbq3PGl0G2H53d/UWkZUvA19jf/dYTwAo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kailang Yang , Takashi Iwai Subject: [PATCH 4.14 45/69] ALSA: hda/realtek - Set default power save node to 0 Date: Fri, 7 Jun 2019 17:39:26 +0200 Message-Id: <20190607153853.952274138@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.271562617@linuxfoundation.org> References: <20190607153848.271562617@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kailang Yang commit 317d9313925cd8388304286c0d3c8dda7f060a2d upstream. I measured power consumption between power_save_node=1 and power_save_node=0. It's almost the same. Codec will enter to runtime suspend and suspend. That pin also will enter to D3. Don't need to enter to D3 by single pin. So, Disable power_save_node as default. It will avoid more issues. Windows Driver also has not this option at runtime PM. Signed-off-by: Kailang Yang Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7078,7 +7078,7 @@ static int patch_alc269(struct hda_codec spec = codec->spec; spec->gen.shared_mic_vref_pin = 0x18; - codec->power_save_node = 1; + codec->power_save_node = 0; #ifdef CONFIG_PM codec->patch_ops.suspend = alc269_suspend;