Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp529480ybi; Fri, 7 Jun 2019 12:06:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNV+4XlsoPDkWWAzVdGUbYj9jdr5mpgkxoXd9gm/+2JGSFNcLwzqvsYon+wFqsIXS/4dT8 X-Received: by 2002:a17:90a:8985:: with SMTP id v5mr7370036pjn.136.1559934364036; Fri, 07 Jun 2019 12:06:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559934364; cv=none; d=google.com; s=arc-20160816; b=LLDWyaBDQTBuyUFvgdz2uV2+/s1mgfgKtbv/YqEaMamMTrglzr22R8nqykDvcw9Wdr XwCvPo9HISZM2hw6T/JFY5VpvcjLlHueLXU5pxgDWMrX6LDJBMdcZM6gtaNNhHKbIvUL +fT3XUSdoR3j69aVq2zKHB1WqfI1htpSM+Op+di8GWsJK18RdzC6t/EVT5MKkCGsat/R FsKyJRyvdv4lqpYumGhxM6LjmZqrKU7kaHNFMlzdCGLyx35TzgJowbaiQmUdp4OXtBQD da0PxsmHbceDE1uSlj71Ha1gAf9YKHyAF+rpYzANH6vF1kuG/2jc7+/U/5BSY9nQixwI 5L7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :subject:user-agent:references:in-reply-to:message-id:date:cc:to :from:dkim-signature; bh=pLHqHIiNEMpqBsq1VQWJdA+f/ogiGuALrvYvfOsre5w=; b=FInGwpn1pqX5XgJFUTV8PyKuTpUG3mQmU5skL6cXpa44ORYcKqnLr6CkSYUYbqhDKL sR/W4V+rXQqcs5bOM+EwlbdF4Jv6Ie2o9grtmxy1Z3jxZItRpSg6RwWEtrIyjZid++Y0 Ru4qJYzdB6Mwq/Q7AfZaEWLBjngf6+XIBJ3cG7MHRwZftFl4n8/DYlCDPrGqycZc1mjo tLeuJdPSn0VJA96E1lwcsZ39K4q6pU6cZiIiZ3yAOEiaHNHjMYa6CvpDNd1nvBuhIb8U 8XYbtIkvsa4MCDxza/5L/VTAqnaQB6WLOV3SM/PLjscVjKbFhH+Mf8mhkaFhKNlROtEJ tngw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JKBmHUup; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h190si2791552pgc.248.2019.06.07.12.05.47; Fri, 07 Jun 2019 12:06:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JKBmHUup; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732352AbfFGS4v (ORCPT + 99 others); Fri, 7 Jun 2019 14:56:51 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34741 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729947AbfFGS4t (ORCPT ); Fri, 7 Jun 2019 14:56:49 -0400 Received: by mail-ed1-f66.google.com with SMTP id c26so4429778edt.1 for ; Fri, 07 Jun 2019 11:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=pLHqHIiNEMpqBsq1VQWJdA+f/ogiGuALrvYvfOsre5w=; b=JKBmHUupUT1En6Wm/PaAfDvWLs9G4reHIL/Dq7a28RXjQhW1bvj1OuB26Otd3Nzv/F 5ZMid02V6ON7krE7muBA6YEhkfXI5N+61Qho5iv95IBFh/MlqvIhkuqMpLLIh4Gx1vis dD6p2HlT0owEbyLmy2rgkQ9McTJKn+DOb7v3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=pLHqHIiNEMpqBsq1VQWJdA+f/ogiGuALrvYvfOsre5w=; b=FqcCShX+xF9qxAwnroakJ//oYYC3pJ5+nAHFXkW6fUvrOzH6Y0W0JQGdukzZJf0HV7 CLHE026S+7o5babuehKvaD96zDzBi0AaAuBDU3pw+U9tsZUENXQmiqPgMjNC9CZk/AfO x+sPr4uW7yH9TtoXm5/nwnIWXg+0g5aQV2fBNnxjB8PuKPY1Tu2ZirNxPq0cajB6/0Tr rRhu4GohQShz5LzqL8zfw06r/IsjER/o6CVXzfvuTIlEQ43+V/TMs+2TS8lfM6JFzIMx UiOUuzzBg0l0gPCfdIfTrikDtcBtbe6zrkx70C/aBN9VaIfMvqpLoIC+TJzdmEADwx1b auhw== X-Gm-Message-State: APjAAAV6ntjJzNpMxzWeNEb1RGWWomy1XsQXzCgitcPa6/m2SvMye2QO f+xkdztXIkNbxuTPcS6ZPGfXJw== X-Received: by 2002:a17:906:4ada:: with SMTP id u26mr28479238ejt.258.1559933807813; Fri, 07 Jun 2019 11:56:47 -0700 (PDT) Received: from [192.168.178.17] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id f9sm501183ejt.18.2019.06.07.11.56.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Jun 2019 11:56:47 -0700 (PDT) From: Arend Van Spriel To: Doug Anderson CC: Adrian Hunter , Ulf Hansson , Kalle Valo , , "open list:ARM/Rockchip SoC..." , Double Lo , Brian Norris , "linux-wireless" , Naveen Gupta , Madhan Mohan R , Matthias Kaehlcke , Wright Feng , "Chi-Hsien Lin" , netdev , "brcm80211-dev-list" , "David S. Miller" , Franky Lin , LKML , Hante Meuleman , YueHaibing , Michael Trimarchi Date: Fri, 07 Jun 2019 20:56:43 +0200 Message-ID: <16b334cd9f8.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20190603183740.239031-1-dianders@chromium.org> <20190603183740.239031-4-dianders@chromium.org> <42fc30b1-adab-7fa8-104c-cbb7855f2032@intel.com> <16b305a7110.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <16b3223dea0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> User-Agent: AquaMail/1.20.0-1451 (build: 102000001) Subject: Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On June 7, 2019 8:06:30 PM Doug Anderson wrote: > Hi, > > On Fri, Jun 7, 2019 at 6:32 AM Arend Van Spriel > wrote: >> >> Right. I know it supports initial tuning, but I'm not sure about subsequent >> retuning initiated by the host controller. > > My evidence says that it supports subsequent tuning. In fact, without > this series my logs would be filled with: > > dwmmc_rockchip ff0d0000.dwmmc: Successfully tuned phase to XYZ > > ...where the phase varied by a few degrees each time. AKA: it was > retuning over and over again and getting sane results which implies > that the tuning was working just fine. Ok. Thanks for confirming this. Regards, Arend