Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Kevin Hilman <khilman@baylibre.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     Christian Hewitt <christianshewitt@gmail.com>,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
In-Reply-To: <c8144470-361b-ca26-71c7-d152f976ae19@baylibre.com>
References: <20190527132200.17377-1-narmstrong@baylibre.com> <20190527132200.17377-2-narmstrong@baylibre.com> <7hy32ecwlu.fsf@baylibre.com> <c8144470-361b-ca26-71c7-d152f976ae19@baylibre.com>
Date:   Fri, 07 Jun 2019 09:59:53 -0700
Message-ID: <7hblz9covq.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 06/06/2019 22:00, Kevin Hilman wrote:
>> Neil Armstrong <narmstrong@baylibre.com> writes:
>> 
>>> From: Christian Hewitt <christianshewitt@gmail.com>
>>>
>>> Fix DTC warnings:
>>>
>>> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
>>>    /gpio-keys-polled: unnecessary #address-cells/#size-cells
>>> 	without "ranges" or child "reg" property
>>>
>>> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
>>> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This patch is missing a S-o-B from the author (Christian?)
>> 
>> The From, Suggested-by and Signed-off-by send mixed messages.  Please
>> clarify if if this is missing a signoff from Christian or if the author
>> is Neil.
>> 
>> Thanks,
>> 
>> Kevin
>> 
>
> The author is Christian Hewitt <christianshewitt@gmail.com>
>
> so s/Suggested-by/Signed-off-by/
>
> Do you need a resend ?

No need, I'll fix up locally.

Thanks for clarifying,

Kevin