Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Jun 2019 22:49:52 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Emil Lenngren <emil.lenngren@gmail.com>
Cc:     linux-mtd <linux-mtd@lists.infradead.org>,
        Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Michele Dionisio <michele.dionisio@gmail.com>
Message-ID: <1342653998.84700.1559940592644.JavaMail.zimbra@nod.at>
In-Reply-To: <CAO1O6scuNXfgtaex_Ty4-5=DmBV43Sg28ntkzNgB5T2KwfXG3g@mail.gmail.com>
References: <20190515210202.21169-1-richard@nod.at> <CAO1O6sdU=kAYS2sTKwiagxrbg+fMer9nvbwA9C4LoFMgH7e1dQ@mail.gmail.com> <1644731533.84685.1559938164477.JavaMail.zimbra@nod.at> <CAO1O6scuNXfgtaex_Ty4-5=DmBV43Sg28ntkzNgB5T2KwfXG3g@mail.gmail.com>
Subject: Re: [PATCH] ubifs: Add support for zstd compression.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: ubifs: Add support for zstd compression.
Thread-Index: i0naAnpf5ado1iIuaToqoo7bNUnLng==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Emil Lenngren" <emil.lenngren@gmail.com>
> An: "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "Sebastian Andrzej Siewior" <sebastian@breakpoint.cc>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Michele Dionisio" <michele.dionisio@gmail.com>
> Gesendet: Freitag, 7. Juni 2019 22:27:09
> Betreff: Re: [PATCH] ubifs: Add support for zstd compression.
>> So I'm not sure what is the best choice for the default filesystem.
> 
> My idea was at the end, i.e. it will only be used when LZO and ZLIB
> are not selected to be included for UBIFS, for example when someone
> compiles a minimal kernel who knows exactly which compression
> algorithms will be used on that system.

BTW: you can always select the compressor using the compr= mount option.
Also for the default filesystem.

Putting it at the end does not harm but IMHO the use is little.
But for the sake of completes, I agree with you. Can you send a follow-up
patch? 

> I did a single test today and compared lzo and zstd and on that test
> lzo had faster decompression speed but resulted in larger space. I'll
> do more tests later.

Can you please share more details? I'm interested what CPU this was.

Thanks,
//richard