Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp650910ybi; Fri, 7 Jun 2019 14:28:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7OfpVwfxtGQBb5vNzG6+2O+cD0si8zJFjv+b9X4DQVMhE49VJU8PIJlFzsFaGv9ouO5NA X-Received: by 2002:a62:ed0a:: with SMTP id u10mr29071571pfh.243.1559942888109; Fri, 07 Jun 2019 14:28:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559942888; cv=none; d=google.com; s=arc-20160816; b=chPit5Bh4cLh9Y7FxlzEyJYhewZyXIN+lURYdH/pr7Mt0xv8aO7ZZiwRur4z1s7O12 GDXsn05dT7A431wD0jmT0K74yMda3M0CFiX2KTvF3LbrhCEmJOQ/iarb2jo7zOpV09zW o+Fj75UuNUMsdpfqyhNTTPKqRCa2orY3z5LIQo5sb0QIJiHZyKivWGeXEXKM0RaJig2R eO+/26gu3CXRABsjWNDCeIUb4j2iMXFphaMk8gVWwEd9J50VTwrGTa+m6rdqhBoGm4kf fCdqJcedo6m/YtBstyg6zC+HCUSTwnOxveT7woXNdmoP5N7UvuJSaef/2Vntet9lUQb6 kKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=ottEE2XiiiPbfH/Skr0UtzLGEI1kOObrtR9qGE7imE4=; b=TK62vkfV4nAo9XIUbL470B8BrXRl534ZYPyiseAXPFq/bF9VfH4n/zDeHF+169Tsn8 GCRmj5M48CWab8ZAoRJr5EvZQEzjVCH6DVQYCNpe6w/DhgofUG8VDpeEbFJB5Xb+ULmH 0gV/02CXzNVseU4+VR4atFA2HwKrPCnN/w4Jl8nAN2U8a8CbMD8PQppxT9TP6IEQN3XI lYOUNd9LKadi1LrIOxKVXQBTYRhX71jJeWVoN9tUA0BAugSOPWuak1OjlLPOoMdPkmwM bA6FVsE1uqIdHDs5qVwkIdsHiLRdzzV6eNi8ebrRiJWf8P4dpnWgFU6i2UoAxIy0RMy0 2Jjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OabBgWGn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si3045831pgk.224.2019.06.07.14.27.51; Fri, 07 Jun 2019 14:28:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OabBgWGn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730389AbfFGTae (ORCPT + 99 others); Fri, 7 Jun 2019 15:30:34 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15379 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729627AbfFGTae (ORCPT ); Fri, 7 Jun 2019 15:30:34 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 07 Jun 2019 12:30:18 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 07 Jun 2019 12:30:33 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 07 Jun 2019 12:30:33 -0700 Received: from HQMAIL102.nvidia.com (172.18.146.10) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 7 Jun 2019 19:30:33 +0000 Received: from HQMAIL106.nvidia.com (172.18.146.12) by HQMAIL102.nvidia.com (172.18.146.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 7 Jun 2019 19:30:32 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL106.nvidia.com (172.18.146.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 7 Jun 2019 19:30:32 +0000 Received: from dhcp-10-19-65-14.client.nvidia.com (Not Verified[10.19.65.14]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Fri, 07 Jun 2019 12:30:32 -0700 From: Bitan Biswas To: Laxman Dewangan , Thierry Reding , Jonathan Hunter , , , , Peter Rosin , Wolfram Sang , Dmitry Osipenko CC: Shardar Mohammed , Sowjanya Komatineni , Mantravadi Karthik , "Bitan Biswas" Subject: [PATCH V2 1/6] i2c: tegra: clean up macros Date: Fri, 7 Jun 2019 12:30:21 -0700 Message-ID: <1559935826-25812-1-git-send-email-bbiswas@nvidia.com> X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1559935818; bh=ottEE2XiiiPbfH/Skr0UtzLGEI1kOObrtR9qGE7imE4=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=OabBgWGnZNCBPjTG+p4AzCCkz3wOlaqZ3vrh0kTldI+jOYyDh2doVL4VTEobGrk1k ccFRni94nwfJuOrs0NQ0xmw3qeBqDfPeblTrohibKwrTyf/xQfvVyMRtLs72MI3iPU US0qq5qJsAHuju6bS3H+9XA/mXbOoHsuD65lZKqmExz7apKgLmnSnpwFMTReX7/amb FNFq72LmR882HlD+BGWbc00bDE7QPCYJx1OXTB2rZxL/ZcT4/aNCHLpYIbobOjbtND 3KptBH1xJL76tDdcdrz2GTQrq0B3BYQzD/rbJ3hszVQYxj2lcx8AkVBwr/cxpaW9aV /UHu+3mXnSp7Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clean up macros by: 1) removing unused macros 2) replace constants by macro BIT() Signed-off-by: Bitan Biswas Reviewed-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 1dbba39..00692d8 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -54,20 +54,15 @@ #define I2C_INT_STATUS 0x068 #define I2C_INT_BUS_CLR_DONE BIT(11) #define I2C_INT_PACKET_XFER_COMPLETE BIT(7) -#define I2C_INT_ALL_PACKETS_XFER_COMPLETE BIT(6) -#define I2C_INT_TX_FIFO_OVERFLOW BIT(5) -#define I2C_INT_RX_FIFO_UNDERFLOW BIT(4) #define I2C_INT_NO_ACK BIT(3) #define I2C_INT_ARBITRATION_LOST BIT(2) #define I2C_INT_TX_FIFO_DATA_REQ BIT(1) #define I2C_INT_RX_FIFO_DATA_REQ BIT(0) #define I2C_CLK_DIVISOR 0x06c #define I2C_CLK_DIVISOR_STD_FAST_MODE_SHIFT 16 -#define I2C_CLK_MULTIPLIER_STD_FAST_MODE 8 #define DVC_CTRL_REG1 0x000 #define DVC_CTRL_REG1_INTR_EN BIT(10) -#define DVC_CTRL_REG2 0x004 #define DVC_CTRL_REG3 0x008 #define DVC_CTRL_REG3_SW_PROG BIT(26) #define DVC_CTRL_REG3_I2C_DONE_INTR_EN BIT(30) @@ -75,24 +70,21 @@ #define DVC_STATUS_I2C_DONE_INTR BIT(30) #define I2C_ERR_NONE 0x00 -#define I2C_ERR_NO_ACK 0x01 -#define I2C_ERR_ARBITRATION_LOST 0x02 -#define I2C_ERR_UNKNOWN_INTERRUPT 0x04 +#define I2C_ERR_NO_ACK BIT(0) +#define I2C_ERR_ARBITRATION_LOST BIT(1) +#define I2C_ERR_UNKNOWN_INTERRUPT BIT(2) #define PACKET_HEADER0_HEADER_SIZE_SHIFT 28 #define PACKET_HEADER0_PACKET_ID_SHIFT 16 #define PACKET_HEADER0_CONT_ID_SHIFT 12 #define PACKET_HEADER0_PROTOCOL_I2C BIT(4) -#define I2C_HEADER_HIGHSPEED_MODE BIT(22) #define I2C_HEADER_CONT_ON_NAK BIT(21) -#define I2C_HEADER_SEND_START_BYTE BIT(20) #define I2C_HEADER_READ BIT(19) #define I2C_HEADER_10BIT_ADDR BIT(18) #define I2C_HEADER_IE_ENABLE BIT(17) #define I2C_HEADER_REPEAT_START BIT(16) #define I2C_HEADER_CONTINUE_XFER BIT(15) -#define I2C_HEADER_MASTER_ADDR_SHIFT 12 #define I2C_HEADER_SLAVE_ADDR_SHIFT 1 #define I2C_BUS_CLEAR_CNFG 0x084 @@ -106,8 +98,6 @@ #define I2C_CONFIG_LOAD 0x08C #define I2C_MSTR_CONFIG_LOAD BIT(0) -#define I2C_SLV_CONFIG_LOAD BIT(1) -#define I2C_TIMEOUT_CONFIG_LOAD BIT(2) #define I2C_CLKEN_OVERRIDE 0x090 #define I2C_MST_CORE_CLKEN_OVR BIT(0) @@ -133,7 +123,6 @@ #define I2C_STANDARD_MODE 100000 #define I2C_FAST_MODE 400000 #define I2C_FAST_PLUS_MODE 1000000 -#define I2C_HS_MODE 3500000 /* Packet header size in bytes */ #define I2C_PACKET_HEADER_SIZE 12 -- 2.7.4