Subject: Re: I made a patch and would like feedback/testers
	(drivers/cdrom/aztcd.c)
From: Arjan van de Ven <arjan@infradead.org>
To: Daniel =?ISO-8859-1?Q?Marjam=E4ki?= <daniel.marjamaki@comhem.se>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <43809652.8000904@comhem.se>
References: <43809652.8000904@comhem.se>
Content-Type: text/plain
Date: Sun, 20 Nov 2005 16:38:00 +0100
Message-Id: <1132501080.2857.3.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 878
Lines: 28

>   static void op_ok(void)
>   {
> -	aztTimeOutCount = 0;
> +	aztTimeOut = jiffies + 2;
>   	do {
>   		aztIndatum = inb(DATA_PORT);
> -		aztTimeOutCount++;
> -		if (aztTimeOutCount >= AZT_TIMEOUT) {
> +		if (time_after(jiffies, aztTimeOut)) {
>   			printk("aztcd: Error Wait OP_OK\n");
>   			break;
>   		}
> +		schedule_timeout_interruptible(1);

this I think is not quite right; schedule_timeout_*() doesn't do
anything unless you set current->state to something. And at that point
you might as well start using msleep()!


but what you're doing is generally a good idea; busy waits as the
original code did is quite wrong...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/