Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp929787ybi; Fri, 7 Jun 2019 22:00:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQ0kMtpncOiwf9/2PdthoHeib3n9yH/81IEd3ZAcE9zvMv3OL5J5jESjXRvKG8YOY8+pY+ X-Received: by 2002:a63:1106:: with SMTP id g6mr5659894pgl.83.1559970022816; Fri, 07 Jun 2019 22:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559970022; cv=none; d=google.com; s=arc-20160816; b=PN7r0MVNt/QHkZOCouVoQE+Br84cSC2FKLePiungYJZKoKkI8x1xbpmiw7MWM8SPMo DvGRdkWcS4CK4WtSm85mpDEsVKqaE5b0h8yFiQBYopOcfaV8l3KrOimOxqDbX+ajFB5C oOpAXsiQq44IFU5xHDzqWlSe+I2zsdgJr1tvRK13L86xQ+jnGg08yw5ZFwmOu0//H0rt ynL3Kyo2l/sSmb8RN6NqGp/ZqPwKRFRYcJOX+uQvTfk5VubhQp8OaUP+mfHOxTrhi0H0 2lOUK8bFFzstCKOU+UXkrEJM+X+ShPiBm0ecdQQa6rMj8EeeOaNHSJKlL3gLxuof161Q eOWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=gwZHN6g8rrJZZNXc5XgsWcgNpvLcubn0e/88oGuv6nA=; b=utQZUrGfsaKzGsO3ke8Mu81oMlOaQ9Flx41zeYPhwDUV+qv2efhKeAVUCKNGr5O5Ve rMmT9Swxu55sxeMuUPpuweyYuBdSNrWe4EipJqcBOZkugSKnWV6RHJDksoXDxq65CANW rVoYJbTgDHw+JoxmQKt5cfRC87MMP/1+Il8VkaizG40eUmooQ93ceA8HotfD3Wmt/qo/ nQv4XEAOjuv6ub3GjqDOL1mCAogrpeXQnv3ZwBz1dUZa9w6quuGdfC0oVwhP3bbca1WN emJu2FFb3ytwM5tr3pE6BZEBmL0CXMUB/e/nWysGtHIHyB7k2w+gw4J8fnr2VEYP/sA7 7cow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Q0wF09O3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si3772346pgm.175.2019.06.07.21.59.52; Fri, 07 Jun 2019 22:00:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Q0wF09O3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726011AbfFHEuG (ORCPT + 99 others); Sat, 8 Jun 2019 00:50:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53320 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbfFHEuF (ORCPT ); Sat, 8 Jun 2019 00:50:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gwZHN6g8rrJZZNXc5XgsWcgNpvLcubn0e/88oGuv6nA=; b=Q0wF09O3nya3WaZACBVPt/lVP UxWlscZ4Ii2/bdHaA47KI7ySk2JnjiSpsFyrdjtW57qnC7JiYFXDt/0TN4bx04QSZphix1/xhgZPD Bnmqo+95y/pkeohfeD/h/QD8SXP9mODnBy8wMSvUAQ7AMCP6TvMfNNyjbPLNqMgCrKBrjWjFZGCQE Geql4V7BmpM566hjQcUr2essMDn1Q6thYrsEwhkKtFRCTHOmVogJvb7orUP0+vTiiaTOdy8jXIvV4 aKXPA03ijb9l4XW8LiogXE6vnA8Uo9mcuIWKML52Z6h0Qz/dm5RJBqe5QTx00IidFPn+ZVDyJUq6L tuSAozzXg==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hZTIq-0003jj-6K; Sat, 08 Jun 2019 04:50:04 +0000 Subject: Re: [PATCHv16 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite To: "Hean-Loong, Ong" , Rob Herring , Dinh Nguyen , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, chin.liang.see@intel.com, Ong@vger.kernel.org References: <20190607143022.427-1-hean.loong.ong@intel.com> <20190607143022.427-4-hean.loong.ong@intel.com> From: Randy Dunlap Message-ID: Date: Fri, 7 Jun 2019 21:50:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190607143022.427-4-hean.loong.ong@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/19 7:30 AM, Hean-Loong, Ong wrote: > diff --git a/drivers/gpu/drm/ivip/Kconfig b/drivers/gpu/drm/ivip/Kconfig > new file mode 100644 > index 000000000000..1b2af85fe757 > --- /dev/null > +++ b/drivers/gpu/drm/ivip/Kconfig > @@ -0,0 +1,14 @@ > +config DRM_IVIP > + tristate "Intel FGPA Video and Image Processing" > + depends on DRM && OF > + select DRM_GEM_CMA_HELPER > + select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > + select DRM_KMS_CMA_HELPER > + help > + Choose this option if you have an Intel FPGA Arria 10 system > + and above with an Intel Display Port IP. This does not support > + legacy Intel FPGA Cyclone V display port. Currently only single > + frame buffer is supported. Note that ACPI and X_86 architecture > + is not supported for Arria10. If M is selected the module will be > + called ivip. According to Documentation/process/coding-style.rst, Kconfig help text should be indented with 1 tab + 2 spaces, not 2 tabs. -- ~Randy