Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1586451ybi; Sat, 8 Jun 2019 13:17:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxI3T8JiVaO2skr3cnM7B/9E1adLcTBsAq8AQ68ORgq4n7VdHVURbxuQt/JxbxXbeTuLJZy X-Received: by 2002:a63:a84c:: with SMTP id i12mr8844153pgp.115.1560025049996; Sat, 08 Jun 2019 13:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560025049; cv=none; d=google.com; s=arc-20160816; b=Q6Oa3qIbsfzJqM62Oey+F4HzoFcwicGHJggWG1hRJYGai/a+fHmASPBDTdWdHm3UdW 2q4wiuJWi1udrIn2VRaDMCGMBV8jFfpC+TrsrfWTGpJrRmqXI/Rmtz3bGYpcfRo1W0yP E2J76YkhQp78TDUQAdpW/jXcdQ/VzEsaE2os7RsE6IOFAzIF97B/Lg1eWnkuBXIT8Yf3 JrE4iILlZggSHpOUhantZRPoybYTg0doj/SoqlPt3k5fSCNr6QuFzUiXHba3WmdjeJkA yOD1hICZ1CajNRzvfqpedRHtqib7NYdVhE9infFt7pvagZcxbVfWCok2uSPP8xUK9+Ad 8A+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YLlwXriYXWRDWa6HLbM2ROrlGesibqzQ/9uF5Z67oTI=; b=VaqLQQdh6uWUo0o2n473sKC7njfSXPTzqC/gPOKaVfIfsYHuzBCEJh9HcpsSzI1dda jUAjFVKLqMP0Fk/WLGm0sGYoX4HSC/9axBtzgvsu/YvD2TlKZszfRzXpWbf0/XIXKjWQ QKLwhfWFtqHfJjInPVLqzegP53KscLqwDgmcNSB6ckdTzwXbHHM/Wc0ODuyah/V9w/b1 5rj8OXTwgmcudAtFKn3pTb6/f0+3JUNyqMCxg6w7oH9RR9ce8wIT9xevOUeGptKPYxPx MKLg0rADc80Yjqyfd6lad/Mrf+c5PQ85MBSgGGBOSMZSQYXmFXP+4Q6yzjJO0aCdDweU Ej0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uOug2p1q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a19si5120404pjo.77.2019.06.08.13.17.13; Sat, 08 Jun 2019 13:17:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uOug2p1q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727531AbfFHUQJ (ORCPT + 99 others); Sat, 8 Jun 2019 16:16:09 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46915 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbfFHUQJ (ORCPT ); Sat, 8 Jun 2019 16:16:09 -0400 Received: by mail-pg1-f194.google.com with SMTP id v9so1202955pgr.13; Sat, 08 Jun 2019 13:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YLlwXriYXWRDWa6HLbM2ROrlGesibqzQ/9uF5Z67oTI=; b=uOug2p1q8b8ToqRGjDQGLomtv0cac2TObRAWxk6HBJ+4oJVfEu1muX75mCezZMdLXg Vle/ZUpPXzGHtdlKSXX3k3RgnQJUjFFCjfoJ33uCDI2XQDgePNy/jarK019y4htN7HkT vzvi/FFaDranTeHdGdmfnmTP52qzwjR/uzfmLOR5l1cvBnSNUphByrCzNIo+WHLXhdVa OnVxEkhlfTpYHHSw0EbVr6L86UobqFpQELoCsKmhAFqXDz0AWIgFzWPOlGcER60CxYTo i9m43LDICNLo3k/ejj04x+xV4RHeTUE4Va53kFNzP2ElRQijJYJVnK6Y/K+bil2eZWIa xAkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YLlwXriYXWRDWa6HLbM2ROrlGesibqzQ/9uF5Z67oTI=; b=cdyIHN25CCAYrTLfQx+tU54bZ3dePi0+vqgLMZgO4luZMf3ysrzIztgjifzks1LH31 emQ3aipa4W37Fm0HIDNimZrvz31M1jdfNGJPiep/sEgk4dnP5UleJ2TBkVHyQOZNoa3K xOXV44Cj76bdrghd7zOgoCa0OpdcUpJkJDGIPVSg0VEcWdouZtOq6lutXhDe9VEg2MTe 2qpq8HlwlXZxfScksCUKWoqeRaBDIERZvpLGjpp69cz6A0Mbf7V9DPV536XoJ23gyV1W rgOdcQKsJ2e61+L2Se81VXMhtZotwljHCK+mpoa6G+EUGRO1vTosoorSqA7IvudbyxkS AmOw== X-Gm-Message-State: APjAAAW67AtiO9yCVdyMT+l8NpEm1A30dyFRwvqzJb74n/7m/BTlRAly 5TUgnf/cYpKmFGeYVA7GgWtK/worLoU= X-Received: by 2002:a17:90a:c303:: with SMTP id g3mr13064434pjt.58.1560024968206; Sat, 08 Jun 2019 13:16:08 -0700 (PDT) Received: from localhost.localdomain ([123.213.206.190]) by smtp.gmail.com with ESMTPSA id s64sm5196863pfb.160.2019.06.08.13.16.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jun 2019 13:16:07 -0700 (PDT) From: Minwoo Im To: linux-kernel@vger.kernel.org Cc: Minwoo Im , Jens Axboe , linux-block@vger.kernel.org, Chaitanya Kulkarni , Christoph Hellwig Subject: [RESEND PATCH] block: move tag field position in struct request Date: Sun, 9 Jun 2019 05:15:51 +0900 Message-Id: <20190608201551.4531-1-minwoo.im.dev@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org __data_len and __sector are internal fields which should not be accessed directly in driver-level like the comment above it. But, tag field can be accessed by driver level directly so that we need to make the comment right by moving it to some other place. Cc: Jens Axboe Cc: linux-block@vger.kernel.org Signed-off-by: Minwoo Im Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 592669bcc536..90e6914bea0c 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -137,11 +137,11 @@ struct request { unsigned int cmd_flags; /* op and common flags */ req_flags_t rq_flags; + int tag; int internal_tag; /* the following two fields are internal, NEVER access directly */ unsigned int __data_len; /* total data len */ - int tag; sector_t __sector; /* sector cursor */ struct bio *bio; -- 2.21.0