Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2106705ybi; Sun, 9 Jun 2019 04:01:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjLcenpf29ylvzxIsKCa3iTjeSu8nceVl3tqXDp8Yj986NVRXIcK3ADGxI4Nr8roNodNzh X-Received: by 2002:a17:902:3183:: with SMTP id x3mr11506207plb.321.1560078062741; Sun, 09 Jun 2019 04:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560078062; cv=none; d=google.com; s=arc-20160816; b=zdKe7VbmDf95F36p795tE16456CO+SMK/gxSppFAyuchjhOjbz1f99i0IBAzxRc0ON Zt1+cvUXjltihsBDySnXR4PMoDb7Gy80Yldydtv0wcUk0JY+LFz00io9K1StBdMzyAXo rFO9MOUkSjUAazf163gWimf+tNdnDv//NPdLMQH/QeB5nUULnxlWsSgViuj3Lrp5wGqT Ajcc8ZL9fMAHTt+9TSMbj4W+3EumBzYc5PGLjQoC4EijrzwbxI6cnbvzIMYgE1GtAg2L FEUfPDiO0QQK2zOcpvpjOBDPPfbO6Iln+2xM7sAk+JW4Q7HszSERoOpGxsDOjXoxkKtu Xx2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2r0FEedtBpTOIzbaRpmxR7LrfldkYb+LG75AXP6YdZg=; b=Jl+L6uBvIJ5o68kpQVOrAvpSJk/KaR8QFSeEVBT5MRDb7nIMGvozCGh1TMZHE5SK8H ajZKPnWU85QCg7C+h5bXuIkib8SNf6l+n+RRUgyRpxAKAAAaP3aIb1gPO8iUmb8OaIxT sl7o+Tt2KunhXOO5/A/LPSUx1V9V230hwsWuqfQlIzDl4HBMWtMfcYD5aY7QFZoJdVkm nzW6YfXU+Ou4h9OC98rPF62o9HZjpIIIekmMtfXu3cEYsKFwV/djRaDCgQa5TK/F3e5L 18oonZ1WQi9jmDD2DeEK5z5RNm6UP6x/UBcBgKVWdxFbtG7nPluLN26RTadpoxmkDqdW WjEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VCJF76xS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17si7117819plo.46.2019.06.09.04.00.44; Sun, 09 Jun 2019 04:01:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VCJF76xS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbfFIK7e (ORCPT + 99 others); Sun, 9 Jun 2019 06:59:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbfFIK7e (ORCPT ); Sun, 9 Jun 2019 06:59:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EAB02083D; Sun, 9 Jun 2019 10:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560077974; bh=cSnrY0iwjVJXZwlEA+2n8J0j0S3Bx09YY45oP76Myok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VCJF76xSiUB32mel7TvguvVDFQqBgoIcn2OFACK2R2d0l4IIjNsxL6nGAj7hPDzgb Y+SGYsTo6jAbm6PI/tOljchkwivb0T3coyV6q86U/c97BodWtH+mzuFIADssf8sQ3+ 7k3NvE84Vc9sFPeUEw37b1ZKKFwPBRyyUPO630Ss= Date: Sun, 9 Jun 2019 12:59:31 +0200 From: Greg KH To: Valerio Genovese Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared. Message-ID: <20190609105931.GB30671@kroah.com> References: <20190605135349.6840-1-valerio.click@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190605135349.6840-1-valerio.click@gmail.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote: > This was reported by sparse: > drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static? > > Signed-off-by: Valerio Genovese > --- > drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h > index cdac46a21692..a651686b1787 100644 > --- a/drivers/staging/isdn/hysdn/hysdn_defs.h > +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h > @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info; > /* exported vars */ > /*****************/ > extern hysdn_card *card_root; /* pointer to first card */ > - > +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net I can not take drivers/staging/isdn patches until 5.3-rc1. thanks, greg k-h