Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2108969ybi; Sun, 9 Jun 2019 04:03:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1OkpXlcZYub/yEvYnJLwhL4ccaeLjZdNbrSCLMrDfwkJ05GNlZhVX5LWyVFnkvJwni2jX X-Received: by 2002:a17:90a:8985:: with SMTP id v5mr15413931pjn.136.1560078205945; Sun, 09 Jun 2019 04:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560078205; cv=none; d=google.com; s=arc-20160816; b=mlcYtgg1r9JISaphM/UYzdMQv5TM2es0RhDXPPCoizO5tVqoN93vWSFuAhQqeBLpg9 7BE6az9nqUD5lcgs4cs/wvGlGCYUzdvcHfA6Op6+DvS5gctSAg0SwjAH8yxzuThwN3zR ClNGL0ZH8JPxSDSJYDnI3OAg/pBqEAPCVX8WqONB1P9eRwtYlM5grJgD3kNDYrSqH38n 19MHLx6JeIiDvlSlu0cQNKgoBrhgCMGxghWbWWaDHJDe2a8Mi95Rh9iBm9/VhEX4VUje CJDcBGmTxrG8ATcMkZ4MagI0C9iwcyoWOZsaxgJBfI0RrewMWhT4bQx3gFu623zbcYJE RTSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aSyDCd/Z5Zs4dU3zSO5SAjSnDNgvMjfVeaRmkrr+zsU=; b=nQPTdHQ/iZ1jGD2cd4EUULByfjfllQ0DkGAXIBQ3eu288wwEhoLIpZEYY5GICKXnA9 M96xKPnDKroRB3BGLgYts39oYMLR3aDrQYITTFPNcRWJ/pHRrSNJDNy5g4yRisZY6JPn IlW8CRSX/1bAt0KCbrFvc9JgN5947nlf6ByAWvd95ZXHsJlug9DReQ3chGT40lBdKdcX gWQQtg5xwpzfSfCRpYr6/a/BBQgh7U5RCHVpuBALif1PcX1nC0Hzw804n0YH4ZPKYR1i /+Ooi+DWGtvXhgesPNqWqlVzAzD5Sil+oqn7zWLWmoLnPdbE1+sa9jCIf3qrKbOwU7VB kx/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DiF2h4EF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g23si7136700pfi.153.2019.06.09.04.03.10; Sun, 09 Jun 2019 04:03:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DiF2h4EF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728317AbfFILBT (ORCPT + 99 others); Sun, 9 Jun 2019 07:01:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:40246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbfFILBT (ORCPT ); Sun, 9 Jun 2019 07:01:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 420272083D; Sun, 9 Jun 2019 11:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560078078; bh=4yCqDJ6gnHMOGHmX6Tj7HsB2ULZ8HyC9XSpyPlZH4I0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DiF2h4EF+q1VatqeNNr06wWGkVwjUzpfSQpb1dwlJhdSr5IoS5j0usJ76lShqaL70 7T/PF99a+BRVtuv52+XIJxsGjywPhetr3EmRbnUwBOFXw+cQ9jZutFcQsQJyjdxKAA zlZX0cAgEm2RLyZ73FcQdaBajpx1BEa9V1wPfYmo= Date: Sun, 9 Jun 2019 13:01:16 +0200 From: Greg Kroah-Hartman To: Hariprasad Kelam Cc: Michael Straube , Arnd Bergmann , Hans de Goede , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix indentation issues Message-ID: <20190609110116.GC30671@kroah.com> References: <20190609053741.GA12637@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190609053741.GA12637@hari-Inspiron-1545> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 09, 2019 at 11:07:41AM +0530, Hariprasad Kelam wrote: > fix below issues reported by checkpatch > > CHECK: Please don't use multiple blank lines > WARNING: space prohibited between function name and open parenthesis '(' > +void _rtw_open_pktfile (_pkt *pktptr, struct pkt_file *pfile) > WARNING: space prohibited before semicolon > WARNING: space prohibited between function name and open parenthesis '(' > CHECK: spaces preferred around that '-' (ctx:VxV) > CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf" > CHECK: spaces preferred around that '*' (ctx:VxV) > CHECK: spaces preferred around that '/' (ctx:VxV) > WARNING: Missing a blank line after declarations > WARNING: braces {} are not necessary for single statement blocks > CHECK: spaces preferred around that '/' (ctx:VxV) > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam That is a lot of different issues trying to be fixed in one patch. Please break this up into "one logical type of fix per patch" and make a patch series. thanks, greg k-h