Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2361573ybi; Sun, 9 Jun 2019 09:52:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwv9Pm0CRnhTjx9vUJMtfLznDnjPwN4C+dI3clNIYQ2REXBejbnRzpnbuSMD0VFAnDXswS/ X-Received: by 2002:a63:6ec6:: with SMTP id j189mr6749918pgc.168.1560099144517; Sun, 09 Jun 2019 09:52:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560099144; cv=none; d=google.com; s=arc-20160816; b=JolMxuHjXMO5h+6LiwyPQ1v5eUVUcWH3kV2rFcfkM7Sxf+dtiP5lb2DyCjtvnOHZCx 0G3pftILtuT8kukticdgu03n088bfX3VMzO+MevHoxpUStEVYE7UzOTFl0BZMxFeSTLF Fy9xLvSuzSk4OGdUWpq9U9jm/fpn3cAprxneaCYRoDKqlcq6VeeK7X8GkgLfHq4jNmpU HwhaRUfUKA0gtLD3GXiog+o6wSw3Oo8dcqi/Oc20E1Ybl0x4diLYRl+sNmUfc47l6K6i +S5bp/DsXZNPcagc0tzxEkyzsMk5WaXmZK2ma/XeYSUs4d4Lph3qKLhS/bTWPhuwLm+A 5/ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SE2beO+Uw/rA/cHVUJdqMy5vkgTh8gxmJYqjrh0tkWU=; b=LzdVT/66b6I+z5NJn1sxpbLTdHymfgoVu7VR3o4kKhcozTyGmUJUnbr0uVlSjOmyjE xrS73JeH8oDYGVxhjxzHX6lgDFkIs7MZAAVY1YQL59D3WN1CDANV5VjqC9w1FgjuvLSX eB5taAWD253fr3lYkkDoJNNN4FWLoDb2NcNzWQvy6NvH+987LjZdbJhgVXn92UeyOOol Dn5MJTMjaX+xmtjhy7bcDD5d5SyVfu6kF4PpPnnshThanSp6Sh0htHupWvybZRdhHlAf +uQPen6/4t69vyK0uihEnkCBPvpDhohaM2ybXl/S0XXEWUGqlI0OFukmjy3XokLExTOz 0BOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mxQ1xocw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si1413244pgk.387.2019.06.09.09.52.08; Sun, 09 Jun 2019 09:52:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mxQ1xocw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731394AbfFIQtG (ORCPT + 99 others); Sun, 9 Jun 2019 12:49:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:48350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731380AbfFIQtD (ORCPT ); Sun, 9 Jun 2019 12:49:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 499A2206DF; Sun, 9 Jun 2019 16:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560098942; bh=lVvONsK8aHnJphzCHw+ySLVGodwHhULxSw4z2hudIUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mxQ1xocwLoLbO2JD+fNnTTpBy86/R8yXOW3eHlCk+Un8P9FNK+3qQBEF3MtbTLtj5 InUwKWqdF/Uw2NxBt2Pig/+SxP0V1YdTPUx8J4H/yO6pajyaf1Djhg//Hh/U4vRwen dQ7B5XBDambc4IZZgArgDGjjHxlE22BRHYm+xi18= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Patrik Jakobsson Subject: [PATCH 4.19 37/51] drm/gma500/cdv: Check vbt config bits when detecting lvds panels Date: Sun, 9 Jun 2019 18:42:18 +0200 Message-Id: <20190609164129.590532035@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164127.123076536@linuxfoundation.org> References: <20190609164127.123076536@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrik Jakobsson commit 7c420636860a719049fae9403e2c87804f53bdde upstream. Some machines have an lvds child device in vbt even though a panel is not attached. To make detection more reliable we now also check the lvds config bits available in the vbt. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1665766 Cc: stable@vger.kernel.org Reviewed-by: Hans de Goede Signed-off-by: Patrik Jakobsson Link: https://patchwork.freedesktop.org/patch/msgid/20190416114607.1072-1-patrik.r.jakobsson@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++ drivers/gpu/drm/gma500/intel_bios.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.h | 1 + 3 files changed, 7 insertions(+) --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c @@ -594,6 +594,9 @@ void cdv_intel_lvds_init(struct drm_devi int pipe; u8 pin; + if (!dev_priv->lvds_enabled_in_vbt) + return; + pin = GMBUS_PORT_PANEL; if (!lvds_is_present_in_vbt(dev, &pin)) { DRM_DEBUG_KMS("LVDS is not present in VBT\n"); --- a/drivers/gpu/drm/gma500/intel_bios.c +++ b/drivers/gpu/drm/gma500/intel_bios.c @@ -436,6 +436,9 @@ parse_driver_features(struct drm_psb_pri if (driver->lvds_config == BDB_DRIVER_FEATURE_EDP) dev_priv->edp.support = 1; + dev_priv->lvds_enabled_in_vbt = driver->lvds_config != 0; + DRM_DEBUG_KMS("LVDS VBT config bits: 0x%x\n", driver->lvds_config); + /* This bit means to use 96Mhz for DPLL_A or not */ if (driver->primary_lfp_id) dev_priv->dplla_96mhz = true; --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -538,6 +538,7 @@ struct drm_psb_private { int lvds_ssc_freq; bool is_lvds_on; bool is_mipi_on; + bool lvds_enabled_in_vbt; u32 mipi_ctrl_display; unsigned int core_freq;