Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2414290ybi; Sun, 9 Jun 2019 11:10:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRjIJsWbPzqipwlP6ZkB/LjN2VNKiC34mQqY5cR4cXTLQbRAwW21xhu3wW9A02Jj1HAK7S X-Received: by 2002:a63:dc09:: with SMTP id s9mr12578296pgg.425.1560103808168; Sun, 09 Jun 2019 11:10:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560103808; cv=none; d=google.com; s=arc-20160816; b=A9JtwUAV4Az06SAkjvPM1A92jAQlB/Dg2t24KWTEAaRJoSWGxzdS/GHU1tI4IkVmIv RYml3/xuP9kE4ScYEHaRAf04KT/5+gj3Weu07Eno8LNzD3GIikIGNfwmSDvNjahM1mFz wAQV2ZzT69N+b53SygfbLTuoBOT/Qypgihq7UQExJun5zUEGtP6DTK1bxKKmPr+jhN8h 1HuNUxxYNoiGVf9LYsLbL1uPMWLLRPK3Q52Sp65tIZSeybU1Df7TsFNMLi1tw/tjZjp/ iVY394oWQsRS0FZ42/0wCbt5ENkuFp2qLOeiKbPdHKQ03Zf9+JbV09lzXXV39SNP78lw Ay/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v7PbZ+bePIYQLHgJpsIkmu/MB4zvlnOVPIUxjbK/8CQ=; b=ApkZTF19NZYSdDP2uWTrrKPYFtTe5ACtTOjmP4P4VZj/gomxEOpm5k8/NbXQpdBr/4 BMrrNZcn/u7x8grtZChdBCpbYJlTypWKvuBM4ZdG88hsb3YEktQZV2c2GZzciqzdmyqu P4ZCpjRrUvNdXoKnRlxbNSRx1ZLjz4ixyP7/zJcvHYrhqWk7+ytY8sNEVVj5WhvCowRT /POCmuPUgA0dMPt8jdNTO0d1zRHypD0+7zGwyaNcZmLapk6cqojMFLEPH+KQJe2OuUAi CMxgfuksFfPZmlHcnfkfQ8W4drzOfXWBH+hvMuOL3I14JkiyfPkaKuRZMVDG4A5WyZX4 3t8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d2Ru52nm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a59si7956412pla.348.2019.06.09.11.09.52; Sun, 09 Jun 2019 11:10:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d2Ru52nm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732731AbfFIQy7 (ORCPT + 99 others); Sun, 9 Jun 2019 12:54:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:56872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732720AbfFIQy4 (ORCPT ); Sun, 9 Jun 2019 12:54:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D093E206BB; Sun, 9 Jun 2019 16:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099295; bh=4FML/o2EtP3soLK1Ab0p0Ho+ha22Df+p/94QuNrxILI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d2Ru52nmAMsl1IkCn/PxR2PjogHA6KjZZL+JaTc9vCaQQTzGTv5FjtGFIXBLflRBc JWYQFlstMTk5KWRtY2NOsc3XQIxvz2opzXWy9qWimrkJfJYoRFoeLxvfrXPX3qjy7W iKyJZWQPsVmskw4UdYGUnInHzihAl/+SGQXDXcQo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Dufresne , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher Subject: [PATCH 4.9 79/83] drm/radeon: prefer lower reference dividers Date: Sun, 9 Jun 2019 18:42:49 +0200 Message-Id: <20190609164134.682755401@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164127.843327870@linuxfoundation.org> References: <20190609164127.843327870@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christian König commit 2e26ccb119bde03584be53406bbd22e711b0d6e6 upstream. Instead of the closest reference divider prefer the lowest, this fixes flickering issues on HP Compaq nx9420. Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=108514 Suggested-by: Paul Dufresne Signed-off-by: Christian König Acked-by: Alex Deucher Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -935,12 +935,12 @@ static void avivo_get_fb_ref_div(unsigne ref_div_max = max(min(100 / post_div, ref_div_max), 1u); /* get matching reference and feedback divider */ - *ref_div = min(max(DIV_ROUND_CLOSEST(den, post_div), 1u), ref_div_max); + *ref_div = min(max(den/post_div, 1u), ref_div_max); *fb_div = DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den); /* limit fb divider to its maximum */ if (*fb_div > fb_div_max) { - *ref_div = DIV_ROUND_CLOSEST(*ref_div * fb_div_max, *fb_div); + *ref_div = (*ref_div * fb_div_max)/(*fb_div); *fb_div = fb_div_max; } }