Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2425534ybi; Sun, 9 Jun 2019 11:27:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwaqUoWkWx1aarEC2qX8j2qrR4P3ait/lJRboatvzIr7Qrvc91J19j/FjSmtfjH8UG/AtkI X-Received: by 2002:a63:f456:: with SMTP id p22mr11444481pgk.34.1560104878446; Sun, 09 Jun 2019 11:27:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560104878; cv=none; d=google.com; s=arc-20160816; b=RI0+lRyhvRS24M4pEOOlIHds69OvGMKkPbc1x4DLUKxGPpuo1Elg/fu8dI+xUpBaXn xs+AekhK2E2gj75ybeqr9a9kJl0dfwKrUt0DOMcoBxpDJscNKuKB0PCrsKG9b2E1iNe2 Z3wdsehVTN0fYVhaC+YB+LyS284HOEF1jsiSzPT3e6uTrfLl5vNFhNw5Sh9YDiZ4dRgd 7hjb/hiGb2JfCd89f9uFyWERgY2cyKbd7pAUv98c7sT3NjMiTxUGQjs8fQEteYC7duCd z292AHdiPPgHSxu/TerADoTpwXYNNWGu4WoYRS0zBZQU5zWZYX+pF5SM/pa/iS1InKuH +uYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BPSXJ1g5GCD+xBGYpJ4DOmI7sJlD1VRG1KXVkYfJpak=; b=PPXca1Iw56Q2cjb+mPc8bWuxTmIoiyFxz2u7WssP90Zp/iJIlryQNDVRDysIjygSBh X1ZsOU4+9qI2zHujAEQsk+GpC+RiSFptW3glnWmTRCjcv+1BttrXt31x3h+HgRQLOE7l NWKV8PeF9Szmu73No2om+EIPDSrFMS2I4VNtW0sDX84vGpwt/jgmXTEcOH6qGbguQdha kxIRjJqmQtY48uAwY97xK807ouTkiq7ygmaws2TiIJP6ptSX74KxFKghqs1Gr6JY9Arg uD63MS6+gxLgcb3mHXWAuoZ7JaDQTXiCnUz1BUkYSsHRPOii0aiEILcirx8uWeJeuQAm VSxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uqMqn3Lk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o127si567947pga.593.2019.06.09.11.27.42; Sun, 09 Jun 2019 11:27:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uqMqn3Lk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389124AbfFIRHB (ORCPT + 99 others); Sun, 9 Jun 2019 13:07:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:47044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388593AbfFIRHA (ORCPT ); Sun, 9 Jun 2019 13:07:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C41A1204EC; Sun, 9 Jun 2019 17:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560100020; bh=kwW5+pOo3pPjSz9BOXtdOb8u8nq7tl+VmP88bEPje4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uqMqn3LkXPEhFlak4hl1gXV5PeGKLY/m7y9/h6KxdFIMuh9uNbPx/hxZJIuJC5foQ sSyhmjz+mATftxSWG/y50AUQTzZW8lH4VNl25Ik7buQj2sBw7RUv90XMGvZfCwmbkl drFJsMHvyDXq/4E3asd7AAB14U5gwonm1OCH7gWI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Felipe F. Tonello" , Felipe Balbi , Peter Chen , Nobuhiro Iwamatsu Subject: [PATCH 4.4 227/241] usb: gadget: fix request length error for isoc transfer Date: Sun, 9 Jun 2019 18:42:49 +0200 Message-Id: <20190609164155.265088934@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164147.729157653@linuxfoundation.org> References: <20190609164147.729157653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Chen commit 982555fc26f9d8bcdbd5f9db0378fe0682eb4188 upstream. For isoc endpoint descriptor, the wMaxPacketSize is not real max packet size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation), it may contain the number of packet, so the real max packet should be ep->desc->wMaxPacketSize && 0x7ff. Cc: Felipe F. Tonello Cc: Felipe Balbi Fixes: 16b114a6d797 ("usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_aligna") Signed-off-by: Peter Chen Signed-off-by: Felipe Balbi Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Greg Kroah-Hartman --- include/linux/usb/gadget.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@ -671,7 +671,9 @@ static inline struct usb_gadget *dev_to_ */ static inline size_t usb_ep_align(struct usb_ep *ep, size_t len) { - return round_up(len, (size_t)le16_to_cpu(ep->desc->wMaxPacketSize)); + int max_packet_size = (size_t)usb_endpoint_maxp(ep->desc) & 0x7ff; + + return round_up(len, max_packet_size); } /**