Date: Sun, 20 Nov 2005 20:27:09 -0800 (PST)
Message-Id: <20051120.202709.20027544.davem@davemloft.net>
To: pavel@suse.cz
Cc: sam@ravnborg.org, akpm@osdl.org, davej@redhat.com, bunk@stusta.de,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on
 i386
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20051120232731.GG2556@spitz.ucw.cz>
References: <20051117200354.6acb3599.akpm@osdl.org>
	<20051119003435.GA29775@mars.ravnborg.org>
	<20051120232731.GG2556@spitz.ucw.cz>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 24

From: Pavel Machek <pavel@suse.cz>
Date: Sun, 20 Nov 2005 23:27:32 +0000

> Well, please don't do that. -Werror makes development very painful.

I've had all of arch/sparc64 in -Werror mode for more than a year,
and it's anything but painful.  It's prevented me from introducing
numerous bugs inadvertantly.

People miss warnings or flat out ignore them, if the build fails they
will have to fix it up instead before sending in their changes.

Yes, for a spot like kernel/ it's more difficult since it's
compilation is influenced by so many configuration and platform
specific stuff, but that's just too bad.  Getting it warning free is
still something we can and should do.

Saying it's too hard, so we shouldn't even try, is a self-fufilling
prophecy.  I definitely want to add -Werror to net/ very very soon.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/