Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2479059ybi; Sun, 9 Jun 2019 12:49:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpKfMBXmOBlUhBCVEMQAnxxOym6Cvei8cLpVa++umjhsPcnd9xmM07W0WUGJMINlT1L/PI X-Received: by 2002:a17:90b:d8b:: with SMTP id bg11mr17551053pjb.30.1560109757593; Sun, 09 Jun 2019 12:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560109757; cv=none; d=google.com; s=arc-20160816; b=f+VWszqsd4kirRQrfLGYvwRyWC6YdjfpKJ7eS5+abmYA1PLQsNX63ewT29YEgOYfd6 aEgGjT8BUnsokjzuTwV9sFgRnli5uVICltbTSCqdWUJbX9Y0rLgnYYXnPdPULLveykHX GxxsKLbUfI0PM6QIFHWlA+8PuShxF3s6nV/k3ycZ845w7Euq61WWOmRrAAHan+peLG+O IbZkshXo658P8Jf2D/hVmcMzwt/COilxlpvdmN8GOUsg+7NcBKWfCg6hJaGWwpKucqmb aA+puUehnpqJM/7/PxHyrF3Kld+KZqSXpxXUKvzWA0xqLHGPjQ41dw4mklCcsr2U0wqC PutQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Jpt0hdUgML7nVPvSKG9wvv1IFFQnAAOS/ihrDzC0gk8=; b=rELRI9txMJJb4moy/8ZZWgnn8tNx0LAYnNr0sfz085dPOMhPPv7+NaeSaRxY2r+4UV zfL1X5HuyZbYbwY9leXal59x+qSZguVPYAS2Wi5shZE0Uj3L/XjQZo3InZVe5ReRwrYD zBldfR1wG14BcNj2nIVlLNqBtVlp6L4kcyYz8amhjLQkL15bf65RAhfUGRWtbVN65vcC UkOrAplqBzIceDPjvRbY1CVZML/EdKBlePy2778Gohl45lDaCUYzvVnx/XAJsonCNHZi Frm5tRBMnIG3/jJ01+JiWoLiMehr9kBMViRfxB0+KI0BIkgZxvK3/2SyVYHsMuT16TqS mz+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o31si7603041pje.45.2019.06.09.12.49.01; Sun, 09 Jun 2019 12:49:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729637AbfFITr7 (ORCPT + 99 others); Sun, 9 Jun 2019 15:47:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44540 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726950AbfFITr7 (ORCPT ); Sun, 9 Jun 2019 15:47:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D9A8114DD36DF; Sun, 9 Jun 2019 12:47:58 -0700 (PDT) Date: Sun, 09 Jun 2019 12:47:58 -0700 (PDT) Message-Id: <20190609.124758.1263532600061409322.davem@davemloft.net> To: info@metux.net Cc: linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ipv4: fib_semantics: fix uninitialized variable From: David Miller In-Reply-To: <1559832197-22758-1-git-send-email-info@metux.net> References: <1559832197-22758-1-git-send-email-info@metux.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 09 Jun 2019 12:47:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Enrico Weigelt, metux IT consult" Date: Thu, 6 Jun 2019 16:43:17 +0200 > From: Enrico Weigelt > > fix an uninitialized variable: > > CC net/ipv4/fib_semantics.o > net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': > net/ipv4/fib_semantics.c:1027:12: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (!tbl || err) { > ^~ > > Signed-off-by: Enrico Weigelt Applied.