Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <nobuhiro1.iwamatsu@toshiba.co.jp>
To:     <nobuhiro1.iwamatsu@toshiba.co.jp>, <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        <alan.maguire@oracle.com>, <dsahern@gmail.com>,
        <davem@davemloft.net>
Subject: RE: [PATCH 4.14 03/35] neighbor: Call __ipv4_neigh_lookup_noref in
 neigh_xmit
Thread-Topic: [PATCH 4.14 03/35] neighbor: Call __ipv4_neigh_lookup_noref in
 neigh_xmit
Thread-Index: AQHVHuNu8OzoZhxZwE2KmkrEWxzIOaaUFMqAgAAAXmA=
Date:   Mon, 10 Jun 2019 01:13:16 +0000
Message-ID: <OSBPR01MB418448C373F7E3F2D4BCFE0592130@OSBPR01MB4184.jpnprd01.prod.outlook.com>
References: <20190609164125.377368385@linuxfoundation.org>
 <20190609164125.756810906@linuxfoundation.org>
 <20190610011024.utn5fft7nocabqxb@toshiba.co.jp>
In-Reply-To: <20190610011024.utn5fft7nocabqxb@toshiba.co.jp>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: toshiba.co.jp does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 44e7b07e-efaa-4a66-c5bb-08d6ed40d150
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2019 01:13:16.3626
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nobuhiro1.iwamatsu@toshiba.co.jp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2454
MSSCP.TransferMailToMossAgent: 103
X-OriginatorOrg: toshiba.co.jp
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi again.

> -----Original Message-----
> From: stable-owner@vger.kernel.org
> [mailto:stable-owner@vger.kernel.org] On Behalf Of Nobuhiro Iwamatsu
> Sent: Monday, June 10, 2019 10:10 AM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Alan Maguire
> <alan.maguire@oracle.com>; David Ahern <dsahern@gmail.com>; David S.
> Miller <davem@davemloft.net>
> Subject: Re: [PATCH 4.14 03/35] neighbor: Call __ipv4_neigh_lookup_noref
> in neigh_xmit
> 
> Hi,
> 
> On Sun, Jun 09, 2019 at 06:42:09PM +0200, Greg Kroah-Hartman wrote:
> > From: David Ahern <dsahern@gmail.com>
> >
> > [ Upstream commit 4b2a2bfeb3f056461a90bd621e8bd7d03fa47f60 ]
> >
> > Commit cd9ff4de0107 changed the key for IFF_POINTOPOINT devices to
> > INADDR_ANY but neigh_xmit which is used for MPLS encapsulations was
> > not updated to use the altered key. The result is that every packet
> Tx
> > does a lookup on the gateway address which does not find an entry, a
> > new one is created only to find the existing one in the table right
> > before the insert since arp_constructor was updated to reset the
> > primary key. This is seen in the allocs and destroys counters:
> >     ip -s -4 ntable show | head -10 | grep alloc
> >
> > which increase for each packet showing the unnecessary overhread.
> >
> > Fix by having neigh_xmit use __ipv4_neigh_lookup_noref for
> NEIGH_ARP_TABLE.
> >
> > Fixes: cd9ff4de0107 ("ipv4: Make neigh lookup keys for
> > loopback/point-to-point devices be INADDR_ANY")
> > Reported-by: Alan Maguire <alan.maguire@oracle.com>
> > Signed-off-by: David Ahern <dsahern@gmail.com>
> > Tested-by: Alan Maguire <alan.maguire@oracle.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> 
> This commit also requires the following commit:
> 
> commit 9b3040a6aafd7898ece7fc7efcbca71e42aa8069
> Author: David Ahern <dsahern@gmail.com>
> Date:   Sun May 5 11:16:20 2019 -0700
> 
>     ipv4: Define __ipv4_neigh_lookup_noref when CONFIG_INET is disabled
> 
>     Define __ipv4_neigh_lookup_noref to return NULL when CONFIG_INET is
> disabled.
> 
>     Fixes: 4b2a2bfeb3f0 ("neighbor: Call __ipv4_neigh_lookup_noref in
> neigh_xmit")
>     Reported-by: kbuild test robot <lkp@intel.com>
>     Signed-off-by: David Ahern <dsahern@gmail.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> And this is also necessary for 4.4.y, 4.14.y, 4.19.y and 5.1.y.

4.4.y, 4.9.y, 4.19.y and 5.1.y.

> Please apply this commit.
> 
Best regards,
  Nobuhiro