Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2724970ybi; Sun, 9 Jun 2019 19:26:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMniZheYPdied2L8RsKYLBjEyYXQCY/Pl5ufvYwKVZSKDYTMXK8JPjc4uwqbgzXM9bLsVe X-Received: by 2002:a65:4806:: with SMTP id h6mr13227697pgs.299.1560133581080; Sun, 09 Jun 2019 19:26:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560133581; cv=none; d=google.com; s=arc-20160816; b=hHBaGsRo1sGc4xNOWNJ9jS7r5G4JihSffCn7w481Z3FQuOvbEzxGunMeY2glktFfzt f/Zv48u1A/XCeDc2DudovRLVAMCB00xaZrd73lF7WaScyP6QBSXjs6t6+dLXbTPkTUzk R6oSXy6++evH8gELRqBntQQmwRTYy9QUl9/btH9d/JdBRWhqQLy8+VifSgnBt9dtsOM0 2OecNr0H3MGa6AqoA5ZaOuEuwjI5OwHv+WsrEKHAlX+WgaNryFzZHuX4Cj60Wp0rCUYu JHbVsNDoWKEDhfgj9r8uoiqIATKR2W7q/WEQBUxXq+1IUlvdDgI6EqiiAp1fWNpH/dYr xtTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4zBkMGLED9l3FmX17OsaydHaK4tKEhb0w4jXMZi0ccg=; b=Brfl5G31+Lmumtf7ihlIZlaY8rLwYz6M74Ka8AB1W3p9JGojw2aXqqFMxu6lusS7KG OWIMKazwO6w0OFUp1rv+FQ/FkOVgIbXtbuj4+MHlX+tGUCgnal4yNcvwqPEB3egm25jx woP5DNB8c7plxcfz3ocuPN6+Z8T2N2lOR9DzKG2cl8lXOFg2y/pA6+YbTRBS60F2Tsjj trkAlH3IhOpLGfiz4P+nu9u8fUJ15mcdtwQvP/Y+owIle5OMxr8uXgmbKe7DFBrFhcDV ZSquVqhyNsUCOtxunDTYvz2QX//4c3lyy+OInspgo1XWrUiH3Fw8kGSWJN5Av1roPBbi CHEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Zj8WbwXA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d191si8361651pgc.460.2019.06.09.19.26.04; Sun, 09 Jun 2019 19:26:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Zj8WbwXA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387445AbfFJCXa (ORCPT + 99 others); Sun, 9 Jun 2019 22:23:30 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:46333 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387400AbfFJCXa (ORCPT ); Sun, 9 Jun 2019 22:23:30 -0400 Received: by mail-qt1-f194.google.com with SMTP id h21so8901475qtn.13 for ; Sun, 09 Jun 2019 19:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4zBkMGLED9l3FmX17OsaydHaK4tKEhb0w4jXMZi0ccg=; b=Zj8WbwXAV390RUM8igQnwN61lwTTn/QbFvp7GcZyBuJTSfCO9v8ItH0DUz5AJwZKsL yjsuCAo5jnkIuAgHavR0/2yY+KjqQFuhtBlgScpFJIGNHxNuOfFQzvysVmLkKjN8l8kc E2U0AJGuEI/Hh15D86vvyGuVN5avU22QMBAZzMnkvdX/ft3/mmqouRkdh6z8j6W+zYJX T0EWFI1oel+e2/ez/t+bhwWIR4bTVslecnKGaJ4/XMKs7na+Rr0QGCfBh0RPG+Jdew7J uzi52nr3Fcmn66ktZ4fin9On0w8vICKx6gtvErIui78HM40zjdNKhIGHKArloFA9MWld AT+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4zBkMGLED9l3FmX17OsaydHaK4tKEhb0w4jXMZi0ccg=; b=dWJKAorwOLUkU/Sjz9xb7UHiIweIfKE2rRYjvd+0NIqoWzwilmMw2pHktDVisLzkrA /FDgZe+BYBBtqKISET1ngKEYQUx91Toe8sSV+3CdN9V6asuwU5Qv/TpMEkVgarGoqXlk 6nr47z6hI+/fFf8XfaXX14bi9rmJ9Yw6UejsCXZelbf0EPwx8FDZN58++KE14NN2gdJ7 Kpc9Fl8ifEVEjn1XrYIsFBf5SMzFdZ0YRFGV3EI5nq7Z5l0gipzdu+CGu8J298rtj8Ba tY1myP7xoLuh78zELT1k+j2PQop2yJpHfdadgIja8tnUCgFGu4XIPaqQJObBo0cmY6gs gPnw== X-Gm-Message-State: APjAAAXnartV7jiEegrwjvcsG9av6Te5C3sAmCaaNb7X/FPGx4l/EHwD tJx7YIz2AgLNogHW+RX2oxaTPRGXEKYRWjTAjnO+FEkG940= X-Received: by 2002:a0c:a8d1:: with SMTP id h17mr24478187qvc.117.1560133409793; Sun, 09 Jun 2019 19:23:29 -0700 (PDT) MIME-Version: 1.0 References: <1559855690.6132.50.camel@lca.pw> <1559916886.6132.52.camel@lca.pw> In-Reply-To: <1559916886.6132.52.camel@lca.pw> From: Yuyang Du Date: Mon, 10 Jun 2019 10:23:18 +0800 Message-ID: Subject: Re: "locking/lockdep: Consolidate lock usage bit initialization" is buggy To: Qian Cai Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the further validation. On Fri, 7 Jun 2019 at 22:14, Qian Cai wrote: > Reverted the commit on the top of linux-next fixed the issue. > > With the commit (triggering the warning > DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != nr_unused)), > > # cat /proc/lockdep_stats > lock-classes: 1110 [max: 8192] > stack-trace entries: 0 [max: 524288] > combined max dependencies: 1 > uncategorized locks: 0 > unused locks: 1110 > max locking depth: 14 > debug_locks: 0 > > Without the commit (no warning), > > # cat /proc/lockdep_stats > lock-classes: 1110 [max: 8192] > stack-trace entries: 9932 [max: 524288] > combined max dependencies: 1 > uncategorized locks: 1113 > unused locks: 0 > max locking depth: 14 > debug_locks: 1 Then it is obviously we are talking on different things; then it is obviously a configuration problem. Fix will be posted soon. Sorry the bug. Thanks, Yuyang