Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190605111412.3461-1-zhang.chunyan@linaro.org> <20190606010857.GF29739@sasha-vm>
In-Reply-To: <20190606010857.GF29739@sasha-vm>
From:   Chunyan Zhang <zhang.chunyan@linaro.org>
Date:   Mon, 10 Jun 2019 10:33:51 +0800
Message-ID: <CAG2=9p_6Rk4oUu0hWKdzHNxRg=Hsboz=vYwsmfagmuCHzEKMOg@mail.gmail.com>
Subject: Re: [BACKPORT 4.4.y] PM / sleep: prohibit devices probing during suspend/hibernation
To:     Sasha Levin <sashal@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        stable@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Grygorii Strashko <grygorii.Strashko@ti.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 6 Jun 2019 at 09:08, Sasha Levin <sashal@kernel.org> wrote:
>
> On Wed, Jun 05, 2019 at 07:14:12PM +0800, Chunyan Zhang wrote:
> >From: "Strashko, Grygorii" <grygorii.strashko@ti.com>
> >
> >[ Upstream commit 013c074f8642d8e815ad670601f8e27155a74b57 ]
> >
> >It is unsafe [1] if probing of devices will happen during suspend or
> >hibernation and system behavior will be unpredictable in this case.
> >So, let's prohibit device's probing in dpm_prepare() and defer their
> >probing instead. The normal behavior will be restored in
> >dpm_complete().
> >
> >This patch introduces new DD core APIs:
> > device_block_probing()
> >   It will disable probing of devices and defer their probes instead.
> > device_unblock_probing()
> >   It will restore normal behavior and trigger re-probing of deferred
> >   devices.
> >
> >[1] https://lkml.org/lkml/2015/9/11/554
> >
> >Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >Acked-by: Pavel Machek <pavel@ucw.cz>
> >Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>
> This patch had to be fixed a few times (see 015bb5e134 and 9a2a5a638f8),
> we can't just take it as is.
>
> It might be just simpler to move to a newer kernel at this point.

Thanks for the information and suggestion!

Chunyan

>
> --
> Thanks,
> Sasha