Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 09 Jun 2019 19:55:00 -0700 (PDT)
Message-Id: <20190609.195500.2162257859838379859.davem@davemloft.net>
To:     hariprasad.kelam@gmail.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: nci: fix warning comparison to bool
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190608084154.GA7520@hari-Inspiron-1545>
References: <20190608084154.GA7520@hari-Inspiron-1545>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Date: Sat, 8 Jun 2019 14:11:54 +0530

> Fix below warning reported by coccicheck
> 
> net/nfc/nci/ntf.c:367:5-15: WARNING: Comparison to bool
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
>  net/nfc/nci/ntf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/nfc/nci/ntf.c b/net/nfc/nci/ntf.c
> index 1e8c1a1..81e8570 100644
> --- a/net/nfc/nci/ntf.c
> +++ b/net/nfc/nci/ntf.c
> @@ -364,7 +364,7 @@ static void nci_rf_discover_ntf_packet(struct nci_dev *ndev,
>  	ntf.ntf_type = *data++;
>  	pr_debug("ntf_type %d\n", ntf.ntf_type);
>  
> -	if (add_target == true)
> +	if (add_target)

add_target is a bool, these kinds of changes are not good.