Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jbergsagel@ti.com" <jbergsagel@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
        Suresh Punnoose <sureshp@cadence.com>,
        "peter.chen@nxp.com" <peter.chen@nxp.com>,
        Jayshri Dajiram Pawar <jpawar@cadence.com>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v7 2/6] usb:common Separated decoding functions from dwc3
 driver.
Thread-Topic: [PATCH v7 2/6] usb:common Separated decoding functions from dwc3
 driver.
Thread-Index: AQHVG4YSgPl5e1M+1Ue5XKtVVDFb6qaRyFMAgAKop2A=
Date:   Mon, 10 Jun 2019 06:29:24 +0000
Message-ID: <BYAPR07MB4709C42303D60ABF917E22D0DD130@BYAPR07MB4709.namprd07.prod.outlook.com>
References: <1559729030-16390-1-git-send-email-pawell@cadence.com>
 <1559729030-16390-3-git-send-email-pawell@cadence.com>
 <20190608134008.GB11489@kroah.com>
In-Reply-To: <20190608134008.GB11489@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6218fb84-de09-4a52-9241-08d6ed6cfb21
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2019 06:29:24.3007
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pawell@global.cadence.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5063
X-Proofpoint-SPF-Result: pass
X-Proofpoint-SPF-Record: v=spf1 include:spf.smktg.jp include:_spf.salesforce.com
 include:mktomail.com include:spf-0014ca01.pphosted.com
 include:spf.protection.outlook.com include:auth.msgapp.com
 include:spf.mandrillapp.com ~all
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-10_03:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906100045
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>On Wed, Jun 05, 2019 at 11:03:46AM +0100, Pawel Laszczak wrote:
>
>> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
>
>> to driver/usb/common/debug.c file. These moved functions include:
>
>>     dwc3_decode_get_status
>
>>     dwc3_decode_set_clear_feature
>
>>     dwc3_decode_set_address
>
>>     dwc3_decode_get_set_descriptor
>
>>     dwc3_decode_get_configuration
>
>>     dwc3_decode_set_configuration
>
>>     dwc3_decode_get_intf
>
>>     dwc3_decode_set_intf
>
>>     dwc3_decode_synch_frame
>
>>     dwc3_decode_set_sel
>
>>     dwc3_decode_set_isoch_delay
>
>>     dwc3_decode_ctrl
>
>>
>
>> These functions are used also in inroduced cdns3 driver.
>
>>
>
>> All functions prefixes were changed from dwc3 to usb.
>
>> Also, function's parameters has been extended according to the name
>
>> of fields in standard SETUP packet.
>
>> Additionally, patch adds usb_decode_ctrl function to
>
>> include/linux/usb/ch9.h file.i
>
>>
>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>
>> ---
>
>>  drivers/usb/common/Makefile |   2 +-
>
>>  drivers/usb/common/debug.c  | 273 ++++++++++++++++++++++++++++++++++++
>
>>  drivers/usb/dwc3/debug.h    | 252 ---------------------------------
>
>>  drivers/usb/dwc3/trace.h    |   2 +-
>
>>  include/linux/usb/ch9.h     |  25 ++++
>
>>  5 files changed, 300 insertions(+), 254 deletions(-)
>
>>  create mode 100644 drivers/usb/common/debug.c
>
>>
>
>> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile
>
>> index 0a7c45e85481..02eb01666289 100644
>
>> --- a/drivers/usb/common/Makefile
>
>> +++ b/drivers/usb/common/Makefile
>
>> @@ -4,7 +4,7 @@
>
>>  #
>
>>
>
>>  obj-$(CONFIG_USB_COMMON)	  +=3D usb-common.o
>
>> -usb-common-y			  +=3D common.o
>
>> +usb-common-y			  +=3D common.o debug.o
>
>>  usb-common-$(CONFIG_USB_LED_TRIG) +=3D led.o
>
>>
>
>>  obj-$(CONFIG_USB_OTG_FSM) +=3D usb-otg-fsm.o
>
>> diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c
>
>> new file mode 100644
>
>> index 000000000000..f7218d794aa6
>
>> --- /dev/null
>
>> +++ b/drivers/usb/common/debug.c
>
>> @@ -0,0 +1,273 @@
>
>> +// SPDX-License-Identifier: GPL-2.0
>
>> +/**
>
>> + * Common USB debugging functions
>
>> + *
>
>> + * Copyright (C) 2010-2011 Texas Instruments Incorporated - https://url=
defense.proofpoint.com/v2/url?u=3Dhttp-
>3A__www.ti.com&d=3DDwIBAg&c=3DaUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&=
r=3De1OgxfvkL0qo9XO6fX1gscva-
>w03uSYC1nIyxl89-rI&m=3DhCAftKt20FnC6KiCwNbVrg7WoY-WnCtUjVuast3iJSw&s=3DQ4q=
hFXl4s1P2u0s65WgkulIRgV4KZtGphj7Xjr4t6yA&e=3D
>
>> + *
>
>> + * Authors: Felipe Balbi <balbi@ti.com>,
>
>> + *	    Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
>> + */
>
>> +
>
>> +#ifndef __LINUX_USB_COMMON_DEBUG
>
>> +#define __LINUX_USB_COMMON_DEBUG
>
>
>
>Why are you doing thsi in a .c file?
>
Good question, I don't know :).=20
Was removed=20

Also I remember that you complained about placing it in=20
drivers/usb/common.=20
Currently this file is used only by two drivers dwc3 and cdns3.
Both are USB controller drivers. Maybe it could be better to move it to:
drivers/gadget/udc/debug.c
drivers/gadget/debug.c=20
drivers/gadget/common/debug.c
or
drivers/gadget/debug/debug.c=20

What do you think Roger?=20

Felipe it's also question for you.=20
=20

Thanks,
Pawel

>
>
>thanks,
>
>
>
>greg k-h