Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2899202ybi; Mon, 10 Jun 2019 00:11:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEUbNAyqBTklQccBlAsGj4fkeQV8R+SV09znKqXSqJuLLy1JRQ9UIVVZXgvd6J9W/72Z9y X-Received: by 2002:a63:4a20:: with SMTP id x32mr11448554pga.107.1560150704682; Mon, 10 Jun 2019 00:11:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560150704; cv=none; d=google.com; s=arc-20160816; b=Tp22sJNLpkytCzsh1Yr6DDwu04hTWDo0Ax7LxHH7pVX1BiLYk+8gcnH1cNOhh+9Eta hOkAo3IMRVZfTkjEWohv6a6/axaNx2ZLNQ35zCMFqNPKaUqI1Y+qJ9M0DbDMC93sNHQ0 +XbmjbkydoEkZvsHhvbvq91vRjqBWjDnFNGB9721XR2c+BVghbrk97Fsbc67dKGnAcGv 0fwrKNQS4MaqNczQjcDmI2mJF10PpvU9AC/7D4funWZ6mBPfepIIdMNGqPL7U9pSmKkc qa2d6VwjChyRIC4Sv3WVTV3YsRQVVjddRqwo/eiMZoE7FGbaHHmmRNqTIQe6JT9cl+bb V+Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=q2XsBd2w980XnG8Yqrx9cK6Opd/c3CHdJP7u8nxbH3E=; b=sWM4Comyi06sISZ+c2gsCbLkUer/pIceeRjNKTOE9j9I1NJ1IUlv1yWLLxznEzXL6G Zqadn7NRbeW/gsCwrMMBHTWuNbaoQWZBawglXVpGNiblezf/Q5SnmHaU3FrTadMzKxsi KyGNvfaA5OvhZLpkniT0YRhBkAOOF+t3djpBE9IXU2fv8dM+zXrkPpoYxPv9obQwi2c8 wqaVj9D8S93T41apAfvzC2Nwfd1oaQs+l+bTuijQMPs++XUcx5gyTuvlJsuzbyf1Y5wC YPCTKGRjQp9GaFoj9GEhODOdNuW4T7MmZEmDJ7dFPzFdshq8igeAlkeljc+9uQYvYVvX qgcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10si9355856pgh.273.2019.06.10.00.11.28; Mon, 10 Jun 2019 00:11:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387820AbfFJHKK (ORCPT + 99 others); Mon, 10 Jun 2019 03:10:10 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35624 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387702AbfFJHKK (ORCPT ); Mon, 10 Jun 2019 03:10:10 -0400 Received: by mail-wr1-f67.google.com with SMTP id m3so8002694wrv.2 for ; Mon, 10 Jun 2019 00:10:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=q2XsBd2w980XnG8Yqrx9cK6Opd/c3CHdJP7u8nxbH3E=; b=PBPJLJO5AVZjyi5mftcmn5X8Re0U+qr0EeSe6PB+8Z/fDvWCr/s/0wZKi5aYIE93aM YPGAuZhT4febNR7A7N0+iA5SxHItZvp7IwrvGr5lmjKb3Q/CiekdVgoib79ZCptnn1WW 9ryIF3ptQNDhEscQKEtmRY0ROYt/nw1yTyzrdjtRHk37/KF1QphU495aFVedGTGVHiCd Rty7ZagjFoUua7nuqRWN6rmRv9o1r1Yh8xJE9f7sUyjZkKvFZKUeVZ5wHl7FakdBOC5g +C/fZP5Di9lymHEF6ykWqcHb/VOdT8srmf6D6QWYU9SzsudvkuMw667cNGyEcew2POIg Kf1g== X-Gm-Message-State: APjAAAXwq6NJ2wr90n/Ohf2P7DK0KF30NaNpQTECKrlquP+oppjD+uBT wVZyK+CM1eURUJ1FpVaU91L68sY8 X-Received: by 2002:a5d:4044:: with SMTP id w4mr18392420wrp.171.1560150607820; Mon, 10 Jun 2019 00:10:07 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id f21sm9219333wmb.2.2019.06.10.00.10.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 00:10:06 -0700 (PDT) Subject: Re: [PATCH v3] vt: Fix a missing-check bug in con_init() To: Nicolas Pitre , Greg KH Cc: kilobyte@angband.pl, daniel.vetter@ffwll.ch, Gen Zhang , mpatocka@redhat.com, textshell@uchuujin.de, linux-kernel@vger.kernel.org References: <20190528004529.GA12388@zhanggen-UX430UQ> <20190608160138.GA3840@zhanggen-UX430UQ> <20190608162219.GB11699@kroah.com> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <3f1429f7-99cb-555c-bfe0-b36a8e989ae3@suse.cz> Date: Mon, 10 Jun 2019 09:10:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09. 06. 19, 2:15, Nicolas Pitre wrote: >>>> +fail1: >>>> + while (currcons > 0) { >>>> + currcons--; >>>> + kfree(vc_cons[currcons].d->vc_screenbuf); >>>> +fail2: >>>> + kfree(vc_cons[currcons].d); >>>> + vc_cons[currcons].d = NULL; >>>> + } >> >> Wait, will that even work? You can jump into the middle of a while >> loop? > > Absolutely. In C99, exceptions are only blocks with variable-sized declarations (like "int a[b]"). thanks, -- js suse labs