Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbVKUImz (ORCPT ); Mon, 21 Nov 2005 03:42:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932229AbVKUImz (ORCPT ); Mon, 21 Nov 2005 03:42:55 -0500 Received: from pne-smtpout2-sn2.hy.skanova.net ([81.228.8.164]:57784 "EHLO pne-smtpout2-sn2.hy.skanova.net") by vger.kernel.org with ESMTP id S932227AbVKUImy (ORCPT ); Mon, 21 Nov 2005 03:42:54 -0500 Message-ID: <43818880.8080800@comhem.se> Date: Mon, 21 Nov 2005 09:42:40 +0100 From: =?ISO-8859-1?Q?Daniel_Marjam=E4ki?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030313 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Con Kolivas CC: linux-kernel@vger.kernel.org Subject: Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c) References: <5aZsv-3CJ-17@gated-at.bofh.it> <438180C0.2030503@comhem.se> <200511211919.11429.kernel@kolivas.org> In-Reply-To: <200511211919.11429.kernel@kolivas.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 28 Con Kolivas wrote: > > Convention in the kernel would be > aztTimeOut = HZ / 100 ? : 1; > to be at least one tick (works for HZ even below 100) and is at least 10ms. If > you wanted 2 ms then use > aztTimeOut = HZ / 500 ? : 1; > which would give you at least 2ms > Thank you Con for the feedback. Hmm.. The minimum value should be 2, right? Otherwise the loop could time out after only a few nanoseconds.. since the loop will then timeout immediately on a clock tick. Or am I wrong? Best regards, Daniel Marjam?ki - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/