Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2947252ybi; Mon, 10 Jun 2019 01:18:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqyR7E3lxbyndQ+zZbT6Hh8LWlb8H3lr7C5pqTk6TFBGXiO1RWUh5FzShaMxFModMn27Xk3N X-Received: by 2002:a17:90a:2430:: with SMTP id h45mr20704241pje.14.1560154695774; Mon, 10 Jun 2019 01:18:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560154695; cv=none; d=google.com; s=arc-20160816; b=h5JQHsDqs8BBhgN2j/B+UI7YowR+v0uSyR+oDFb25DDRVLIWSviB8kBGmvNiikH+3T zHjxovAivzqpP/F6ne8uXiZyXhm01/dFFiYRbqre+SuDRF4YGWSulwVQ2XoEgMEEXxVZ Yn3u5TjG8PEvdLPLFL0ufDVNtIYi7XfLZwSIgCqhc7q26TaiZ0loUV5ptU76ASQKrml7 bK2z394FUEC7ddyIuWdMhN1dK00J47+756nLvFTvZUpY1hd4HYaZWk4GC6BMerxqV86t 2qUMQ6mI+4mPcFMTGPrDvy96tEWxqThKlgtGnezNDGkoZLJ5oIhfq75NJe4paxsqgNiJ Fv1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=UhV/EWXPs23DFsfOrFjvSXy9gkm74y794dSR0Kc3mFg=; b=YQUfKx5Dpk4jtCuH2lWMB5hshEfXdZzt27qIlUsQ0PQw62zlLi5oLvL+TMNsj7uU3l oZJhpN42OzRmU9fLD0UauQI6j/JS2UwsPJqGIl167X676PNywMY2DIGZz4cOUCz08dgz Hb5LH1DyhEMYDymOl+OXGdA0518ouEY58Fs4xNSOOT2gWyPbcBvDDyYWUred+f6bxvup aSdrtV51G+y22bP/6a+h/MkCyF22iLPNnisH5Tpx4A+OwVeSFCq2Z4w0CwqnfVS5Knv7 11R5+jocsf1ISUVqqD7bbp03MmDENjmTXzUuZNYyc+7yIbLkgBO5UldeAU/l+93b8gOX CfjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si8726266pgv.128.2019.06.10.01.18.00; Mon, 10 Jun 2019 01:18:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388363AbfFJIQa (ORCPT + 99 others); Mon, 10 Jun 2019 04:16:30 -0400 Received: from inva021.nxp.com ([92.121.34.21]:37316 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387824AbfFJIQ2 (ORCPT ); Mon, 10 Jun 2019 04:16:28 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id BE40D200737; Mon, 10 Jun 2019 10:16:26 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8D47A200739; Mon, 10 Jun 2019 10:16:18 +0200 (CEST) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id E1F70402D2; Mon, 10 Jun 2019 16:16:08 +0800 (SGT) From: yibin.gong@nxp.com To: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, broonie@kernel.org, festevam@gmail.com, vkoul@kernel.org, dan.j.williams@intel.com, u.kleine-koenig@pengutronix.de, catalin.marinas@arm.com, l.stach@pengutronix.de, will.deacon@arm.com Cc: linux-spi@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v5 04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context Date: Mon, 10 Jun 2019 16:17:42 +0800 Message-Id: <20190610081753.11422-5-yibin.gong@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190610081753.11422-1-yibin.gong@nxp.com> References: <20190610081753.11422-1-yibin.gong@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robin Gong Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 21db6b69..dbd1dcd 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1134,7 +1134,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1174,9 +1173,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac, -- 2.7.4