Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3367050ybi; Mon, 10 Jun 2019 09:03:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuzqzfv40iYwOWNZkBZvBHiSJGq+oXQrgg97bcxXyrYkqG9pW3njwydDUNXPQNPguXG9aL X-Received: by 2002:a05:6a00:6:: with SMTP id h6mr10743516pfk.237.1560182627746; Mon, 10 Jun 2019 09:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560182627; cv=none; d=google.com; s=arc-20160816; b=f75mN5hTFFmMDhhhc0EFFY50G8Zg/Zz43anuAogSRk8hOyEJxP0fqqZ428+fdwR5KL bUHXTBLVVhEZMAbgV1uRGgJVY5oLxQZxfzrL0JCdIRlaGhWkl/t6bUqfHAxUi8VplweW ldtNzeH4W5w50bRLI/fICPZq3ZtqIpQ40Zvck0Ll9S1LaNbSymBeG+YU4jyTuIwhbf1M /PXMosXQ1rNEwg35/gY2zj4ry5Ic52yB0adwGP4mEx2oa/88axot3Ccz3DttNO/WfKyg KhtRsbGQk0fhgn7iLQrnnmsx1Ti+izXxXcKHtSGpxwqsCKT1i0bUO6pRbTEUv6MfwVZM CmXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AreI3Oi5t2BK9yZ9fvqJm8n0iuLc5FNcr71UXydQQ4A=; b=A36jDh77psy7CbGVRLx1/HRykbXLz14LDUB4PDKQWuVg0TzfOx0V4AdLTJsmDnpmuJ M6FG0OsRGfs8BIL2iOj3FfSse+7zimK2kQ+/B8pLlOFMTHFdmT1TMsaVYqo4AjCMuE8U GSJvhRRZAdWSJR85GarQWuE5QjDDM3CMMNnvVa5mlFLKcOJ2t9U9TEK226PCoCXMisyx 7P5WKhgXpdlDAD9dNPcxxtZsyo0hiYoaF2v1qLhlrK/KDhdzYuKCcGYkWIPATzpCJ/05 7bBI4V7R02Tqsnj85fiqToH5Ner1h+5u8Eu1eFCzqlTDNEumZcqhcVNfQfc0/GX0i/BI OrJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=IQNJubjf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f91si10687767plf.300.2019.06.10.09.03.28; Mon, 10 Jun 2019 09:03:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=IQNJubjf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389895AbfFJOf6 (ORCPT + 99 others); Mon, 10 Jun 2019 10:35:58 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:47282 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389575AbfFJOf6 (ORCPT ); Mon, 10 Jun 2019 10:35:58 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5AETNbi096395; Mon, 10 Jun 2019 14:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=AreI3Oi5t2BK9yZ9fvqJm8n0iuLc5FNcr71UXydQQ4A=; b=IQNJubjfwEeOewYwiDKlbW98yCxrRZxsg8eJ286mCQaJbD4mAofdKhmBiR4RhF2dZUEk TICkZvpOPCcleI+we1ow+JbbOmjINiMV2X5rCDRtnughpjq/kGhVUfQ8VqCpNs9oPOV4 j21bGybX5KyQCvGZixli/KpymHd9vC0p2ODpdq7xyGTeHEKQ6sYGX6J+0J12afwOu6o4 1I/7I/mW7bnBv5+iw0Jp81ayCbnc5CU+FFtIchtPJ+e+IVzLNCdAyEyTSqAGrgIKu9Y6 ia/0/7RqwpIM5FPH9/LBsEJuSPpQ+yu4RrPdXNU2Kx+D5TGNypsZ9vykvRXlU0sr95Ct zA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2t04etfaqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jun 2019 14:35:46 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5AEWjsM157789; Mon, 10 Jun 2019 14:33:46 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2t1jpgwam6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jun 2019 14:33:46 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5AEXiea023021; Mon, 10 Jun 2019 14:33:44 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Jun 2019 07:33:43 -0700 Date: Mon, 10 Jun 2019 17:33:33 +0300 From: Dan Carpenter To: Nishka Dasgupta Cc: devel@driverdev.osuosl.org, valdis.kletnieks@vt.edu, florian.c.schilhabel@googlemail.com, tiny.windzz@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, colin.king@canonical.com, larry.finger@lwfinger.net Subject: Re: [PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change Message-ID: <20190610143333.GA1915@kadam> References: <20190607140658.11932-1-nishkadg.linux@gmail.com> <20190607141548.GP31203@kadam> <98b587c9-df5b-0905-ab8f-69a4bae296b0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98b587c9-df5b-0905-ab8f-69a4bae296b0@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=563 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906100101 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=611 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906100101 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 10, 2019 at 10:02:27AM +0530, Nishka Dasgupta wrote: > On 07/06/19 7:45 PM, Dan Carpenter wrote: > > Probably you sent this patch unintentionally. The subject doesn't make > > any sort of sense. :P > > So the problem with the subject line is that git send-email and vim (as > configured on my laptop) tend to line-wrap even the subject line. Since I > have two patches that do the same thing for different functions, I felt I > should have the driver and the function name in the subject line (to avoid > confusion between the patches and to allow for easy searching later). But > that doesn't leave enough space in the subject line for "Change return > values/type" or any other descriptive message. What should I do? > I don't really care. [PATCH] staging: rtl8712: clean up r8712_setdatarate_cmd() return type regards, dan carpenter