Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3400848ybi; Mon, 10 Jun 2019 09:37:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuArjBV+4r3T2BZEnEuSx0diYRsvMXl4ahyNBYiCMQzRobVR8aHwPFZEf3kgB1+2D5eL5a X-Received: by 2002:a65:6495:: with SMTP id e21mr2327728pgv.383.1560184620766; Mon, 10 Jun 2019 09:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560184620; cv=none; d=google.com; s=arc-20160816; b=MIw0juEUr0Hdr92Sf7uNgYgmLBmN1k81qZtF9XaARhhehQ64WtamV/12f6qDAGsuvZ 0dD3J18AKD2jAQ+URUUKsXXV623+uhK+lm2OuhNLv3fmC6pekDLeipnzyG3QX+d//Ua6 63YDkqNRDyHb0/6VeWemfiKzPhhR/6GE4bIHExxxeUG6Yt5LIobG1tLynNKSzFSa4+V1 WcS79ZT7gso99QQguSEMvd5KVjfrlyifpzobVC7bve5cgIIqZ6wGJaDB5mqhaV1cEuRN IkiaOUhsEz0YrnBN7Ig2WG13hzVfKHJNZDeNCP3RhPnXHryN9+BljyEdhRTvBFRnthcw Cybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=oGLJlVxzjq+vNu5xHCvx3NTa7I1fESflTcF1JsMPMeU=; b=tmYeXqE010hjTgOiOvaPNC4uS+8ht5F3gL7DPrpl5RtAsw1c95RjOH0wjSMaTDlYth hCrqbEtjRv1kSmVnDr6OwqP1vPLwhJdeiKHaEcEWgU/n3qUv+DWkT9X1nAeiLTMPZnTI 5mKCAaPB1jKf3Ue1YjHdkAd1jNp6I6Vv3r4X9bhoSQpyu5Lhqz5qv/ZlGv654TBgCaty PO5tJWwb3re8DEU+nQp54p1NRJnPnNd7rTYNQMAFsgwYW0ZCfJ09slYWoru6IqeFdNkI GEKBbp4GdOLUEpu48W4ImGdyYElJj5t2zHH+nV6BsBjejYLx9YPGOQEr9tUslHxuKtXz 1zTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dRox7VQ0; dkim=pass header.i=@codeaurora.org header.s=default header.b=GaUQuf0o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s2si10076996pgp.566.2019.06.10.09.36.46; Mon, 10 Jun 2019 09:37:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dRox7VQ0; dkim=pass header.i=@codeaurora.org header.s=default header.b=GaUQuf0o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390452AbfFJPpf (ORCPT + 99 others); Mon, 10 Jun 2019 11:45:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50680 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390230AbfFJPpe (ORCPT ); Mon, 10 Jun 2019 11:45:34 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1D61E60275; Mon, 10 Jun 2019 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560181533; bh=JLkeq82w7WKXfiw+H9jdcNpXmDI145eAKRmA3feEAeU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dRox7VQ03BzZZt9n8e+czaNKqicjCTGoyPmgb67fOXCWu/nR53/Y6L2K7XCASG4gg jUy8yVAaIa0ovVh1xSkdUfzhLy6ZOP7ZfA1tNlAggiZUkRxut8qGbviLXTJmJKVhpz IcfpvVxsLWNXQ9ST+JNpHd98DVySeQEoLc8bkhM0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.6] (unknown [171.60.244.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C24C060213; Mon, 10 Jun 2019 15:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560181531; bh=JLkeq82w7WKXfiw+H9jdcNpXmDI145eAKRmA3feEAeU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GaUQuf0o1Jem/Hq3U+CRNQ6OcnLIbVZ8RBw9wb66XqGcfQn/AITy8H6QhXQAN481x gZ4FtBh6v7xiE1qfAFm+yfbVCpFh0Ih4gl83bY2U5R1wQelXVlY35ZPJ0qrJmF488p 2E1LyMUyZJ2nj/kD6z1eVWa3eVPMo/90g+PIKbvs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C24C060213 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support To: Bjorn Andersson Cc: robh+dt@kernel.org, sboyd@codeaurora.org, linus.walleij@linaro.org, agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-6-git-send-email-sricharan@codeaurora.org> <20190608034835.GH24059@builder> From: Sricharan R Message-ID: <048a25c0-3a2c-3906-84d4-5eb67f3ce2ef@codeaurora.org> Date: Mon, 10 Jun 2019 21:15:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190608034835.GH24059@builder> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> Add initial device tree support for the Qualcomm IPQ6018 SoC and >> CP01 evaluation board. >> >> Signed-off-by: Sricharan R >> Signed-off-by: Abhishek Sahu > > Please fix the order of these (or add a Co-developed-by). > ok >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 35 ++++ >> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 231 +++++++++++++++++++++++++++ >> 3 files changed, 267 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 21d548f..ac22dbb 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -2,6 +2,7 @@ >> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb > > Sort order. > ok >> dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8992-bullhead-rev-101.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8994-angler-rev-101.dtb >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> new file mode 100644 >> index 0000000..ac7cb22 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts >> @@ -0,0 +1,35 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * IPQ6018 CP01 board device tree source >> + * >> + * Copyright (c) 2019, The Linux Foundation. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "ipq6018.dtsi" >> + >> +/ { >> + #address-cells = <0x2>; >> + #size-cells = <0x2>; > > This is a count, write it in base 10.. > ok >> + model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1"; >> + compatible = "qcom,ipq6018-cp01", "qcom,ipq6018"; >> + interrupt-parent = <&intc>; > > Changing #address-cells, #size-cells and interrupt-parent will break the > dtsi, so I think you should specify them there. > ok, will move it to the dtsi. >> +}; >> + >> +&tlmm { > > Please sort your nodes based on address, then node name, then label. > ok >> + uart_pins: uart_pins { >> + mux { >> + pins = "gpio44", "gpio45"; >> + function = "blsp2_uart"; >> + drive-strength = <8>; >> + bias-pull-down; >> + }; >> + }; >> +}; >> + >> +&blsp1_uart3 { >> + pinctrl-0 = <&uart_pins>; >> + pinctrl-names = "default"; >> + status = "ok"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> new file mode 100644 >> index 0000000..79cccdd >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> @@ -0,0 +1,231 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * IPQ6018 SoC device tree source >> + * >> + * Copyright (c) 2019, The Linux Foundation. All rights reserved. >> + */ >> + >> +#include >> +#include >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ6018"; >> + compatible = "qcom,ipq6018"; > > No need for model and compatible in the dtsi, these should always be > specified by the including file. > ok, will move it to the dts. >> + >> + chosen { >> + bootargs = "console=ttyMSM0,115200,n8 rw init=/init"; > > Do you really need console? Can't you use stdout-path? > ok, will change. > And there's no need to specify init=/init. > ok. >> + bootargs-append = " swiotlb=1 clk_ignore_unused"; > > I'm hoping that you will work on removing the need for > clk_ignore_unused. > hmm, should not be required even now. will remove that. >> + }; >> + >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + tz:tz@48500000 { > > Space after : > ok. >> + no-map; >> + reg = <0x0 0x48500000 0x0 0x00200000>; > > I would prefer to have the reg first in these nodes, then the region's > properties. > ok. >> + }; >> + }; >> + >> + soc: soc { >> + #address-cells = <0x1>; >> + #size-cells = <0x1>; >> + ranges = <0 0 0 0xffffffff>; >> + dma-ranges; >> + compatible = "simple-bus"; >> + >> + intc: interrupt-controller@b000000 { > > As described above, please sort your nodes based on address, node name > and lastly label name. > ok. >> + compatible = "qcom,msm-qgic2"; >> + interrupt-controller; >> + #interrupt-cells = <0x3>; >> + reg = <0xb000000 0x1000>, <0xb002000 0x1000>; >> + }; >> + >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = , >> + , >> + , >> + ; >> + }; >> + >> + timer@b120000 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + compatible = "arm,armv7-timer-mem"; >> + reg = <0xb120000 0x1000>; > > Please pad addresses in reg to 8 digits, to make them faster to compare. > ok. >> + clock-frequency = <19200000>; >> + >> + frame@b120000 { >> + frame-number = <0>; >> + interrupts = , >> + ; >> + reg = <0xb121000 0x1000>, >> + <0xb122000 0x1000>; >> + }; >> + >> + frame@b123000 { >> + frame-number = <1>; >> + interrupts = ; >> + reg = <0xb123000 0x1000>; >> + status = "disabled"; >> + }; >> + >> + frame@b124000 { >> + frame-number = <2>; >> + interrupts = ; >> + reg = <0xb124000 0x1000>; >> + status = "disabled"; >> + }; >> + >> + frame@b125000 { >> + frame-number = <3>; >> + interrupts = ; >> + reg = <0xb125000 0x1000>; >> + status = "disabled"; >> + }; >> + >> + frame@b126000 { >> + frame-number = <4>; >> + interrupts = ; >> + reg = <0xb126000 0x1000>; >> + status = "disabled"; >> + }; >> + >> + frame@b127000 { >> + frame-number = <5>; >> + interrupts = ; >> + reg = <0xb127000 0x1000>; >> + status = "disabled"; >> + }; >> + >> + frame@b128000 { >> + frame-number = <6>; >> + interrupts = ; >> + reg = <0xb128000 0x1000>; >> + status = "disabled"; >> + }; >> + }; >> + >> + gcc: gcc@1800000 { >> + compatible = "qcom,gcc-ipq6018"; >> + reg = <0x1800000 0x80000>; >> + #clock-cells = <0x1>; > > This is a count, use base 10. > ok. >> + #reset-cells = <0x1>; >> + }; >> + >> + blsp1_uart3: serial@78b1000 { >> + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; >> + reg = <0x78b1000 0x200>; >> + interrupts = ; >> + clocks = <&gcc GCC_BLSP1_UART3_APPS_CLK>, >> + <&gcc GCC_BLSP1_AHB_CLK>; >> + clock-names = "core", "iface"; >> + status = "disabled"; >> + }; >> + >> + tlmm: pinctrl@1000000 { >> + compatible = "qcom,ipq6018-pinctrl"; >> + reg = <0x1000000 0x300000>; >> + interrupts = ; >> + gpio-controller; >> + #gpio-cells = <0x2>; > > gpio-ranges = <&tlmm 0 80>; > ok. >> + interrupt-controller; >> + #interrupt-cells = <0x2>; >> + >> + uart_pins: uart_pins { >> + pins = "gpio44", "gpio45"; >> + function = "blsp2_uart"; >> + drive-strength = <8>; >> + bias-pull-down; >> + }; >> + }; >> + }; >> + >> + psci: psci { >> + compatible = "arm,psci-1.0"; >> + method = "smc"; >> + }; >> + >> + cpus: cpus { >> + #address-cells = <0x1>; >> + #size-cells = <0x0>; >> + >> + CPU0: cpu@0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53"; >> + reg = <0x0>; >> + enable-method = "psci"; >> + next-level-cache = <&L2_0>; >> + }; >> + >> + CPU1: cpu@1 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53"; >> + enable-method = "psci"; >> + reg = <0x1>; >> + next-level-cache = <&L2_0>; >> + }; >> + >> + CPU2: cpu@2 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53"; >> + enable-method = "psci"; >> + reg = <0x2>; >> + next-level-cache = <&L2_0>; >> + }; >> + >> + CPU3: cpu@3 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53"; >> + enable-method = "psci"; >> + reg = <0x3>; >> + next-level-cache = <&L2_0>; >> + }; >> + >> + L2_0: l2-cache { >> + compatible = "cache"; >> + cache-level = <0x2>; >> + }; >> + }; >> + >> + pmuv8: pmu { >> + compatible = "arm,armv8-pmuv3"; >> + interrupts = > + IRQ_TYPE_LEVEL_HIGH)>; >> + }; >> + >> + clocks { >> + sleep_clk: sleep_clk { > > Don't use _ in the node names. > ok. >> + compatible = "fixed-clock"; >> + clock-frequency = <32000>; >> + #clock-cells = <0>; >> + }; >> + >> + xo: xo { >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + #clock-cells = <0>; >> + }; >> + >> + bias_pll_cc_clk { > > Please give this a label and reference it from the node that uses it > (regardless of the implementation matching by clock name). > ok, in that case, so might have to remove these for now, till we add the corresponding users. >> + compatible = "fixed-clock"; >> + clock-frequency = <300000000>; >> + #clock-cells = <0>; >> + }; >> + >> + bias_pll_nss_noc_clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <416500000>; >> + #clock-cells = <0>; >> + }; >> + >> + usb3phy_0_cc_pipe_clk { > > This should come from the PHY. ok, will remove it here and add it later when adding USB node Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation