Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Salil Mehta <salil.mehta@huawei.com>
To:     xuechaojing <xuechaojing@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Luoshaokai (luoshaokai)" <luoshaokai@huawei.com>,
        "Wangxiaoyun (Cloud, Network Chip Application Development Dept)" 
        <cloud.wangxiaoyun@huawei.com>,
        xuechaojing <xuechaojing@huawei.com>,
        chiqijun <chiqijun@huawei.com>, "wulike (A)" <wulike1@huawei.com>
Subject: RE: [PATCH net-next 1/2] hinic: add rss support
Thread-Topic: [PATCH net-next 1/2] hinic: add rss support
Thread-Index: AQHVH39GZfVwWAWVqkmdo9ZxQyX0SKaVDyNg
Date:   Mon, 10 Jun 2019 16:13:48 +0000
Message-ID: <b2ddfca5c5c643368f05820b0d077bd2@huawei.com>
References: <20190610033455.9405-1-xuechaojing@huawei.com>
In-Reply-To: <20190610033455.9405-1-xuechaojing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Xue Chaojing
> Sent: Monday, June 10, 2019 4:35 AM
> To: davem@davemloft.net
> Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; Luoshaokai
> (luoshaokai) <luoshaokai@huawei.com>; Wangxiaoyun (Cloud, Network Chip
> Application Development Dept) <cloud.wangxiaoyun@huawei.com>;
> xuechaojing <xuechaojing@huawei.com>; chiqijun <chiqijun@huawei.com>;
> wulike (A) <wulike1@huawei.com>
> Subject: [PATCH net-next 1/2] hinic: add rss support
> 
> This patch adds rss support for the HINIC driver.
> 
> Signed-off-by: Xue Chaojing <xuechaojing@huawei.com>
> ---

[...]

> +
> +int hinic_set_rss_type(struct hinic_dev *nic_dev, u32 tmpl_idx,
> +		       struct hinic_rss_type rss_type)
> +{
> +	struct hinic_hwdev *hwdev = nic_dev->hwdev;
> +	struct hinic_func_to_io *func_to_io = &hwdev->func_to_io;
> +	struct hinic_hwif *hwif = hwdev->hwif;
> +	struct hinic_rss_context_tbl *ctx_tbl;
> +	struct pci_dev *pdev = hwif->pdev;
> +	struct hinic_cmdq_buf cmd_buf;
> +	u64 out_param;
> +	u32 ctx = 0;
> +	int err;


reverse Christmas tree order in defining local variables everywhere?