Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3409289ybi; Mon, 10 Jun 2019 09:46:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAuL5Z0+2HuG+kXRYz6HMmkgYFkZVbQU3FWrEydJ05woJIepTfJRasriClGF5lBEXYSXwu X-Received: by 2002:a17:90a:206a:: with SMTP id n97mr22186726pjc.10.1560185186715; Mon, 10 Jun 2019 09:46:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560185186; cv=none; d=google.com; s=arc-20160816; b=Ve1UQ0qcFahzNJJxmlEJ3tzQXS+h6Ca7QC3YEXlpWUnnsAEryAb0xXSRBKsl/uk6CE DAPlZ722QwBpH2lsF30+t6mymw9kqiEY0duR/ystB0nPT12nBZ3+vaF8HdXBi15+c19o j7/MFNXexAr06OyzMVTnFOcYZxEC2vX2um5D5vl57EKnRxhLIo7Pwum6E2qVwrUHSKgE YewAUIg0+QoWzZ6BwDomc0XExvxR4AGvcKploYHkbLVjkPAVnTsBgwZFGC0UkZfsO2Fk lLLyyamdhhs965XQM1/452OLZnDzDShdEd+ZrfMgdknP+2a8PDxb5XrRAAFkqUyWWtd5 dLhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=Yt/lkJd3w2vaBAUFBYZSUFBTrgR0VJd06wYUrbF44mg=; b=aCop/VRE5HN8R6DS3DcPayzHLK1pKdvDbJshjK3NIpP7eI0a43g1XXCDcR64pfJWDe Az+4fGYhlugVVwE4CLab/0LSEcf7B4tsjhzZbjt+3yDVKpnfqL1hi+PY76urHlLvDeTS 7S4TnRqyLoWMsUwZzGvEkne+McmHPyX+0/mbF4AkdFViSnLHJVpA/BOq38DXF5NK779p ze1hwGfBexGq45z6xVAU8DQ49gj/UBo0rdsKhuO0K/ToHT8Dub4DFjtO6rAzRv2q5oY5 pCtdr/Fzbe2dlF/UuxyJAuwTlxdSiY13wCWctxNo4WPdBEsXwwGHtSRPAOeljoKQuGJC Yhpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@akamai.com header.s=jan2016.eng header.b=pOA2GPAS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id go16si2241099plb.292.2019.06.10.09.46.11; Mon, 10 Jun 2019 09:46:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@akamai.com header.s=jan2016.eng header.b=pOA2GPAS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387414AbfFJQps (ORCPT + 99 others); Mon, 10 Jun 2019 12:45:48 -0400 Received: from mx0a-00190b01.pphosted.com ([67.231.149.131]:37116 "EHLO mx0a-00190b01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728046AbfFJQpq (ORCPT ); Mon, 10 Jun 2019 12:45:46 -0400 Received: from pps.filterd (m0122332.ppops.net [127.0.0.1]) by mx0a-00190b01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5AGWNqm001453; Mon, 10 Jun 2019 17:45:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=Yt/lkJd3w2vaBAUFBYZSUFBTrgR0VJd06wYUrbF44mg=; b=pOA2GPASCNZeulBXCg6fGF2xsNscHHhaget+tu8rg0J4OvXmt3RZABMXCudikizhMUfp YW1Pd+dwMxz7uA/q6an9WUGwcoAtdRb301wVvx5tMyVo154xtMJTzBZt4NtYACVWXeVv Mw8oPULVnWPB8l9XQkeeLnxSr2MI0Ts1A8r/U2TZQ49DYyOoN09NgGboI23HqY9x6FSM KhMaZHvQdGwlXXKYOX5a1HVDPqlzx6mjPv+H+xMQ00zrKunWz1QhffMnxMiuPBKfaVH/ 5nG/nE3Ajn3cNhf1hFac99kgfdew8QpRN1Jjh9y8j3GAKDkKDPGCLbC4usW1MmOI8JA4 Hw== Received: from prod-mail-ppoint2 (prod-mail-ppoint2.akamai.com [184.51.33.19] (may be forged)) by mx0a-00190b01.pphosted.com with ESMTP id 2t1q0m0rkp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jun 2019 17:45:04 +0100 Received: from pps.filterd (prod-mail-ppoint2.akamai.com [127.0.0.1]) by prod-mail-ppoint2.akamai.com (8.16.0.27/8.16.0.27) with SMTP id x5AGW6A0019341; Mon, 10 Jun 2019 12:45:03 -0400 Received: from prod-mail-relay14.akamai.com ([172.27.17.39]) by prod-mail-ppoint2.akamai.com with ESMTP id 2t08bw13vd-1; Mon, 10 Jun 2019 12:45:02 -0400 Received: from [172.29.170.83] (bos-lpjec.kendall.corp.akamai.com [172.29.170.83]) by prod-mail-relay14.akamai.com (Postfix) with ESMTP id 8896D80D1A; Mon, 10 Jun 2019 16:45:01 +0000 (GMT) Subject: Re: [PATCH net-next] tcp: Make tcp_fastopen_alloc_ctx static To: YueHaibing , edumazet@google.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20190610151908.23116-1-yuehaibing@huawei.com> From: Jason Baron Openpgp: preference=signencrypt Autocrypt: addr=jbaron@akamai.com; prefer-encrypt=mutual; keydata= xsFNBFnyIJMBEADamFSO/WCelO/HZTSNbJ1YU9uoEUwmypV2TvyrTrXULcAlH1sXVHS3pNdR I/koZ1V7Ruew5HJC4K9Z5Fuw/RHYWcnQz2X+dSL6rX3BwRZEngjA4r/GDi0EqIdQeQQWCAgT VLWnIenNgmEDCoFQjFny5NMNL+i8SA6hPPRdNjxDowDhbFnkuVUBp1DBqPjHpXMzf3UYsZZx rxNY5YKFNLCpQb1cZNsR2KXZYDKUVALN3jvjPYReWkqRptOSQnvfErikwXRgCTasWtowZ4cu hJFSM5Asr/WN9Wy6oPYObI4yw+KiiWxiAQrfiQVe7fwznStaYxZ2gZmlSPG/Y2/PyoCWYbNZ mJ/7TyED5MTt22R7dqcmrvko0LIpctZqHBrWnLTBtFXZPSne49qGbjzzHywZ0OqZy9nqdUFA ZH+DALipwVFnErjEjFFRiwCWdBNpIgRrHd2bomlyB5ZPiavoHprgsV5ZJNal6fYvvgCik77u 6QgE4MWfhf3i9A8Dtyf8EKQ62AXQt4DQ0BRwhcOW5qEXIcKj33YplyHX2rdOrD8J07graX2Q 2VsRedNiRnOgcTx5Zl3KARHSHEozpHqh7SsthoP2yVo4A3G2DYOwirLcYSCwcrHe9pUEDhWF bxdyyESSm/ysAVjvENsdcreWJqafZTlfdOCE+S5fvC7BGgZu7QARAQABzR9KYXNvbiBCYXJv biA8amJhcm9uQGFrYW1haS5jb20+wsF+BBMBAgAoBQJZ8iCTAhsDBQkJZgGABgsJCAcDAgYV CAIJCgsEFgIDAQIeAQIXgAAKCRC4s7mct4u0M9E0EADBxyL30W9HnVs3x7umqUbl+uBqbBIS GIvRdMDIJXX+EEA6c82ElV2cCOS7dvE3ssG1jRR7g3omW7qEeLdy/iQiJ/qGNdcf0JWHYpmS ThZP3etrl5n7FwLm+51GPqD0046HUdoVshRs10qERDo+qnvMtTdXsfk8uoQ5lyTSvgX4s1H1 ppN1BfkG10epsAtjOJJlBoV9e92vnVRIUTnDeTVXfK11+hT5hjBxxs7uS46wVbwPuPjMlbSa ifLnt7Jz590rtzkeGrUoM5SKRL4DVZYNoAVFp/ik1fe53Wr5GJZEgDC3SNGS/u+IEzEGCytj gejvv6KDs3KcTVSp9oJ4EIZRmX6amG3dksXa4W2GEQJfPfV5+/FR8IOg42pz9RpcET32AL1n GxWzY4FokZB0G6eJ4h53DNx39/zaGX1i0cH+EkyZpfgvFlBWkS58JRFrgY25qhPZiySRLe0R TkUcQdqdK77XDJN5zmUP5xJgF488dGKy58DcTmLoaBTwuCnX2OF+xFS4bCHJy93CluyudOKs e4CUCWaZ2SsrMRuAepypdnuYf3DjP4DpEwBeLznqih4hMv5/4E/jMy1ZMdT+Q8Qz/9pjEuVF Yz2AXF83Fqi45ILNlwRjCjdmG9oJRJ+Yusn3A8EbCtsi2g443dKBzhFcmdA28m6MN9RPNAVS ucz3Oc7BTQRZ8iCTARAA2uvxdOFjeuOIpayvoMDFJ0v94y4xYdYGdtiaqnrv01eOac8msBKy 4WRNQ2vZeoilcrPxLf2eRAfsA4dx8Q8kOPvVqDc8UX6ttlHcnwxkH2X4XpJJliA6jx29kBOc oQOeL9R8c3CWL36dYbosZZwHwY5Jjs7R6TJHx1FlF9mOGIPxIx3B5SuJLsm+/WPZW1td7hS0 Alt4Yp8XWW8a/X765g3OikdmvnJryTo1s7bojmwBCtu1TvT0NrX5AJId4fELlCTFSjr+J3Up MnmkTSyovPkj8KcvBU1JWVvMnkieqrhHOmf2qdNMm61LGNG8VZQBVDMRg2szB79p54DyD+qb gTi8yb0MFqNvXGRnU/TZmLlxblHA4YLMAuLlJ3Y8Qlw5fJ7F2U1Xh6Z6m6YCajtsIF1VkUhI G2dSAigYpe6wU71Faq1KHp9C9VsxlnSR1rc4JOdj9pMoppzkjCphyX3eV9eRcfm4TItTNTGJ 7DAUQHYS3BVy1fwyuSDIJU/Jrg7WWCEzZkS4sNcBz0/GajYFM7Swybn/VTLtCiioThw4OQIw 9Afb+3sB9WR86B7N7sSUTvUArknkNDFefTJJLMzEboRMJBWzpR5OAyLxCWwVSQtPp0IdiIC2 KGF3QXccv/Q9UkI38mWvkilr3EWAOJnPgGCM/521axcyWqXsqNtIxpUAEQEAAcLBZQQYAQIA DwUCWfIgkwIbDAUJCWYBgAAKCRC4s7mct4u0M+AsD/47Q9Gi+HmLyqmaaLBzuI3mmU4vDn+f 50A/U9GSVTU/sAN83i1knpv1lmfG2DgjLXslU+NUnzwFMLI3QsXD3Xx/hmdGQnZi9oNpTMVp tG5hE6EBPsT0BM6NGbghBsymc827LhfYICiahOR/iv2yv6nucKGBM51C3A15P8JgfJcngEnM fCKRuQKWbRDPC9dEK9EBglUYoNPVNL7AWJWKAbVQyCCsJzLBgh9jIfmZ9GClu8Sxi0vu/PpA DSDSJuc9wk+m5mczzzwd4Y6ly9+iyk/CLNtqjT4sRMMV0TCl8ichxlrdt9rqltk22HXRF7ng txomp7T/zRJAqhH/EXWI6CXJPp4wpMUjEUd1B2+s1xKypq//tChF+HfUU4zXUyEXY8nHl6lk hFjW/geTcf6+i6mKaxGY4oxuIjF1s2Ak4J3viSeYfTDBH/fgUzOGI5siBhHWvtVzhQKHfOxg i8t1q09MJY6je8l8DLEIWTHXXDGnk+ndPG3foBucukRqoTv6AOY49zjrt6r++sujjkE4ax8i ClKvS0n+XyZUpHFwvwjSKc+UV1Q22BxyH4jRd1paCrYYurjNG5guGcDDa51jIz69rj6Q/4S9 Pizgg49wQXuci1kcC1YKjV2nqPC4ybeT6z/EuYTGPETKaegxN46vRVoE2RXwlVk+vmadVJlG JeQ7iQ== Message-ID: <33682081-78aa-a332-52c6-b1b6087e60dc@akamai.com> Date: Mon, 10 Jun 2019 12:43:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190610151908.23116-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-10_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906100112 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-10_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906100113 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/10/19 11:19 AM, YueHaibing wrote: > Fix sparse warning: > > net/ipv4/tcp_fastopen.c:75:29: warning: > symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > net/ipv4/tcp_fastopen.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c > index 8e15804..7d19fa4 100644 > --- a/net/ipv4/tcp_fastopen.c > +++ b/net/ipv4/tcp_fastopen.c > @@ -72,9 +72,9 @@ void tcp_fastopen_ctx_destroy(struct net *net) > call_rcu(&ctxt->rcu, tcp_fastopen_ctx_free); > } > > -struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key, > - void *backup_key, > - unsigned int len) > +static struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key, > + void *backup_key, > + unsigned int len) > { > struct tcp_fastopen_context *new_ctx; > void *key = primary_key; > Thanks for fixing. Acked-by: Jason Baron