Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3428947ybi; Mon, 10 Jun 2019 10:06:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwu7275MX4/BJhCWPv6dDMnx9gWsDAvaEtrGAkViy4ldxTLQZFE7SxTFCWaLwkEsxA97ELq X-Received: by 2002:a17:90a:a404:: with SMTP id y4mr11237113pjp.58.1560186392684; Mon, 10 Jun 2019 10:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560186392; cv=none; d=google.com; s=arc-20160816; b=QPdhyUXb/laqNryMTN8owROH+5AkNeImtRL1/boDAitq+YEDgwQungSAiRstUOtdbI kGxaUialGrj4gCJ9/w2p3lx+k/3MN8kflJ2/Li8vG431z4HyZwb4CFH1LUN3IW/Xs+y3 vjHFq/NMJ5h4gB3/Y60Fc1c4WkpApZSet1axf8YyYJ69pIyI8mZpeWcoYRDTt3xfNfDV zC2K/H473ZU8hQhhN+oskzpVm1yWooQgeQDiaFVYTV9r8+04C51A8gbWXjvJVdjhedQp iEr7rEOGleinjBaTZ27EdyXnRLcg7BLWfCglJ0Z2RrwJOKNUppz008SIsHA9pg+N+WKk AD3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7+VuGn+FYj+PD3hMoT9ZDCL2h6tUT9L1iL/M7yTwI7M=; b=U40WogQvWqVSQTEYOdVJrNwLRlGsEIIwT7K8cGQbvIWnS8S9ToKg2gQM2wrUU5RSYe DETfTqA46pgmMPAbDOL7QU2r0W/Lqdsz7c2M7B1Ly8gr5krubI98XWXfGa8hm4muzs1U WRZXHYa3AVocVE1qrkQcTgra0oUS2Ac5Gj3+4KYycROnlQMwJxFydnMqDTuZzURWfBBt ZhW9hL2CzGJhtCMJX2ReUgXn3JZOxVI8IBzEsp/14pSBot1f45FdjhfCMxwYHHnR5pf/ qCSAxIre0BaEzXsN9CJsv823ib+ZcL/Cms39ryxjF6LQ+a7kZUoCAGozLvd+UFtsx3Oh 64dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cMNq70Z1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k9si1605078pfh.56.2019.06.10.10.06.17; Mon, 10 Jun 2019 10:06:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cMNq70Z1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387773AbfFJRFk (ORCPT + 99 others); Mon, 10 Jun 2019 13:05:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:40586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387700AbfFJRFi (ORCPT ); Mon, 10 Jun 2019 13:05:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FD2320859; Mon, 10 Jun 2019 17:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560186337; bh=0e6VWkn4pFkRWeDtcNEBzkCkDCOUxaKPtfD9spYSbxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cMNq70Z1quBlDjxaurESKu0EdVtwczelGR2fmVJAVi8yaqz1wW9AL/fVDp8/DdZKF PBFCaY5S+eJ4z7WDDcP9wMlEswKfyO0TLToCfTQItpghsAuLkHcyyQTj4coIY4wdjg EPmOLtJzOSJfD3bzRqi5jV9IoQ6uvhtzVvDpG/Xc= Date: Mon, 10 Jun 2019 19:05:35 +0200 From: Greg KH To: Jorge Ramirez-Ortiz Cc: agross@kernel.org, david.brown@linaro.org, jslaby@suse.com, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org, bjorn.andersson@linaro.org Subject: Re: [PATCH v2] tty: serial: msm_serial: avoid system lockup condition Message-ID: <20190610170535.GA1337@kroah.com> References: <20190610075554.24979-1-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610075554.24979-1-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 10, 2019 at 09:55:54AM +0200, Jorge Ramirez-Ortiz wrote: > The function msm_wait_for_xmitr can be taken with interrupts > disabled. In order to avoid a potential system lockup - demonstrated > under stress testing conditions on SoC QCS404/5 - make sure we wait > for a bounded amount of time. > > Tested on SoC QCS404. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > drivers/tty/serial/msm_serial.c | 4 ++++ > 1 file changed, 4 insertions(+) What changed from v1? Always put that below the --- line. v3 please. thanks, greg k-h