Received: by 2002:a17:90a:37a3:0:0:0:0 with SMTP id v32csp4100307pjb; Mon, 10 Jun 2019 10:26:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtFA136j5mybotrqTPtiFm6TzZWHh0McGYY42+sCz2RdqFE3IGZzcbCrnhYc8pr3QlNXxv X-Received: by 2002:a17:902:a411:: with SMTP id p17mr12267842plq.104.1560187566054; Mon, 10 Jun 2019 10:26:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560187566; cv=none; d=google.com; s=arc-20160816; b=dIKbgjsnRZODpRcGVtW3AffidqkW7HujDkurMlJN8JPA2pnkIsajhpss8/miPfI+dW jduH0tsWoSvD6RYtps6qARyVYPlttgKfwCsUM23pPnSYC5ctvyXv+K4UuiqnYfeiM2+R ZgDl3rnpRhP0JQkC0b4HQuNgeHLX04L0OtQ71CU4N8VecUxoskFcYNN8e+HveVYceVBS Rn3hi+qMSV+8SpQD92E36ID22Gj04cBmfU4E78L/vVEu7MONhKpNTE5PPu+yFAXGMcFL CBW/AeQ1In9bxyyekUu/Hzoh4hlhmFLN9zvZ9EhvIipeoWy/d+l0PZG7QhuaQqMzR0UE MMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=1VV+xq086UX8c6jCatmwEDXtaJKBj6cnEMKuwv2eIek=; b=psG0OL2cDJ6ayRcQavcuwQr4cIFMiyIhaXnxGmFNyefWAPbxOSn7Xp2E02IQtqdOjV Sp2wRNVQ/uJvfznl4MeoPKXMqs9wk5vDyYX2Sc2JjjT29lPBO7UK7uAh84M4MACoeWR9 kYyA75f8yq1rzeLTNdipVlhg8DTW0ombaGm/pTB/1T43rR+xSmmnD67KNidMPwrlweu3 +bnYdMan/cJ8mUK8NsnrMeD1fYosLJ2pfuTbWVOeOmMS42zfQ3SgFSe/eeR1Bpqcgp00 wkUlIzc+Xfgx2SUaum/CdJmxSpfwyJkys+Z4oU5J7gBxs4gELP2W1rPw1ouZ+LZKvAHe 4bFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si8928672pfa.223.2019.06.10.10.25.51; Mon, 10 Jun 2019 10:26:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbfFJRZS (ORCPT + 99 others); Mon, 10 Jun 2019 13:25:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbfFJRZR (ORCPT ); Mon, 10 Jun 2019 13:25:17 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31DE23EDBF; Mon, 10 Jun 2019 17:25:01 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-117-27.ams2.redhat.com [10.36.117.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AE095B681; Mon, 10 Jun 2019 17:24:45 +0000 (UTC) From: Florian Weimer To: Yu-cheng Yu Cc: Dave Martin , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file References: <20190606200646.3951-1-yu-cheng.yu@intel.com> <20190606200646.3951-23-yu-cheng.yu@intel.com> <20190607180115.GJ28398@e103592.cambridge.arm.com> <94b9c55b3b874825fda485af40ab2a6bc3dad171.camel@intel.com> Date: Mon, 10 Jun 2019 19:24:43 +0200 In-Reply-To: <94b9c55b3b874825fda485af40ab2a6bc3dad171.camel@intel.com> (Yu-cheng Yu's message of "Mon, 10 Jun 2019 09:29:04 -0700") Message-ID: <87lfy9cq04.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 10 Jun 2019 17:25:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yu-cheng Yu: > To me, looking at PT_GNU_PROPERTY and not trying to support anything is a > logical choice. And it breaks only a limited set of toolchains. > > I will simplify the parser and leave this patch as-is for anyone who wants to > back-port. Are there any objections or concerns? Red Hat Enterprise Linux 8 does not use PT_GNU_PROPERTY and is probably the largest collection of CET-enabled binaries that exists today. My hope was that we would backport the upstream kernel patches for CET, port the glibc dynamic loader to the new kernel interface, and be ready to run with CET enabled in principle (except that porting userspace libraries such as OpenSSL has not really started upstream, so many processes where CET is particularly desirable will still run without it). I'm not sure if it is a good idea to port the legacy support if it's not part of the mainline kernel because it comes awfully close to creating our own private ABI. Thanks, Florian