Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3555323ybi; Mon, 10 Jun 2019 12:15:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxxUBo79utksis7CvgtHdU4NFurP/q3AAc6ZPfts3jOoHmjh1x3W0KICBSiRlhU0jXEIIS X-Received: by 2002:a17:902:e011:: with SMTP id ca17mr4669523plb.328.1560194126106; Mon, 10 Jun 2019 12:15:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560194126; cv=none; d=google.com; s=arc-20160816; b=b7Xxhw6JNFRsTZRxyoAThNEI11Jgd7yOtnBKK4JoFzxAZ52hiEXRe0gHl6W3L9AJQY hg+y1j89E9jkkt+28SrTREidi5pkS+1UIpRfxx+12dNctX1IAhtoUvBXI92INWjQIthF kPx53GfsKvnpeoaq6NQESfNpDqnTFCYCJOS37QJqbSWI+itZ/h4kn1JA+4rbITk7N0Na cg7jO9Qw6w7NOviGUyrpwFJq4fJqTKhmZqKr4Nb/lZnNyA3glrr7yrgJOptbO6/teaWU zq+BmppRyzGH2DdxJ59SBR1yAEzreYYgEZdQV4e/uAPWeOXMt4Okvr9e5Hgxin7jDsDn oOug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3U3sA7JK4Wx4xJS71wfGXZ4KSvEZtwk1XyQ4suCC7B8=; b=U4TEsOdQCGBCyrCMc2RYmd2x+HPmtdA/a9/9NjydNkjXA1Jry4EezsvrnZa/cOEWEK 836HVZgtkOM+Ea8tpQPMxv0gorRaazQyJzZCyIjgbS4+llgGYWpSUPAfe3wTl3epUVqg SUVO+GoU8fpHjdiOzTNFFI3gscuvktq3pdmQMDkAkJnVFk8Jw9PmVai5ww/yNsUrqIda ePzapsJ/8l/c9ktXRM5GTxTeQi6i6IFXjfCWGQrzD/W6wE9YzJQ47lWizBwjV+pfrOaJ XSnl3acT9Tn/j+yGnJDPsNlCOkDLoRYia7R4TYoZNLK+zorlQLyC29QLDZSNdsbwTCY8 YbqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BoFQLMwX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s15si255384pjp.38.2019.06.10.12.15.11; Mon, 10 Jun 2019 12:15:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BoFQLMwX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389341AbfFJTOp (ORCPT + 99 others); Mon, 10 Jun 2019 15:14:45 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:41869 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389290AbfFJTOl (ORCPT ); Mon, 10 Jun 2019 15:14:41 -0400 Received: by mail-ua1-f65.google.com with SMTP id n2so3525329uad.8; Mon, 10 Jun 2019 12:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3U3sA7JK4Wx4xJS71wfGXZ4KSvEZtwk1XyQ4suCC7B8=; b=BoFQLMwXN/UZRVJyQluQO+IOXl42mInR39LPWD30FsUVUbwEcOlNCwBRSs675vWfTp nDqqZC1kbJ5x4khJxDiawgPzJ5IcAGNh1tPH2eugTRlOKxMFBm3LjVwZKYadSI/l/qWa 0YP0ZfnQClFEIDjaqch6oLsjPXAWHQx3LovF86tLYwakeGuSfkV6h3h1DRFLr2qfNIWr HQigF/Ymtnn8lCCeTJXeLY/TAhQxJJ3VOPEallbf+zk3hBFBgj9N38eBPUVnb4C1sgkK APKy17dJTO2PC8mMUr8vpM34yPNj8ugLwG9vVxthcoEXlLID1am+Z6isAI3lhI6/lmFh pb1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3U3sA7JK4Wx4xJS71wfGXZ4KSvEZtwk1XyQ4suCC7B8=; b=cyXAi90wfIVRqHjQ/iVqGtjI8uY/cpGGUOGxsYC+EtVeI8qiU9IYoE3x1FLF7D7c4v ZBs+OAMejVeM4y6uLAlLqTEzeGRLdhA+shsC7Xbo7CCM5+sWNs2yMMmGh8E1iFLqzQpq T7CWpUsrt5FKw47K/xLvZXBmqKHsQOmPn0WFzm7WSb+WIB1O60LOPX4Kp40cg7aGpCph gu9jgNk2pIjmdtN2AsRNrn6DvIB4/X+p3ypYgxRGDsw/FzBFjBnTlWTWeffpKSOaQ98z 83PoXr7jGX9EbUFPnQYHDePfLMG8VGTh//dWpmNbidtpxNUX7U2xImwdBRPZUatKTZqa R18w== X-Gm-Message-State: APjAAAX995cWUtUnIWsmA4/b345sq7AXZwlLzl8MMM6HslJxoYKrvzXM tAZ7N9HBQIEetlfpFVvKf0/KBaj4rA== X-Received: by 2002:ab0:2c09:: with SMTP id l9mr5860205uar.6.1560194080267; Mon, 10 Jun 2019 12:14:40 -0700 (PDT) Received: from kmo-pixel.hsd1.vt.comcast.net (c-71-234-172-214.hsd1.vt.comcast.net. [71.234.172.214]) by smtp.gmail.com with ESMTPSA id t20sm4834014vkd.53.2019.06.10.12.14.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 12:14:39 -0700 (PDT) From: Kent Overstreet To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcache@vger.kernel.org Cc: Kent Overstreet Subject: [PATCH 09/12] bcache: optimize continue_at_nobarrier() Date: Mon, 10 Jun 2019 15:14:17 -0400 Message-Id: <20190610191420.27007-10-kent.overstreet@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610191420.27007-1-kent.overstreet@gmail.com> References: <20190610191420.27007-1-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Kent Overstreet --- drivers/md/bcache/closure.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h index c88cdc4ae4..376c5e659c 100644 --- a/drivers/md/bcache/closure.h +++ b/drivers/md/bcache/closure.h @@ -245,7 +245,7 @@ static inline void closure_queue(struct closure *cl) != offsetof(struct work_struct, func)); if (wq) { INIT_WORK(&cl->work, cl->work.func); - BUG_ON(!queue_work(wq, &cl->work)); + queue_work(wq, &cl->work); } else cl->fn(cl); } @@ -340,8 +340,13 @@ do { \ */ #define continue_at_nobarrier(_cl, _fn, _wq) \ do { \ - set_closure_fn(_cl, _fn, _wq); \ - closure_queue(_cl); \ + closure_set_ip(_cl); \ + if (_wq) { \ + INIT_WORK(&(_cl)->work, (void *) _fn); \ + queue_work((_wq), &(_cl)->work); \ + } else { \ + (_fn)(_cl); \ + } \ } while (0) /** -- 2.20.1