Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <13f306216ca9bcad563da4d86c55549645e061af.camel@perches.com>
Subject: Re: [PATCH] ipv6: exthdrs: fix warning comparison to bool
From:   Joe Perches <joe@perches.com>
To:     David Miller <davem@davemloft.net>, hariprasad.kelam@gmail.com
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 10 Jun 2019 12:24:58 -0700
In-Reply-To: <20190609.195420.1742255944804133266.davem@davemloft.net>
References: <20190608083532.GA7288@hari-Inspiron-1545>
         <20190609.195420.1742255944804133266.davem@davemloft.net>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2019-06-09 at 19:54 -0700, David Miller wrote:
> From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> Date: Sat, 8 Jun 2019 14:05:33 +0530
> 
> > Fix below warning reported by coccicheck
> > 
> > net/ipv6/exthdrs.c:180:9-29: WARNING: Comparison to bool
> > 
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>  ...
> > diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> > index ab5add0..e137325 100644
> > --- a/net/ipv6/exthdrs.c
> > +++ b/net/ipv6/exthdrs.c
> > @@ -177,7 +177,7 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs,
> >                                       /* type specific length/alignment
> >                                          checks will be performed in the
> >                                          func(). */
> > -                                     if (curr->func(skb, off) == false)
> > +                                     if (!curr->func(skb, off))
> 
> curr->func() returns type 'bool', whats wrong with comparing against the
> same type?
> 
> I'm not applying stuff like this, sorry.

Looking at the function, it seems odd to have
some direct uses of "return false" and others
of "goto bad" where bad: does kfree_skb.

If all of the direct uses of return false are
correct, it could be useful to document why.