Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3647012ybi; Mon, 10 Jun 2019 14:05:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlWECiYDbGh1xPMVAeSSCedyb2Gp/fxsrzm/jccRrdGdiP5HYN8ol+XouUjFT68r833mZb X-Received: by 2002:a17:90a:2228:: with SMTP id c37mr23531371pje.9.1560200715098; Mon, 10 Jun 2019 14:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560200715; cv=none; d=google.com; s=arc-20160816; b=y00ZqhiRlTMB/4EhxK9eVlQErZJYI67nUx+mZtC6/d0wXOmjfFJBUayXaUbD+YGRdw KZz/PLFUlKqGVtx0cDU0qReN7U3wbOXXK1wvaJi8i7c6/gExngNH28oyidNuhQN0E77q LW1g5G+D10Pb5RcSn4PDttVoQETafUlAI7oB3TMx9636pOU6s2KRw3C7bpkHAE+zSLAB gAzRW7OzWyjAmO3skUMnEHO/54pkYxxxFsvLG7N2+gkOeH4TuchJyT6vPAq5Qjqo+cgc W1eUk5dHrmouuse0G1RmGJeyA4pMTdlZhwM3Tue/LpxAWwGf3karcKJD8koP9fBlvG7c QjTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=2zoMGe+QE+yzab+TeWidtBbChMnFTH1yQKOBg/JPkKc=; b=0wkJ/IF+OrIyAHzOfruhiWhQ+v2Ms/kjWLzGeWugnpIy7HoekpziN3HzeK/pB2X8UG +YO5QNmYZSNqhcz/P3DgZenVTYQpY5WUNwia3LZNDzwDHoJb5VACmkKFMLzjoYTVM7ym mc1YWyHnktBRYVwu4AFPfbXVMlIqWMCttVv/+KcSPaMArHbNfNDceKXmrHycLbo8s6sX cnPFoFek9XJWy2LiB/dNSjE6Rv6uILUniq4h4watViSPt9WOjTSh2wadGRehMpzqZgKU CoQaeQpHz6PLbXc+gFdp6d1KRcvn9XVdRNX/OD6Xhtp7urk/R1dSc62G/EpTmKY3wAge odBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si11514656pfz.30.2019.06.10.14.05.00; Mon, 10 Jun 2019 14:05:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389742AbfFJVDg (ORCPT + 99 others); Mon, 10 Jun 2019 17:03:36 -0400 Received: from smtp3.emailarray.com ([65.39.216.17]:39971 "EHLO smtp3.emailarray.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388342AbfFJVDf (ORCPT ); Mon, 10 Jun 2019 17:03:35 -0400 Received: (qmail 34735 invoked by uid 89); 10 Jun 2019 20:56:55 -0000 Received: from unknown (HELO ?172.20.174.171?) (amxlbW9uQGZsdWdzdmFtcC5jb21AMTk5LjIwMS42NC4y) (POLARISLOCAL) by smtp3.emailarray.com with (AES256-GCM-SHA384 encrypted) SMTP; 10 Jun 2019 20:56:55 -0000 From: "Jonathan Lemon" To: "Ilya Maximets" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, "David S. Miller" , "=?utf-8?b?QmrDtnJuIFTDtnBlbA==?=" , "Magnus Karlsson" Subject: Re: [PATCH bpf] xdp: check device pointer before clearing Date: Mon, 10 Jun 2019 13:56:49 -0700 X-Mailer: MailMate (1.12.5r5635) Message-ID: <76A4186A-5495-4003-A494-7DE0B15EFB1A@flugsvamp.com> In-Reply-To: <20190607172732.4710-1-i.maximets@samsung.com> References: <20190607172732.4710-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 Jun 2019, at 10:27, Ilya Maximets wrote: > We should not call 'ndo_bpf()' or 'dev_put()' with NULL argument. > > Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and > zero-copy on one queue id") > Signed-off-by: Ilya Maximets Acked-by: Jonathan Lemon