Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3663748ybi; Mon, 10 Jun 2019 14:23:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJSrXPqZWa3B0np623wofNBOxHQUfcSVH/3Xctqjbg9+USnYoGddfP2Rj2ancLucIgWhK2 X-Received: by 2002:a62:d45d:: with SMTP id u29mr12161987pfl.135.1560201827691; Mon, 10 Jun 2019 14:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560201827; cv=none; d=google.com; s=arc-20160816; b=FSBG9KZteo1/WSBmMXIAL6QSdnWA5zJTL3k88e/4pSrMabhrP7MCoJH93Uljy0Hh8Y VtUygONrANdSB8eVPBagROQoh9RUsB0VhCnuMH0h7LYLZP3rWaY6TID8xYFjNfXktVf8 +kVRWxem0yLzZEL+ZJPr4DNUbd7IW2j6AbXZtz1GN8rb1DfOvqWoL+9SPVb3a0yf/4Bk 9ZL4joobQFK13pJuHsh6HA1VP7wPublsonUgVl6Vouvyhfgw0vD/PPYOYqQ/myfY88lY gPNhCKNEsadKvwTYbVVhloN8HGCf+bNQgaTbZqvB065N2EMOl14g55WMmoR3Js/i24BT Y7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gk2LT6fcQsSzPtvSDO++ABbQbp8Uy6r4UjS6ey/0Juc=; b=KmpAyNZdiEcIPYjlGtbCAY5gwHoh1a/LLMrmLhVeiUvNMTwUnUoruIQ5GSM79tj8rd XQ02UHXZvT0DZjzaoe1uZw08Dst6LmGtrZujQmeMf7s6NOfpkULxJgyCw94CKbfw//oc zWmQ6Q+M1H6nrIKCsFdaXS/FRy2W4ZukehBw5WgDxMQ7lFplhFt4059dXpoVdO4nhSOQ GP/BStJszqyMAZvTMsps574XY1LfTXtd6clME76JthP4AONKvqpDNjEk82+8KbbUfAKQ 0IOVccY8WYfi2dmA86ajlNZUBrYwI/DLCbUU8cPs0At/zFvbqSfx+vsuBhOCzJobj3Cr weeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=K33EzM6D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b38si10563808pgb.250.2019.06.10.14.23.32; Mon, 10 Jun 2019 14:23:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=K33EzM6D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390439AbfFJVVf (ORCPT + 99 others); Mon, 10 Jun 2019 17:21:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:40280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390072AbfFJVUf (ORCPT ); Mon, 10 Jun 2019 17:20:35 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 253C220859; Mon, 10 Jun 2019 21:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560201634; bh=gk2LT6fcQsSzPtvSDO++ABbQbp8Uy6r4UjS6ey/0Juc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K33EzM6D4Va30ZI5NAiOD9fA+ukRykQXFJG5QhB6faCgv/G+xtgEoePHQSqT5UjMf Bivmju9CUBeJZRonOrZqoGsgPv0BZspRU37kfy3jf/Fs2eucmqTIhI2BCqIwrogQjH ZNVIH2JyUj2bBFOcXqonoxSslpKMrOvFcjoAwiYE= Date: Mon, 10 Jun 2019 14:20:33 -0700 From: Andrew Morton To: Naoya Horiguchi Cc: linux-mm@kvack.org, Michal Hocko , Mike Kravetz , xishi.qiuxishi@alibaba-inc.com, "Chen, Jerry T" , "Zhuo, Qiuxu" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: soft-offline: return -EBUSY if set_hwpoison_free_buddy_page() fails Message-Id: <20190610142033.6096a8ec73d4bf40b2612fb5@linux-foundation.org> In-Reply-To: <1560154686-18497-2-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1560154686-18497-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1560154686-18497-2-git-send-email-n-horiguchi@ah.jp.nec.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jun 2019 17:18:05 +0900 Naoya Horiguchi wrote: > The pass/fail of soft offline should be judged by checking whether the > raw error page was finally contained or not (i.e. the result of > set_hwpoison_free_buddy_page()), but current code do not work like that. > So this patch is suggesting to fix it. Please describe the user-visible runtime effects of this change?