Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbVKUQXL (ORCPT ); Mon, 21 Nov 2005 11:23:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932374AbVKUQXK (ORCPT ); Mon, 21 Nov 2005 11:23:10 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:27013 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S932372AbVKUQXJ (ORCPT ); Mon, 21 Nov 2005 11:23:09 -0500 Subject: Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node From: Pekka Enberg To: Eric Dumazet Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, manfred@colorfullife.com, christoph@lameter.com In-Reply-To: <4381EE9D.1000506@cosmosbay.com> References: <4381EE9D.1000506@cosmosbay.com> Date: Mon, 21 Nov 2005 18:23:06 +0200 Message-Id: <1132590187.8487.13.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 522 Lines: 17 Hi Eric, On Mon, 2005-11-21 at 16:58 +0100, Eric Dumazet wrote: > Are you sure this is valid ? > What about preemption ? > The "if (nodeid == numa_node_id())" check was done with IRQ off, and you want > do do it with IRQ on. You're right. Please ignore the patch. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/