Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Adrian Hunter <adrian.hunter@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        David Carrillo Cisneros <davidca@fb.com>,
        Milian Wolff <milian.wolff@kdab.com>,
        Jiri Olsa <jolsa@kernel.org>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>
Subject: Re: [PATCH] perf script/intel-pt: set synth_opts.callchain for
 use_browser > 0
Thread-Topic: [PATCH] perf script/intel-pt: set synth_opts.callchain for
 use_browser > 0
Thread-Index: AQHVH+Yx7p0qFbqvmEmy4wLpGw5xK6aWApkAgAAJPQA=
Date:   Tue, 11 Jun 2019 07:18:09 +0000
Message-ID: <F8963F4B-46FF-41D2-B261-6DD2EE898D93@fb.com>
References: <20190610234216.2849236-1-songliubraving@fb.com>
 <def87b9f-a4fa-37ff-722a-9f14b14b2c7b@intel.com>
In-Reply-To: <def87b9f-a4fa-37ff-722a-9f14b14b2c7b@intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <04CD47207BEF8141A133719DAE4A7E91@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bc004123-9a89-4fcd-ecd0-08d6ee3cf51b
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2019 07:18:09.5789
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1664
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-11_03:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906110051
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 10, 2019, at 11:45 PM, Adrian Hunter <adrian.hunter@intel.com> wro=
te:
>=20
> On 11/06/19 2:42 AM, Song Liu wrote:
>> Currently, intel_pt_process_auxtrace_info() sets synth_opts.callchain fo=
r
>> use_browser !=3D -1, which is not accurate after we set use_browser to 0=
 in
>> cmd_script(). As a result, the following commands sees a lot more errors
>> like:
>>=20
>>  perf record -e intel_pt//u -C 10 -- sleep 3
>>  perf script
>>=20
>>  ...
>>  instruction trace error type 1 time ...
>>  ...
>>=20
>> This patch fixes this by checking use_browser > 0 instead.
>>=20
>> Fixes: c1c9b9695cc8 ("perf script: Allow extended console debug output")
>> Reported-by: David Carrillo Cisneros <davidca@fb.com>
>> Cc: Milian Wolff <milian.wolff@kdab.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> tools/perf/util/intel-pt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
>> index 6d288237887b..15692c104ca8 100644
>> --- a/tools/perf/util/intel-pt.c
>> +++ b/tools/perf/util/intel-pt.c
>> @@ -2588,7 +2588,7 @@ int intel_pt_process_auxtrace_info(union perf_even=
t *event,
>> 	} else {
>> 		itrace_synth_opts__set_default(&pt->synth_opts,
>> 				session->itrace_synth_opts->default_no_sample);
>> -		if (use_browser !=3D -1) {
>> +		if (use_browser > 0) {
>=20
> That code has changed recently.  Refer:
>=20
> 	https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=
=3Dperf/core&id=3D26f19c2eb7e54

Thanks for a better fix! I was using Arnaldo's perf/urgent branch, and miss=
ed
this one.=20

Song

>=20
>=20
>> 			pt->synth_opts.branches =3D false;
>> 			pt->synth_opts.callchain =3D true;
>> 		}