Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4125207ybi; Tue, 11 Jun 2019 01:10:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzwRIrq7SkaH2ur1OVXqvsRlenO76Z2rtr7ZHDnDM1ekilfhvR2A3Ilx23pxmxZMOqqahT X-Received: by 2002:a63:de53:: with SMTP id y19mr19230338pgi.166.1560240621905; Tue, 11 Jun 2019 01:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560240621; cv=none; d=google.com; s=arc-20160816; b=p5si0QhctgDaqpG/iwmhvLMTcM9Q3DheihUHvwxcqFkfCH4ZXUTU8NL02zvAIoHNPx bhG4UKcJJeZ3oIO/KTPdldzZ0CAQ0i4aljlEaIny9cggEvEJGKoZjuRLdHryZ5icgcaX REA19x/Lj074QilJHNoq9VJL68s2o2AEdsufb4RiiY9rGinQChXjjtW1V8u3A5sHPXc8 werGo7c5kNDFEAhF44wPUBVX5Wa63aQKkrBDGIDmIIBpBQxbM+xJhL6n+wHR0aztSJDg sSd9Cj5vqfDqLBEHIApqi63NuHsM9c/t2M+a1su8m2TUKqPsYlsvRb+VIVNvS1JTDRdQ KfmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Pot+GXEKrsbMJzE4bYWvLSbsXA224OtC6xDha4ON4Ls=; b=U1FqJdLX7vrUOQdkp63+Y20LKcRhjNhxDDpmPnxuHrxCiNnaaZzh+JGMwLuMQt1Qdp YOwbIEiABze4IsQz2ChgKFzvJ2TmpxcJ2wf9ysfMF/2jLS2BIihdsxwGBflKC+cX6bw/ vPwLRQd9ctIcCgSBSdxlP6rQsGl2G9N/Ym1/BbL7EalQZgq9QErQ9dgUBcu7wDiF1xJj wthwpZHOEEpx5gYlWHB/HYsaI4KbsULooSx9jbFsteBjgBX67qaqvRzp4oQxzx0n613n fN0F1DeTPAp6x1pOcqEy3diam+prUCkH9uP/hcoC0KK6L6OHKGSSBRdeGB7b2invCXs9 N8KA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18si1705681pjq.71.2019.06.11.01.10.04; Tue, 11 Jun 2019 01:10:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404513AbfFKHy1 (ORCPT + 99 others); Tue, 11 Jun 2019 03:54:27 -0400 Received: from verein.lst.de ([213.95.11.211]:48933 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403815AbfFKHy0 (ORCPT ); Tue, 11 Jun 2019 03:54:26 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 92C8268B02; Tue, 11 Jun 2019 09:53:58 +0200 (CEST) Date: Tue, 11 Jun 2019 09:53:58 +0200 From: Christoph Hellwig To: Benjamin Herrenschmidt Cc: Christoph Hellwig , Larry Finger , Aaro Koskinen , Christian Zigotzky , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook Message-ID: <20190611075358.GA21815@lst.de> References: <20190605225059.GA9953@darkstar.musicnaut.iki.fi> <73da300c-871c-77ac-8a3a-deac226743ef@lwfinger.net> <7697a9d10777b28ae79fdffdde6d0985555f6310.camel@kernel.crashing.org> <3ed1ccfe-d7ca-11b9-17b3-303d1ae1bb0f@lwfinger.net> <20190611060816.GA20158@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 04:58:12PM +1000, Benjamin Herrenschmidt wrote: > ... which b43legacy doesn't set to the best of my knowledge ... > > Which makes me wonder how come it didn't work even with your patches ? > AFAIK, we have less than 1GB of lowmem unless the config has been > tweaked.... It needs to bounce to somewhere. And the dma-direct code is pretty strict to require a zone it can do allocations from when setting the dma mask. As was the old ppc64 code, but not the ppc32 code that allowed setting any DMA mask. And something about the more strict validation seem to trip up now.