Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4159511ybi; Tue, 11 Jun 2019 01:53:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLz8XrnGOkTw2UVrPvj28DVBhabv8MAwO34krikXHVVmOjI7/3WqHJBbyy2cB12qq+LNNr X-Received: by 2002:a17:90a:b00b:: with SMTP id x11mr25973370pjq.120.1560243218149; Tue, 11 Jun 2019 01:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560243218; cv=none; d=google.com; s=arc-20160816; b=aiud5mTvOMJGBOv6BZJquO2oIHurVJzKFj2GAFkgQhFD4uegJ06kPmJdUINRhqj58P Hl7ILa/dAxQ+Rtpa3ptWCF9qB696ZqutLb8on62ht7L7UWhPpSLTpTpSn7lal3GrOZ9N A1Np1/aZteN2NB3MoaB7JQTQNYT2y+iay+XRMP9082BSjM01jkGWXHtySh7FnkH2C/qi AxTUDDe3QlKHmkMBo9rgO0pRUy5AoIQLoijGpAmthT3nDjpLqHa/99mqz/OhmdPjvqhX Sgnw4DNgEw/+6nPeHFjAlE5lNmxGn6J02lH9qmrKf6A56rojE5+0lerKDlNozb2WD9Ow mEww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=fw6B61EqEGzKC1VqNXnFN1jOkyIjqLz+I7qC63gNclM=; b=fjb7NuVGEfRSylI8b9CAxjqkzlzTtaUtmWeFbGo+VfS6ZuITF8poOpwDXBV6NnFGSm /4X8R0BFbUxxpsTDy4E7xZpk7LW+5cr1JfjfT3vt0CtcITkRImpPNNZ9hruOlx7L2sKR Q+RW30m82i8VVW0C/alCVebh4U7gkhSLV2Xg0Xd96eYfdIKfCkInrdexjbJruYPLuvKS Bc/h3bDVyz5ABPgvbHTyUukcKukIKUlDbh1k1DqaDCDsv3r94j0mfLxQT2Wn7l/JuXN0 WdtEXc/JQMKEDm+5/5zl+iGBhfyuvb7YfSHFqbTzPhTL+8XkFNA3oQrb055ReH90da+X By3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si12149075plp.223.2019.06.11.01.53.23; Tue, 11 Jun 2019 01:53:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404391AbfFKIwR (ORCPT + 99 others); Tue, 11 Jun 2019 04:52:17 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:57473 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403860AbfFKIwR (ORCPT ); Tue, 11 Jun 2019 04:52:17 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hacVl-0000Hr-C9; Tue, 11 Jun 2019 10:52:09 +0200 Message-ID: <1560243127.13886.3.camel@pengutronix.de> Subject: Re: [PATCH v7 2/4] media: videodev2: add V4L2_FMT_FLAG_FIXED_RESOLUTION From: Philipp Zabel To: Hans Verkuil , Maxime Jourdan , Mauro Carvalho Chehab , Hans Verkuil Cc: Kevin Hilman , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Date: Tue, 11 Jun 2019 10:52:07 +0200 In-Reply-To: <9731b2db-efd4-87d0-c48d-87adec433747@xs4all.nl> References: <20190531093126.26956-1-mjourdan@baylibre.com> <20190531093126.26956-3-mjourdan@baylibre.com> <9731b2db-efd4-87d0-c48d-87adec433747@xs4all.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-06-05 at 15:39 +0200, Hans Verkuil wrote: > Hi Maxime, > > I am wondering if this flag shouldn't be inverted: you set > V4L2_FMT_FLAG_DYN_RESOLUTION if dynamic resolution is supported, > otherwise it isn't. > > Can all the existing mainlined codec drivers handle midstream > resolution changes? > > s5p-mfc, venus and mediatek can, but I see no SOURCE_CHANGE event in > the coda drivers, so I suspect that that can't handle this. > > Philipp, what is the status of the coda driver for dynamic resolution > changes? FTR, to my knowledge there is no dynamic resolution change support in the firmware, as there is no signal (interrupt nor picture run return value) to indicate that different headers were parsed. I am planning to add the initial source change event required by the current decoder API documentation, but I am afraid there will be no support for source changes due to mid-stream resolution changes due to firmware limitations. regards Philipp